mirror of
https://github.com/ddworken/hishtory.git
synced 2025-02-02 11:39:24 +01:00
Add TODOs
This commit is contained in:
parent
188ff1d0fa
commit
9c47afbe54
@ -1853,6 +1853,8 @@ func captureTerminalOutputWithShellName(t *testing.T, tester shellTester, overri
|
||||
return captureTerminalOutputWithShellNameAndDimensions(t, tester, overriddenShellName, 200, 50, commands)
|
||||
}
|
||||
|
||||
// TODO: add tests for auto-resizing. They can use the tmux resize-pane command
|
||||
|
||||
func captureTerminalOutputWithShellNameAndDimensions(t *testing.T, tester shellTester, overriddenShellName string, width, height int, commands []string) string {
|
||||
sleepAmount := "0.1"
|
||||
if runtime.GOOS == "linux" {
|
||||
|
@ -86,6 +86,7 @@ func OpenLocalSqliteDb() (*gorm.DB, error) {
|
||||
Colorful: false,
|
||||
},
|
||||
)
|
||||
// TODO: should I specify WAL here: https://stackoverflow.com/questions/57118674/go-sqlite3-with-journal-mode-wal-gives-database-is-locked-error
|
||||
db, err := gorm.Open(sqlite.Open(path.Join(homedir, data.HISHTORY_PATH, data.DB_PATH)), &gorm.Config{SkipDefaultTransaction: true, Logger: newLogger})
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to connect to the DB: %v", err)
|
||||
|
@ -112,6 +112,7 @@ func main() {
|
||||
if numImported > 0 {
|
||||
fmt.Printf("Imported %v history entries from your existing shell history\n", numImported)
|
||||
}
|
||||
// TODO: maybe trigger a checkpoint? I suspect that is the root cause of #24
|
||||
case "enable":
|
||||
ctx := hctx.MakeContext()
|
||||
lib.CheckFatalError(lib.Enable(ctx))
|
||||
@ -476,3 +477,6 @@ func export(ctx *context.Context, query string) {
|
||||
}
|
||||
|
||||
// TODO(feature): Add a session_id column that corresponds to the shell session the command was run in
|
||||
|
||||
// TODO: add a config option for timestamp formatting
|
||||
// TODO: handle control-c in the TUI
|
||||
|
Loading…
Reference in New Issue
Block a user