extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-06-11 07:36:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add TODOs

Browse Source
This commit is contained in:
David Dworken 2022-11-11 17:03:32 -05:00
parent 188ff1d0fa
commit 9c47afbe54
No known key found for this signature in database
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/client_test.go
View File

@ -1853,6 +1853,8 @@ func captureTerminalOutputWithShellName(t *testing.T, tester shellTester, overri
return captureTerminalOutputWithShellNameAndDimensions(t, tester, overriddenShellName, 200, 50, commands) return captureTerminalOutputWithShellNameAndDimensions(t, tester, overriddenShellName, 200, 50, commands)
} }
// TODO: add tests for auto-resizing. They can use the tmux resize-pane command
func captureTerminalOutputWithShellNameAndDimensions(t *testing.T, tester shellTester, overriddenShellName string, width, height int, commands []string) string { func captureTerminalOutputWithShellNameAndDimensions(t *testing.T, tester shellTester, overriddenShellName string, width, height int, commands []string) string {
sleepAmount := "0.1" sleepAmount := "0.1"
if runtime.GOOS == "linux" { if runtime.GOOS == "linux" {

1
client/hctx/hctx.go
View File

@ -86,6 +86,7 @@ func OpenLocalSqliteDb() (*gorm.DB, error) {
Colorful: false, Colorful: false,
}, },
) )
// TODO: should I specify WAL here: https://stackoverflow.com/questions/57118674/go-sqlite3-with-journal-mode-wal-gives-database-is-locked-error
db, err := gorm.Open(sqlite.Open(path.Join(homedir, data.HISHTORY_PATH, data.DB_PATH)), &gorm.Config{SkipDefaultTransaction: true, Logger: newLogger}) db, err := gorm.Open(sqlite.Open(path.Join(homedir, data.HISHTORY_PATH, data.DB_PATH)), &gorm.Config{SkipDefaultTransaction: true, Logger: newLogger})
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to connect to the DB: %v", err) return nil, fmt.Errorf("failed to connect to the DB: %v", err)

4
hishtory.go
View File

@ -112,6 +112,7 @@ func main() {
if numImported > 0 { if numImported > 0 {
fmt.Printf("Imported %v history entries from your existing shell history\n", numImported) fmt.Printf("Imported %v history entries from your existing shell history\n", numImported)
} }
// TODO: maybe trigger a checkpoint? I suspect that is the root cause of #24
case "enable": case "enable":
ctx := hctx.MakeContext() ctx := hctx.MakeContext()
lib.CheckFatalError(lib.Enable(ctx)) lib.CheckFatalError(lib.Enable(ctx))
@ -476,3 +477,6 @@ func export(ctx *context.Context, query string) {
} }
// TODO(feature): Add a session_id column that corresponds to the shell session the command was run in // TODO(feature): Add a session_id column that corresponds to the shell session the command was run in
// TODO: add a config option for timestamp formatting
// TODO: handle control-c in the TUI