More test reliability improvements to fix all test failure root causes from 10 sample runs on Github Actions

This commit is contained in:
David Dworken 2023-09-24 06:29:47 -07:00
parent ce9602d0df
commit cb95d4a396
No known key found for this signature in database

View File

@ -1575,6 +1575,7 @@ func testTui_resize(t testing.TB) {
out := captureTerminalOutputWithShellNameAndDimensions(t, tester, tester.ShellName(), 100, 20, []TmuxCommand{ out := captureTerminalOutputWithShellNameAndDimensions(t, tester, tester.ShellName(), 100, 20, []TmuxCommand{
{Keys: "hishtory SPACE tquery ENTER"}, {Keys: "hishtory SPACE tquery ENTER"},
}) })
require.Contains(t, out, "hishtory tquery")
out = strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]) out = strings.TrimSpace(strings.Split(out, "hishtory tquery")[1])
testutils.CompareGoldens(t, out, "TestTui-SmallTerminal") testutils.CompareGoldens(t, out, "TestTui-SmallTerminal")
@ -1678,7 +1679,7 @@ func testTui_delete(t testing.TB) {
// And that it stays deleted // And that it stays deleted
out = captureTerminalOutputWithComplexCommands(t, tester, []TmuxCommand{ out = captureTerminalOutputWithComplexCommands(t, tester, []TmuxCommand{
{Keys: "hishtory SPACE tquery ENTER", ExtraDelay: 1.0}, {Keys: "hishtory SPACE tquery ENTER", ExtraDelay: 1.5},
}) })
out = strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]) out = strings.TrimSpace(strings.Split(out, "hishtory tquery")[1])
testutils.CompareGoldens(t, out, "TestTui-DeleteAgainStill") testutils.CompareGoldens(t, out, "TestTui-DeleteAgainStill")
@ -1711,7 +1712,7 @@ func testTui_search(t testing.TB) {
out = captureTerminalOutputWithComplexCommands(t, tester, []TmuxCommand{ out = captureTerminalOutputWithComplexCommands(t, tester, []TmuxCommand{
{Keys: "hishtory SPACE tquery ENTER"}, {Keys: "hishtory SPACE tquery ENTER"},
// Extra delay to ensure that the search for 'ls' finishes before we select an entry // Extra delay to ensure that the search for 'ls' finishes before we select an entry
{Keys: "ls", ExtraDelay: 1.0}, {Keys: "ls", ExtraDelay: 1.5},
{Keys: "ENTER"}, {Keys: "ENTER"},
}) })
out = strings.Split(strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]), "\n")[0] out = strings.Split(strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]), "\n")[0]