extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-02-13 00:50:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make unused goldens check in tests more lenient with goldens that are OS-specific

Browse Source
This commit is contained in:
David Dworken 2023-12-28 19:52:39 -08:00
parent 29adbd2372
commit db19d8ebf1
No known key found for this signature in database
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
client/posttest/main.go
View File

@ -63,7 +63,16 @@ func checkGoldensUsed() {
// And check for mismatches // And check for mismatches
for _, f := range files { for _, f := range files {
goldenName := path.Base(f.Name()) goldenName := path.Base(f.Name())
if !slices.Contains(usedGoldens, goldenName) && !slices.Contains(UNUSED_GOLDENS, goldenName) { if !slices.Contains(usedGoldens, goldenName) {
if slices.Contains(UNUSED_GOLDENS, goldenName) {
// It is allowlisted to not be used
continue
}
if (runtime.GOOS == "darwin" && strings.Contains(goldenName, "-linux")) ||
(runtime.GOOS == "linux" && strings.Contains(goldenName, "-darwin")) {
// It is for another OS
continue
}
err = fmt.Errorf("golden file %v was never used", goldenName) err = fmt.Errorf("golden file %v was never used", goldenName)
fmt.Println(err) fmt.Println(err)
log.Fatalf("%v", err) log.Fatalf("%v", err)