[bug] fix search breaking when searching links with empty url or name

This commit is contained in:
Kuldeep M 2019-06-18 11:42:34 +01:00
parent d5dcaea23d
commit 4e82d797aa
3 changed files with 12 additions and 5 deletions

View File

@ -55,9 +55,16 @@ var search = (function() {
};
searchedBookmarks.total = bookmarks.get().length;
bookmarks.get().forEach(function(arrayItem, index) {
if (arrayItem.url.replace(/^https?\:\/\//i, "").replace(/\/$/, "").toLowerCase().includes(searchInput.value.toLowerCase().replace(/\s/g, "")) || arrayItem.name.toLowerCase().includes(searchInput.value.toLowerCase().replace(/\s/g, ""))) {
var bookmarkDataCopy = JSON.parse(JSON.stringify(arrayItem));
searchedBookmarks.matching.push(bookmarkDataCopy);
if (arrayItem.url != null) {
if (arrayItem.url.replace(/^https?\:\/\//i, "").replace(/\/$/, "").toLowerCase().includes(searchInput.value.toLowerCase().replace(/\s/g, ""))) {
var bookmarkDataCopy = JSON.parse(JSON.stringify(arrayItem));
searchedBookmarks.matching.push(bookmarkDataCopy);
};
} else if (arrayItem.name != null) {
if (arrayItem.name.toLowerCase().includes(searchInput.value.toLowerCase().replace(/\s/g, ""))) {
var bookmarkDataCopy = JSON.parse(JSON.stringify(arrayItem));
searchedBookmarks.matching.push(bookmarkDataCopy);
};
};
});
return searchedBookmarks;

View File

@ -1,6 +1,6 @@
var version = (function() {
var current = "3.16.2";
var current = "3.16.3";
var compare = function(a, b) {
var pa = a.split(".");

View File

@ -2,7 +2,7 @@
"name": "nightTab",
"short_name": "nightTab",
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
"version": "3.16.2",
"version": "3.16.3",
"manifest_version": 2,
"chrome_url_overrides": {
"newtab": "index.html"