extern/nightTab
1
0
Fork 0
mirror of https://github.com/zombieFox/nightTab.git synced 2024-11-24 17:14:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] improve link add and edit form help text

Browse Source
This commit is contained in:
Kuldeep M 2019-07-29 17:27:39 +01:00
parent a6aa73e194
commit 682b238c0f
4 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/css/form.css
View File

@ -1032,7 +1032,7 @@ input[type="range"][disabled]::-moz-range-progress {
.form-group { .form-group {
margin: 0 0 1em 0; margin: 0 0 1em 0;
display: inline-flex; display: flex;
justify-content: flex-start; justify-content: flex-start;
align-items: stretch; align-items: stretch;
width: 100%; width: 100%;

16
src/js/link.js
View File

@ -476,7 +476,7 @@ var link = (function() {
form.querySelector(".link-form-input-icon").setAttribute("disabled", ""); form.querySelector(".link-form-input-icon").setAttribute("disabled", "");
form.querySelector(".form-group-text").setAttribute("disabled", ""); form.querySelector(".form-group-text").setAttribute("disabled", "");
form.querySelector(".link-form-input-icon").setAttribute("disabled", ""); form.querySelector(".link-form-input-icon").setAttribute("disabled", "");
form.querySelector(".link-form-input-helper-icon").setAttribute("disabled", ""); helper.addClass(form.querySelector(".link-form-input-icon-helper"), "disabled");
form.querySelector(".link-form-icon-clear").setAttribute("disabled", ""); form.querySelector(".link-form-icon-clear").setAttribute("disabled", "");
form.querySelector(".link-form-text-icon").tabIndex = -1; form.querySelector(".link-form-text-icon").tabIndex = -1;
} else if (stagedLink.data.display == "icon") { } else if (stagedLink.data.display == "icon") {
@ -484,7 +484,7 @@ var link = (function() {
form.querySelector(".link-form-input-icon").removeAttribute("disabled"); form.querySelector(".link-form-input-icon").removeAttribute("disabled");
form.querySelector(".form-group-text").removeAttribute("disabled"); form.querySelector(".form-group-text").removeAttribute("disabled");
form.querySelector(".link-form-input-icon").removeAttribute("disabled"); form.querySelector(".link-form-input-icon").removeAttribute("disabled");
form.querySelector(".link-form-input-helper-icon").removeAttribute("disabled"); helper.removeClass(form.querySelector(".link-form-input-icon-helper"), "disabled");
form.querySelector(".link-form-icon-clear").removeAttribute("disabled"); form.querySelector(".link-form-icon-clear").removeAttribute("disabled");
form.querySelector(".link-form-input-display-icon").checked = true; form.querySelector(".link-form-input-display-icon").checked = true;
form.querySelector(".link-form-text-icon").tabIndex = 1; form.querySelector(".link-form-text-icon").tabIndex = 1;
@ -593,7 +593,7 @@ var link = (function() {
var iconFormGroupText = helper.node("div|class:form-group-text link-form-text-icon,tabindex:-1,disabled"); var iconFormGroupText = helper.node("div|class:form-group-text link-form-text-icon,tabindex:-1,disabled");
var iconFormGroupClear = helper.node("button|class:link-form-icon-clear button mb-0,type:button,tabindex:1,disabled"); var iconFormGroupClear = helper.node("button|class:link-form-icon-clear button mb-0,type:button,tabindex:1,disabled");
var iconFormGroupClearIcon = helper.node("span|class:icon-close"); var iconFormGroupClearIcon = helper.node("span|class:icon-close");
var iconPara = helper.node("p:Refer to the \"Free\" and \"Brand\" icons from FontAwesome for full set of icons supported.|class:link-form-input-helper-icon input-helper small muted,disabled"); var iconPara = helper.node("p:Refer to the \"Free\" and \"Brand\" icons from FontAwesome for full set of icons supported.|class:link-form-input-icon-helper form-helper small muted disabled");
var nameInputWrap = helper.node("div|class:input-wrap"); var nameInputWrap = helper.node("div|class:input-wrap");
var nameLabel = helper.node("label:Name|for:link-form-input-name"); var nameLabel = helper.node("label:Name|for:link-form-input-name");
var nameInput = helper.node("input|type:text,class:link-form-input-name mb-0,id:link-form-input-name,placeholder:Example,tabindex:1,autocomplete:off,autocorrect:off,autocapitalize:off,spellcheck:false"); var nameInput = helper.node("input|type:text,class:link-form-input-name mb-0,id:link-form-input-name,placeholder:Example,tabindex:1,autocomplete:off,autocorrect:off,autocapitalize:off,spellcheck:false");
@ -601,12 +601,12 @@ var link = (function() {
var urlLabel = helper.node("label:URL|for:link-form-input-url"); var urlLabel = helper.node("label:URL|for:link-form-input-url");
var urlInput = helper.node("input|type:text,class:link-form-input-url mb-0,id:link-form-input-url,placeholder:https://www.example.com/,tabindex:1,autocomplete:off,autocorrect:off,autocapitalize:off,spellcheck:false"); var urlInput = helper.node("input|type:text,class:link-form-input-url mb-0,id:link-form-input-url,placeholder:https://www.example.com/,tabindex:1,autocomplete:off,autocorrect:off,autocapitalize:off,spellcheck:false");
var colorWrap = helper.node("div|class:input-wrap"); var colorWrap = helper.node("div|class:input-wrap");
var colorFormGroup = helper.node("div|class:form-group"); var colorFormGroup = helper.node("div|class:form-group mb-0");
var colorLabel = helper.node("label:Accent override|for:link-form-input-color"); var colorLabel = helper.node("label:Accent override|for:link-form-input-color");
var colorInput = helper.node("input|id:link-form-input-color,class:link-form-input-color mb-0,type:color,value:" + helper.rgbToHex(state.get().theme.accent.current) + ",tabindex:1"); var colorInput = helper.node("input|id:link-form-input-color,class:link-form-input-color mb-0,type:color,value:" + helper.rgbToHex(state.get().theme.accent.current) + ",tabindex:1");
var colorButtonRefresh = helper.node("button|class:button mb-0,type:button,tabindex:1"); var colorButtonRefresh = helper.node("button|class:button mb-0,type:button,tabindex:1");
var colorButtonRefreshIcon = helper.node("span|class:icon-refresh"); var colorButtonRefreshIcon = helper.node("span|class:icon-refresh");
var colorPara = helper.node("p:Use this colour to override the global Accent colour.|class:input-helper small muted"); var colorInputHelper = helper.node("p:Use this colour to override the global Accent colour.|class:form-helper small muted");
var letterRadioInputWrap = helper.node("div|class:input-wrap"); var letterRadioInputWrap = helper.node("div|class:input-wrap");
var letterRadioInput = helper.node("input|class:link-form-input-display-letter,id:link-form-input-display-letter,type:radio,name:link-form-input-display,tabindex:1,checked,value:letter"); var letterRadioInput = helper.node("input|class:link-form-input-display-letter,id:link-form-input-display-letter,type:radio,name:link-form-input-display,tabindex:1,checked,value:letter");
var letterRadioLable = helper.node("label:Letters|for:link-form-input-display-letter"); var letterRadioLable = helper.node("label:Letters|for:link-form-input-display-letter");
@ -644,8 +644,8 @@ var link = (function() {
colorFormGroup.appendChild(colorButtonRefresh); colorFormGroup.appendChild(colorButtonRefresh);
colorWrap.appendChild(colorLabel); colorWrap.appendChild(colorLabel);
colorWrap.appendChild(colorFormGroup); colorWrap.appendChild(colorFormGroup);
colorWrap.appendChild(colorPara);
fieldset.appendChild(colorWrap); fieldset.appendChild(colorWrap);
fieldset.appendChild(colorInputHelper);
form.appendChild(fieldset); form.appendChild(fieldset);
letterRadioInput.addEventListener("change", function(event) { letterRadioInput.addEventListener("change", function(event) {
@ -690,7 +690,7 @@ var link = (function() {
letterInput.removeAttribute("disabled"); letterInput.removeAttribute("disabled");
iconInput.setAttribute("disabled", ""); iconInput.setAttribute("disabled", "");
iconFormGroupText.setAttribute("disabled", ""); iconFormGroupText.setAttribute("disabled", "");
iconPara.setAttribute("disabled", ""); helper.addClass(form.querySelector(".link-form-input-icon-helper"), "disabled");
iconFormGroupClear.setAttribute("disabled", ""); iconFormGroupClear.setAttribute("disabled", "");
iconFormGroupText.tabIndex = -1; iconFormGroupText.tabIndex = -1;
}, false); }, false);
@ -698,7 +698,7 @@ var link = (function() {
letterInput.setAttribute("disabled", ""); letterInput.setAttribute("disabled", "");
iconInput.removeAttribute("disabled"); iconInput.removeAttribute("disabled");
iconFormGroupText.removeAttribute("disabled"); iconFormGroupText.removeAttribute("disabled");
iconPara.removeAttribute("disabled"); helper.removeClass(form.querySelector(".link-form-input-icon-helper"), "disabled");
iconFormGroupClear.removeAttribute("disabled"); iconFormGroupClear.removeAttribute("disabled");
iconFormGroupText.tabIndex = 1; iconFormGroupText.tabIndex = 1;
}, false); }, false);

2
src/js/version.js
View File

@ -1,6 +1,6 @@
var version = (function() { var version = (function() {
var current = "3.64.0"; var current = "3.65.0";
var compare = function(a, b) { var compare = function(a, b) {
var pa = a.split("."); var pa = a.split(".");

2
src/manifest.json
View File

@ -2,7 +2,7 @@
"name": "nightTab", "name": "nightTab",
"short_name": "nightTab", "short_name": "nightTab",
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.", "description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
"version": "3.64.0", "version": "3.65.0",
"manifest_version": 2, "manifest_version": 2,
"chrome_url_overrides": { "chrome_url_overrides": {
"newtab": "index.html" "newtab": "index.html"