2020-05-07 13:03:43 +02:00
|
|
|
use nu_test_support::{nu, pipeline};
|
2019-12-15 17:15:06 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn groups() {
|
2023-11-29 23:21:34 +01:00
|
|
|
let sample = r#"
|
|
|
|
[[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés, Robalino, "10/11/2013", A],
|
|
|
|
[JT, Turner, "10/12/2013", B],
|
|
|
|
[Yehuda, Katz, "10/11/2013", A]]
|
|
|
|
"#;
|
2019-12-15 17:15:06 +01:00
|
|
|
|
2023-11-29 23:21:34 +01:00
|
|
|
let actual = nu!(pipeline(&format!(
|
|
|
|
r#"
|
|
|
|
{sample}
|
2019-12-15 17:15:06 +01:00
|
|
|
| group-by rusty_at
|
|
|
|
| get "10/11/2013"
|
2021-03-13 22:46:40 +01:00
|
|
|
| length
|
2019-12-15 17:15:06 +01:00
|
|
|
"#
|
2023-11-29 23:21:34 +01:00
|
|
|
)));
|
2019-12-15 17:15:06 +01:00
|
|
|
|
2023-11-29 23:21:34 +01:00
|
|
|
assert_eq!(actual.out, "2");
|
2019-12-15 17:15:06 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2020-07-14 15:45:19 +02:00
|
|
|
fn errors_if_given_unknown_column_name() {
|
allow `group-by` and `split-by` to work with other values (#14086)
# Description
This PR updates `group-by` and `split-by` to allow other nushell Values
to be used, namely bools.
### Before
```nushell
❯ [false, false, true, false, true, false] | group-by | table -e
Error: nu::shell::cant_convert
× Can't convert to string.
╭─[entry #1:1:2]
1 │ [false, false, true, false, true, false] | group-by | table -e
· ──┬──
· ╰── can't convert bool to string
╰────
```
### After
```nushell
❯ [false, false, true, false, true, false] | group-by | table -e
╭───────┬───────────────╮
│ │ ╭───┬───────╮ │
│ false │ │ 0 │ false │ │
│ │ │ 1 │ false │ │
│ │ │ 2 │ false │ │
│ │ │ 3 │ false │ │
│ │ ╰───┴───────╯ │
│ │ ╭───┬──────╮ │
│ true │ │ 0 │ true │ │
│ │ │ 1 │ true │ │
│ │ ╰───┴──────╯ │
╰───────┴───────────────╯
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-17 23:14:01 +02:00
|
|
|
let sample = r#"{
|
|
|
|
"nu": {
|
|
|
|
"committers": [
|
|
|
|
{"name": "Andrés N. Robalino"},
|
|
|
|
{"name": "JT Turner"},
|
|
|
|
{"name": "Yehuda Katz"}
|
|
|
|
],
|
|
|
|
"releases": [
|
|
|
|
{"version": "0.2"}
|
|
|
|
{"version": "0.8"},
|
|
|
|
{"version": "0.9999999"}
|
|
|
|
],
|
|
|
|
"0xATYKARNU": [
|
|
|
|
["Th", "e", " "],
|
|
|
|
["BIG", " ", "UnO"],
|
|
|
|
["punto", "cero"]
|
|
|
|
]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#;
|
2020-07-14 15:45:19 +02:00
|
|
|
|
2023-11-29 23:21:34 +01:00
|
|
|
let actual = nu!(pipeline(&format!(
|
allow `group-by` and `split-by` to work with other values (#14086)
# Description
This PR updates `group-by` and `split-by` to allow other nushell Values
to be used, namely bools.
### Before
```nushell
❯ [false, false, true, false, true, false] | group-by | table -e
Error: nu::shell::cant_convert
× Can't convert to string.
╭─[entry #1:1:2]
1 │ [false, false, true, false, true, false] | group-by | table -e
· ──┬──
· ╰── can't convert bool to string
╰────
```
### After
```nushell
❯ [false, false, true, false, true, false] | group-by | table -e
╭───────┬───────────────╮
│ │ ╭───┬───────╮ │
│ false │ │ 0 │ false │ │
│ │ │ 1 │ false │ │
│ │ │ 2 │ false │ │
│ │ │ 3 │ false │ │
│ │ ╰───┴───────╯ │
│ │ ╭───┬──────╮ │
│ true │ │ 0 │ true │ │
│ │ │ 1 │ true │ │
│ │ ╰───┴──────╯ │
╰───────┴───────────────╯
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-17 23:14:01 +02:00
|
|
|
r#"'{sample}'
|
|
|
|
| from json
|
|
|
|
| group-by {{|| get nu.releases.missing_column }}"#
|
2023-11-29 23:21:34 +01:00
|
|
|
)));
|
allow `group-by` and `split-by` to work with other values (#14086)
# Description
This PR updates `group-by` and `split-by` to allow other nushell Values
to be used, namely bools.
### Before
```nushell
❯ [false, false, true, false, true, false] | group-by | table -e
Error: nu::shell::cant_convert
× Can't convert to string.
╭─[entry #1:1:2]
1 │ [false, false, true, false, true, false] | group-by | table -e
· ──┬──
· ╰── can't convert bool to string
╰────
```
### After
```nushell
❯ [false, false, true, false, true, false] | group-by | table -e
╭───────┬───────────────╮
│ │ ╭───┬───────╮ │
│ false │ │ 0 │ false │ │
│ │ │ 1 │ false │ │
│ │ │ 2 │ false │ │
│ │ │ 3 │ false │ │
│ │ ╰───┴───────╯ │
│ │ ╭───┬──────╮ │
│ true │ │ 0 │ true │ │
│ │ │ 1 │ true │ │
│ │ ╰───┴──────╯ │
╰───────┴───────────────╯
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-17 23:14:01 +02:00
|
|
|
assert!(actual.err.contains("cannot find column"));
|
2020-07-14 15:45:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2023-05-18 01:34:44 +02:00
|
|
|
fn errors_if_column_not_found() {
|
2023-11-29 23:21:34 +01:00
|
|
|
let sample = r#"
|
|
|
|
[[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés, Robalino, "10/11/2013", A],
|
|
|
|
[JT, Turner, "10/12/2013", B],
|
|
|
|
[Yehuda, Katz, "10/11/2013", A]]
|
|
|
|
"#;
|
2019-12-15 17:15:06 +01:00
|
|
|
|
2023-11-29 23:21:34 +01:00
|
|
|
let actual = nu!(pipeline(&format!("{sample} | group-by ttype")));
|
2019-12-15 17:15:06 +01:00
|
|
|
|
2023-11-29 23:21:34 +01:00
|
|
|
assert!(actual.err.contains("did you mean 'type'"),);
|
2019-12-15 17:15:06 +01:00
|
|
|
}
|
2022-02-09 15:47:47 +01:00
|
|
|
|
|
|
|
#[test]
|
2023-10-19 12:20:52 +02:00
|
|
|
fn group_by_on_empty_list_returns_empty_record() {
|
|
|
|
let actual = nu!("[[a b]; [1 2]] | where false | group-by a");
|
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
assert!(actual.out.contains("empty record"));
|
2023-05-18 01:34:44 +02:00
|
|
|
}
|
2022-02-09 15:47:47 +01:00
|
|
|
|
2023-05-18 01:34:44 +02:00
|
|
|
#[test]
|
|
|
|
fn optional_cell_path_works() {
|
|
|
|
let actual = nu!("[{foo: 123}, {foo: 234}, {bar: 345}] | group-by foo? | to nuon");
|
|
|
|
let expected = r#"{"123": [[foo]; [123]], "234": [[foo]; [234]]}"#;
|
|
|
|
assert_eq!(actual.out, expected)
|
2022-02-09 15:47:47 +01:00
|
|
|
}
|