mirror of
https://github.com/nushell/nushell.git
synced 2024-12-23 07:30:13 +01:00
reduce: supply <acc> to the closure as pipeline input as well (#13461)
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> resolve #13459 # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Make `reduce` supply the accumulator value to closure as pipeline input. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> Mostly described in #13459 - Should not be a breaking change. - Allows cleaner patterns like `... | reduce {|it| merge $it}` # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> `cargo test --package nu-cli --test main -- commands::reduce` and `toolkit test stdlib` report no issues
This commit is contained in:
parent
12f57dbc62
commit
0576794e74
@ -120,8 +120,7 @@ impl Command for Reduce {
|
||||
engine_state.signals().check(head)?;
|
||||
acc = closure
|
||||
.add_arg(value)
|
||||
.add_arg(acc)
|
||||
.run_with_input(PipelineData::Empty)?
|
||||
.run_with_value(acc)?
|
||||
.into_value(head)?;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user