extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-04-03 06:01:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't error on failed external expansion (#4480)

Browse Source
This commit is contained in:
JT 2022-02-15 08:47:25 -05:00 committed by GitHub
parent 9114a2d31d
commit 5c1a1be02b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crates/nu-command/src/system/run_external.rs
View File

@ -358,14 +358,10 @@ impl ExternalCommand {
if let Ok((prefix, matches)) = nu_engine::glob_from(&arg, &cwd, self.name.span) { if let Ok((prefix, matches)) = nu_engine::glob_from(&arg, &cwd, self.name.span) {
let matches: Vec<_> = matches.collect(); let matches: Vec<_> = matches.collect();
// Following shells like bash, if we can't expand a glob pattern, we don't assume an empty arg // FIXME: do we want to special-case this further? We might accidentally expand when they don't
// Instead, we throw an error. This helps prevent issues with things like `ls unknowndir/*` accidentally // intend to
// listening the current directory.
if matches.is_empty() { if matches.is_empty() {
return Err(ShellError::FileNotFoundCustom( process.arg(&arg.item);
"pattern not found".to_string(),
arg.span,
));
} }
for m in matches { for m in matches {
if let Ok(arg) = m { if let Ok(arg) = m {