extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-19 17:38:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use Default for making Suggestions in attribute_completions (#15764)

Browse Source 
# Description

In preparation for https://github.com/nushell/reedline/pull/798, which
adds a new field to `Suggestion`, this PR makes sure that `Suggestion`s
are created using `..Default::default()` inside
`attribute_completions.rs`.

# User-Facing Changes

None

# Tests + Formatting

None

# After Submitting
This commit is contained in:
Yash Thakur 2025-05-16 02:21:40 -04:00 committed by GitHub
parent bb37306d07
commit 7b88bda9a1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/nu-cli/src/completions/attribute_completions.rs
View File

@ -33,13 +33,12 @@ impl Completer for AttributeCompletion {
suggestion: Suggestion { suggestion: Suggestion {
value: String::from_utf8_lossy(name).into_owned(), value: String::from_utf8_lossy(name).into_owned(),
description: desc, description: desc,
style: None,
extra: None,
span: reedline::Span { span: reedline::Span {
start: span.start - offset, start: span.start - offset,
end: span.end - offset, end: span.end - offset,
}, },
append_whitespace: false, append_whitespace: false,
..Default::default()
}, },
kind: Some(SuggestionKind::Command(ty, Some(decl_id))), kind: Some(SuggestionKind::Command(ty, Some(decl_id))),
}); });
@ -70,13 +69,12 @@ impl Completer for AttributableCompletion {
suggestion: Suggestion { suggestion: Suggestion {
value: cmd.name().into(), value: cmd.name().into(),
description: Some(cmd.description().into()), description: Some(cmd.description().into()),
style: None,
extra: None,
span: reedline::Span { span: reedline::Span {
start: span.start - offset, start: span.start - offset,
end: span.end - offset, end: span.end - offset,
}, },
append_whitespace: false, append_whitespace: false,
..Default::default()
}, },
kind: Some(SuggestionKind::Command(cmd.command_type(), None)), kind: Some(SuggestionKind::Command(cmd.command_type(), None)),
}); });