mirror of
https://github.com/nushell/nushell.git
synced 2025-01-03 13:00:08 +01:00
fix 64-bit hex number parsing (#14571)
# Description Closes #14521 This PR tweaks the way 64-bit hex numbers are parsed. ### Before ```nushell ❯ 0xffffffffffffffef Error: nu:🐚:external_command × External command failed ╭─[entry #1:1:1] 1 │ 0xffffffffffffffef · ─────────┬──────── · ╰── Command `0xffffffffffffffef` not found ╰──── help: `0xffffffffffffffef` is neither a Nushell built-in or a known external command ``` ### After ```nushell ❯ 0xffffffffffffffef -17 ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
parent
49f377688a
commit
a7fa6d00c1
@ -1532,7 +1532,9 @@ pub fn parse_int(working_set: &mut StateWorkingSet, span: Span) -> Expression {
|
||||
span: Span,
|
||||
radix: u32,
|
||||
) -> Expression {
|
||||
if let Ok(num) = i64::from_str_radix(token, radix) {
|
||||
// Parse as a u64, then cast to i64, otherwise, for numbers like "0xffffffffffffffef",
|
||||
// you'll get `Error parsing hex string: number too large to fit in target type`.
|
||||
if let Ok(num) = u64::from_str_radix(token, radix).map(|val| val as i64) {
|
||||
Expression::new(working_set, Expr::Int(num), span, Type::Int)
|
||||
} else {
|
||||
working_set.error(ParseError::InvalidLiteral(
|
||||
|
Loading…
Reference in New Issue
Block a user