extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-05-17 00:10:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

Polars: Minor code cleanup (#15144)

Browse Source 
# Description
Removing todos and deadcode from a previous refactor
This commit is contained in:
Jack Wright 2025-02-19 09:47:21 -08:00 committed by GitHub
parent 8b46ba8b6b
commit c504c93a1d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/nu_plugin_polars/src/cache/mod.rs vendored
View File

@ -197,11 +197,11 @@ mod test {
impl EngineWrapper for &MockEngineWrapper { impl EngineWrapper for &MockEngineWrapper {
fn get_env_var(&self, _key: &str) -> Option<String> { fn get_env_var(&self, _key: &str) -> Option<String> {
todo!() unimplemented!()
} }
fn use_color(&self) -> bool { fn use_color(&self) -> bool {
todo!() unimplemented!()
} }
fn set_gc_disabled(&self, disabled: bool) -> Result<(), ShellError> { fn set_gc_disabled(&self, disabled: bool) -> Result<(), ShellError> {

6
crates/nu_plugin_polars/src/dataframe/values/utils.rs
View File

@ -6,8 +6,6 @@ pub const DEFAULT_ROWS: usize = 5;
// Converts a Vec<Value> to a Vec<Spanned<String>> with a Span marking the whole // Converts a Vec<Value> to a Vec<Spanned<String>> with a Span marking the whole
// location of the columns for error referencing // location of the columns for error referencing
// todo - fix
#[allow(dead_code)]
pub(crate) fn convert_columns( pub(crate) fn convert_columns(
columns: Vec<Value>, columns: Vec<Value>,
span: Span, span: Span,
@ -49,8 +47,6 @@ pub(crate) fn convert_columns(
// Converts a Vec<Value> to a Vec<String> with a Span marking the whole // Converts a Vec<Value> to a Vec<String> with a Span marking the whole
// location of the columns for error referencing // location of the columns for error referencing
// todo - fix
#[allow(dead_code)]
pub(crate) fn convert_columns_string( pub(crate) fn convert_columns_string(
columns: Vec<Value>, columns: Vec<Value>,
span: Span, span: Span,
@ -92,8 +88,6 @@ pub(crate) fn convert_columns_string(
// Converts a Vec<Value> to a Vec<String> with a Span marking the whole // Converts a Vec<Value> to a Vec<String> with a Span marking the whole
// location of the columns for error referencing // location of the columns for error referencing
// todo - fix
#[allow(dead_code)]
pub(crate) fn convert_columns_sm_str( pub(crate) fn convert_columns_sm_str(
columns: Vec<Value>, columns: Vec<Value>,
span: Span, span: Span,