mirror of
https://github.com/nushell/nushell.git
synced 2024-11-21 16:03:19 +01:00
Improve comment wording in run_external.rs (#14230)
verb 'setup' -> 'set up' setup as verb [is a misspelling of set up](https://en.wiktionary.org/wiki/setup#Verb) * [verb: set up](https://en.wiktionary.org/wiki/set_up) * [noun: setup](https://en.wiktionary.org/wiki/setup) *I split this from #14229 typo corrections because 'setup' is not as clear-cut wrong. Having read the dictionary pages (linked) I'm even more confident in this change being correct rather than only subjectively better.* Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
This commit is contained in:
parent
3e39fae6e1
commit
ccab3d6b6e
@ -114,7 +114,7 @@ impl Command for External {
|
||||
command.args(args.into_iter().map(|s| s.item));
|
||||
|
||||
// Configure stdout and stderr. If both are set to `OutDest::Pipe`,
|
||||
// we'll setup a pipe that merges two streams into one.
|
||||
// we'll set up a pipe that merges two streams into one.
|
||||
let stdout = stack.stdout();
|
||||
let stderr = stack.stderr();
|
||||
let merged_stream = if matches!(stdout, OutDest::Pipe) && matches!(stderr, OutDest::Pipe) {
|
||||
@ -129,7 +129,7 @@ impl Command for External {
|
||||
};
|
||||
|
||||
// Configure stdin. We'll try connecting input to the child process
|
||||
// directly. If that's not possible, we'll setup a pipe and spawn a
|
||||
// directly. If that's not possible, we'll set up a pipe and spawn a
|
||||
// thread to copy data into the child process.
|
||||
let data_to_copy_into_stdin = match input {
|
||||
PipelineData::ByteStream(stream, metadata) => match stream.into_stdio() {
|
||||
|
Loading…
Reference in New Issue
Block a user