extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-22 00:13:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve comment wording in run_external.rs (#14230)

Browse Source 
verb 'setup' -> 'set up'

setup as verb [is a misspelling of set
up](https://en.wiktionary.org/wiki/setup#Verb)

* [verb: set up](https://en.wiktionary.org/wiki/set_up)
* [noun: setup](https://en.wiktionary.org/wiki/setup)

*I split this from #14229 typo corrections because 'setup' is not as
clear-cut wrong. Having read the dictionary pages (linked) I'm even more
confident in this change being correct rather than only subjectively
better.*

Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
This commit is contained in:
Jan Klass 2024-11-01 18:02:25 +01:00 committed by GitHub
parent 3e39fae6e1
commit ccab3d6b6e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/nu-command/src/system/run_external.rs
View File

@ -114,7 +114,7 @@ impl Command for External {
command.args(args.into_iter().map(|s| s.item)); command.args(args.into_iter().map(|s| s.item));
// Configure stdout and stderr. If both are set to `OutDest::Pipe`, // Configure stdout and stderr. If both are set to `OutDest::Pipe`,
// we'll setup a pipe that merges two streams into one. // we'll set up a pipe that merges two streams into one.
let stdout = stack.stdout(); let stdout = stack.stdout();
let stderr = stack.stderr(); let stderr = stack.stderr();
let merged_stream = if matches!(stdout, OutDest::Pipe) && matches!(stderr, OutDest::Pipe) { let merged_stream = if matches!(stdout, OutDest::Pipe) && matches!(stderr, OutDest::Pipe) {
@ -129,7 +129,7 @@ impl Command for External {
}; };
// Configure stdin. We'll try connecting input to the child process // Configure stdin. We'll try connecting input to the child process
// directly. If that's not possible, we'll setup a pipe and spawn a // directly. If that's not possible, we'll set up a pipe and spawn a
// thread to copy data into the child process. // thread to copy data into the child process.
let data_to_copy_into_stdin = match input { let data_to_copy_into_stdin = match input {
PipelineData::ByteStream(stream, metadata) => match stream.into_stdio() { PipelineData::ByteStream(stream, metadata) => match stream.into_stdio() {