Prevent mv panic again (#6171)

Closes #6170

Signed-off-by: nibon7 <nibon7@163.com>
This commit is contained in:
nibon7 2022-07-29 15:00:52 +08:00 committed by GitHub
parent 6b2c7a4c86
commit cf2e9cf481
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -119,7 +119,7 @@ impl Command for Mv {
return Err(ShellError::GenericError(
format!(
"Not possible to move {:?} to itself",
filename.file_name().expect("Invalid file name")
filename.file_name().unwrap_or(filename.as_os_str())
),
"cannot move to itself".into(),
Some(spanned_destination.span),
@ -155,18 +155,17 @@ impl Command for Mv {
if let Err(error) = result {
Some(Value::Error { error })
} else if verbose {
let val = if result.expect("Error value when unwrapping mv result") {
format!(
let val = match result {
Ok(true) => format!(
"moved {:} to {:}",
entry.to_string_lossy(),
destination.to_string_lossy()
)
} else {
format!(
),
_ => format!(
"{:} not moved to {:}",
entry.to_string_lossy(),
destination.to_string_lossy()
)
),
};
Some(Value::String { val, span })
} else {