port the mv command

crates/nu-command/src/default_context.rs

@@ -35,6 +35,7 @@ pub fn create_default_context() -> Rc<RefCell<EngineState>> {
         working_set.add_decl(Box::new(Lines));
         working_set.add_decl(Box::new(Ls));
         working_set.add_decl(Box::new(Module));
+        working_set.add_decl(Box::new(Mv));
         working_set.add_decl(Box::new(Ps));
         working_set.add_decl(Box::new(Select));
         working_set.add_decl(Box::new(Sys));

crates/nu-command/src/filesystem/mod.rs

@@ -1,5 +1,7 @@
 mod cd;
 mod ls;
+mod mv;
 
 pub use cd::Cd;
 pub use ls::Ls;
+pub use mv::Mv;

crates/nu-command/src/filesystem/mv.rs

@@ -0,0 +1,151 @@
+use std::env::current_dir;
+use std::path::{Path, PathBuf};
+
+use nu_engine::CallExt;
+use nu_protocol::ast::Call;
+use nu_protocol::engine::{Command, EvaluationContext};
+use nu_protocol::{ShellError, Signature, SyntaxShape, Value};
+
+pub struct Mv;
+
+impl Command for Mv {
+    fn name(&self) -> &str {
+        "mv"
+    }
+
+    fn usage(&self) -> &str {
+        "Move files or directories."
+    }
+
+    fn signature(&self) -> nu_protocol::Signature {
+        Signature::build("mv")
+            .optional(
+                "source",
+                SyntaxShape::GlobPattern,
+                "the location to move files/directories from",
+            )
+            .optional(
+                "destination",
+                SyntaxShape::FilePath,
+                "the location to move files/directories to",
+            )
+        // .required(
+        //     "source",
+        //     SyntaxShape::GlobPattern,
+        //     "the location to move files/directories from",
+        // )
+        // .required(
+        //     "destination",
+        //     SyntaxShape::FilePath,
+        //     "the location to move files/directories to",
+        // )
+    }
+
+    fn run(
+        &self,
+        context: &EvaluationContext,
+        call: &Call,
+        _input: Value,
+    ) -> Result<nu_protocol::Value, nu_protocol::ShellError> {
+        // TODO: handle invalid directory or insufficient permissions
+        let source: String = call.req(context, 0)?;
+        let destination: String = call.req(context, 1)?;
+
+        let path: PathBuf = current_dir().unwrap();
+        let source = path.join(source.as_str());
+        let destination = path.join(destination.as_str());
+
+        let mut sources =
+            glob::glob(&source.to_string_lossy()).map_or_else(|_| Vec::new(), Iterator::collect);
+
+        if sources.is_empty() {
+            return Err(ShellError::InternalError(format!(
+                "source \"{:?}\" does not exist",
+                source
+            )));
+        }
+
+        if (destination.exists() && !destination.is_dir() && sources.len() > 1)
+            || (!destination.exists() && sources.len() > 1)
+        {
+            return Err(ShellError::InternalError(
+                "can only move multiple sources if destination is a directory".to_string(),
+            ));
+        }
+
+        let some_if_source_is_destination = sources
+            .iter()
+            .find(|f| matches!(f, Ok(f) if destination.starts_with(f)));
+        if destination.exists() && destination.is_dir() && sources.len() == 1 {
+            if let Some(Ok(filename)) = some_if_source_is_destination {
+                return Err(ShellError::InternalError(format!(
+                    "Not possible to move {:?} to itself",
+                    filename.file_name().expect("Invalid file name")
+                )));
+            }
+        }
+
+        if let Some(Ok(_filename)) = some_if_source_is_destination {
+            sources = sources
+                .into_iter()
+                .filter(|f| matches!(f, Ok(f) if !destination.starts_with(f)))
+                .collect();
+        }
+
+        for entry in sources.into_iter().flatten() {
+            move_file(&entry, &destination)?
+        }
+
+        Ok(Value::Nothing { span: call.head })
+    }
+}
+
+fn move_file(from: &PathBuf, to: &PathBuf) -> Result<(), ShellError> {
+    if to.exists() && from.is_dir() && to.is_file() {
+        return Err(ShellError::InternalError(format!(
+            "Cannot rename {:?} to a file",
+            from.file_name().expect("Invalid directory name")
+        )));
+    }
+
+    let destination_dir_exists = if to.is_dir() {
+        true
+    } else {
+        to.parent().map(Path::exists).unwrap_or(true)
+    };
+
+    if !destination_dir_exists {
+        return Err(ShellError::InternalError(format!(
+            "{:?} does not exist",
+            to.file_name().expect("Invalid directory name")
+        )));
+    }
+
+    let mut to = to.clone();
+    if to.is_dir() {
+        let from_file_name = match from.file_name() {
+            Some(name) => name,
+            None => {
+                return Err(ShellError::InternalError(format!(
+                    "{:?} is not a valid entry",
+                    from.file_name().expect("Invalid directory name")
+                )))
+            }
+        };
+
+        to.push(from_file_name);
+    }
+
+    move_item(&from, &to)
+}
+
+fn move_item(from: &Path, to: &Path) -> Result<(), ShellError> {
+    // We first try a rename, which is a quick operation. If that doesn't work, we'll try a copy
+    // and remove the old file/folder. This is necessary if we're moving across filesystems or devices.
+    std::fs::rename(&from, &to).or_else(|_| {
+        Err(ShellError::InternalError(format!(
+            "Could not move {:?} to {:?}",
+            from, to,
+        )))
+    })
+}