mirror of
https://github.com/nushell/nushell.git
synced 2025-07-01 07:00:37 +02:00
improve operation mismatch errors (#8800)
# Description This improves the operation mismatch error in a few ways: * We now detect if the left-hand side of the operation is at fault, and show a simpler error/error message if it is * Removed the unhelpful hint * Updated the error text to make it clear what types are causing the issue   # User-Facing Changes Error texts and spans will change # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-utils/standard_library/tests.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -17,7 +17,7 @@ fn int_in_exclusive_range() -> TestResult {
|
||||
|
||||
#[test]
|
||||
fn non_number_in_range() -> TestResult {
|
||||
fail_test(r#"'a' in 1..3"#, "mismatched for operation")
|
||||
fail_test(r#"'a' in 1..3"#, "subset comparison is not supported")
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
@ -73,10 +73,10 @@ fn invalid_not_regex_fails() -> TestResult {
|
||||
|
||||
#[test]
|
||||
fn regex_on_int_fails() -> TestResult {
|
||||
fail_test(r#"33 =~ foo"#, "Types mismatched")
|
||||
fail_test(r#"33 =~ foo"#, "is not supported")
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn not_regex_on_int_fails() -> TestResult {
|
||||
fail_test(r#"33 !~ foo"#, "Types mismatched")
|
||||
fail_test(r#"33 !~ foo"#, "is not supported")
|
||||
}
|
||||
|
@ -20,7 +20,7 @@ fn string_in_string() -> TestResult {
|
||||
|
||||
#[test]
|
||||
fn non_string_in_string() -> TestResult {
|
||||
fail_test(r#"42 in 'abc'"#, "mismatched for operation")
|
||||
fail_test(r#"42 in 'abc'"#, "is not supported")
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
@ -12,7 +12,7 @@ fn type_in_list_of_this_type() -> TestResult {
|
||||
|
||||
#[test]
|
||||
fn type_in_list_of_non_this_type() -> TestResult {
|
||||
fail_test(r#"'hello' in [41 42 43]"#, "mismatched for operation")
|
||||
fail_test(r#"'hello' in [41 42 43]"#, "is not supported")
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
Reference in New Issue
Block a user