nushell/crates/nu-command/src/math
Ian Manske 9996e4a1f8
Shrink the size of Expr (#12610)
# Description
Continuing from #12568, this PR further reduces the size of `Expr` from
64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and
`Type` from 32 to 24 bytes.

This was accomplished by:
- for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`),
merging the fields into new AST struct types and then boxing this struct
(e.g. `Expr::Thing(Box<ABC>)`).
- replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and
`Expression`s should rarely be mutated, if at all, so this optimization
makes sense.

By reducing the size of these types, I didn't notice a large performance
improvement (at least compared to #12568). But this PR does reduce the
memory usage of nushell. My config is somewhat light so I only noticed a
difference of 1.4MiB (38.9MiB vs 37.5MiB).

---------

Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
2024-04-24 15:46:35 +00:00
..
abs.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
avg.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
ceil.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
floor.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
log.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
math_.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
max.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
median.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
min.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
mod.rs cratification: part III of the math commands to nu-cmd-extra (#9674) 2023-07-13 09:11:26 -07:00
mode.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
product.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
reducers.rs Apply nightly clippy fixes (#11083) 2023-11-17 09:15:55 -06:00
round.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
sqrt.rs Add command_prelude module (#12291) 2024-03-26 21:17:30 +00:00
stddev.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
sum.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00
utils.rs Copy-on-write for record values (#12305) 2024-04-14 01:42:03 +00:00
variance.rs Shrink the size of Expr (#12610) 2024-04-24 15:46:35 +00:00