mirror of
https://github.com/nushell/nushell.git
synced 2024-12-26 17:09:06 +01:00
e4c2c123ab
# Description This PR addresses #11525 by adding `--partial-escape` which makes `to xml` only escape `<>&` in text and `<>&"` in comments. This PR also fixes issue where comment and PI content was escaped even though [it should not be](https://stackoverflow.com/a/46637835) # User-Facing Changes Correct comments and PIs `to xml --partial-escape` flag to emit less escaped characters # Tests + Formatting Added tests for specified issues
94 lines
2.1 KiB
Rust
94 lines
2.1 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn table_to_xml_text_and_from_xml_text_back_into_table() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open jt.xml
|
|
| to xml
|
|
| from xml
|
|
| get content
|
|
| where tag == channel
|
|
| get content
|
|
| flatten
|
|
| where tag == item
|
|
| get content
|
|
| flatten
|
|
| where tag == guid
|
|
| get 0.attributes.isPermaLink
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn to_xml_error_unknown_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{tag: a bad_column: b} | to xml
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("Invalid column \"bad_column\""));
|
|
}
|
|
|
|
#[test]
|
|
fn to_xml_error_no_tag() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{attributes: {a: b c: d}} | to xml
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("Tag missing"));
|
|
}
|
|
|
|
#[test]
|
|
fn to_xml_error_tag_not_string() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{tag: 1 attributes: {a: b c: d}} | to xml
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("not a string"));
|
|
}
|
|
|
|
#[test]
|
|
fn to_xml_partial_escape() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{
|
|
tag: a
|
|
attributes: { a: "'a'\\" }
|
|
content: [ `'"qwe\` ]
|
|
} | to xml --partial-escape
|
|
"#
|
|
));
|
|
assert_eq!(actual.out, r#"<a a="'a'\">'"qwe\</a>"#);
|
|
}
|
|
|
|
#[test]
|
|
fn to_xml_pi_comment_not_escaped() {
|
|
// PI and comment content should not be escaped
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{
|
|
tag: a
|
|
content: [
|
|
{tag: ?qwe content: `"'<>&`}
|
|
{tag: ! content: `"'<>&`}
|
|
]
|
|
} | to xml
|
|
"#
|
|
));
|
|
assert_eq!(actual.out, r#"<a><?qwe "'<>&?><!--"'<>&--></a>"#);
|
|
}
|