mirror of
https://github.com/nushell/nushell.git
synced 2024-12-23 07:30:13 +01:00
77e73cef66
# Description Fixes #6706. I took a look at this issue and it seems that the issue is because the path is canonicalized and thus derives to the target. I've tested it locally by checking if the path is a symlink and acting accordingly to not canonicalize it and it seems fine. In current release if the target is deleted but the symlink remains and one `ls`'s it, it throws a `directory not found` error. But with the fix it still shows the symlink (with red background, indicating missing target). The change I've applied only triggers when `ls` is done on a symlink, on all other counts it should basically do the same as before. # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass ## List existing symlink and target Current ``` ls a_symlink ╭───┬────────┬──────┬──────┬──────────────╮ │ # │ name │ type │ size │ modified │ ├───┼────────┼──────┼──────┼──────────────┤ │ 0 │ a_file │ file │ 0 B │ 20 hours ago │ ╰───┴────────┴──────┴──────┴──────────────╯ ``` With fix ``` ls a_symlink ╭───┬───────────┬─────────┬──────┬──────────────╮ │ # │ name │ type │ size │ modified │ ├───┼───────────┼─────────┼──────┼──────────────┤ │ 0 │ a_symlink │ symlink │ 6 B │ 20 hours ago │ ╰───┴───────────┴─────────┴──────┴──────────────╯ ``` ## List existing symlink with missing target Current ``` ls symfile_x Error: nu:🐚:directory_not_found (link) × Directory not found ╭─[entry #13:1:1] 1 │ ls symfile_x · ────┬──── · ╰── directory not found ╰──── ``` With fix ``` ls symfile_x ╭───┬───────────┬─────────┬──────┬─────────────╮ │ # │ name │ type │ size │ modified │ ├───┼───────────┼─────────┼──────┼─────────────┤ │ 0 │ symfile_x │ symlink │ 6 B │ 2 hours ago │ ╰───┴───────────┴─────────┴──────┴─────────────╯ ``` |
||
|---|---|---|
| .. | ||
| nu_plugin_custom_values | ||
| nu_plugin_example | ||
| nu_plugin_formats | ||
| nu_plugin_gstat | ||
| nu_plugin_inc | ||
| nu_plugin_python | ||
| nu_plugin_query | ||
| nu-cli | ||
| nu-cmd-lang | ||
| nu-color-config | ||
| nu-command | ||
| nu-engine | ||
| nu-explore | ||
| nu-glob | ||
| nu-json | ||
| nu-parser | ||
| nu-path | ||
| nu-plugin | ||
| nu-pretty-hex | ||
| nu-protocol | ||
| nu-system | ||
| nu-table | ||
| nu-term-grid | ||
| nu-test-support | ||
| nu-utils | ||
| README.md | ||
Nushell core libraries and plugins
These sub-crates form both the foundation for Nu and a set of plugins which extend Nu with additional functionality.
Foundational libraries are split into two kinds of crates:
- Core crates - those crates that work together to build the Nushell language engine
- Support crates - a set of crates that support the engine with additional features like JSON support, ANSI support, and more.
Plugins are likewise also split into two types:
- Core plugins - plugins that provide part of the default experience of Nu, including access to the system properties, processes, and web-connectivity features.
- Extra plugins - these plugins run a wide range of different capabilities like working with different file types, charting, viewing binary data, and more.