mirror of
https://github.com/nushell/nushell.git
synced 2025-04-30 08:04:25 +02:00
# Description
The parsing logic for several of our keywords is conditional on the
particular commands for those keywords being in scope:
942030199d/crates/nu-parser/src/parse_keywords.rs (L272-L279)
Thus the following involved parsing logic was not fuzzed by the existing
`parse` fuzz target so far.
This adds an additional fuzz target `parse_with_keywords` that loads the
commands from `nu-cmd-lang`. Those are primarily the keyword
implementations, thus the relevant code paths in the parser that depend
on those `DeclId`s and the potential const eval of `if` etc. get
unlocked.
The existing `parse` target is preserved if you have concerns about the
fuzzing breaking containment in some form due to those commands.
# Tests + Formatting
Found https://github.com/nushell/nushell/issues/14972 with this target
1.1 KiB
1.1 KiB
Fuzzer for nu-parser
- For detailed info, please look at cargo-fuzz
Quick start guide
- Install cargo-fuzz by
cargo install cargo-fuzz
- Run
gather_seeds.nu
for preparing the initial seeds corpus. This pulls.nu
files in the nushell repository as checked out and uses them as a starting of point. You can add additional files to increase diversity. - Make an output directory
mkdir out
- Run the fuzzer with
cargo fuzz run parse out seeds
whereparse
is the name of the target
Targets
parse
just pulls innu-parser
and reaches the lexing and parsing logic. No command gets executed.parse_with_keywords
also loadsnu-cmd-lang
providing the command implementations for the core keywords. This permits the fuzzer to reach more code paths as some parts depend on the availability of those declarations. This may also execute the const eval code paths of the keyword commands. As of now this command set should not have negative side effects upon const eval. The overall code is not executed by this target.