extern/podman-compose
1
0
Fork 1
mirror of https://github.com/containers/podman-compose.git synced 2025-05-30 06:59:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

podman compose down refactor for remove orphans and rmi options

Browse Source 
Signed-off-by: Yashodhan Pise <technoy@gmail.com>
This commit is contained in:
Yashodhan Pise 2025-05-01 23:42:38 +05:30
parent 8bb43100b1
commit 6a7865af3b
1 changed files with 80 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

113
podman_compose.py
View File

@ -2928,12 +2928,42 @@ def get_volume_names(compose, cnt):
@cmd_run(podman_compose, "down", "tear down entire stack") @cmd_run(podman_compose, "down", "tear down entire stack")
async def compose_down(compose: PodmanCompose, args): async def compose_down(compose: PodmanCompose, args):
# get_excluded fails as no-deps is not a supported cli arg
excluded = get_excluded(compose, args) excluded = get_excluded(compose, args)
podman_args = [] podman_args = []
timeout_global = getattr(args, "timeout", None) timeout_global = getattr(args, "timeout", None)
containers = list(reversed(compose.containers)) containers = list(reversed(compose.containers))
down_tasks = [] # Get list of currently running containers
running_cnt_names = (
(
await compose.podman.output(
[],
"ps",
[
"--filter",
f"label=io.podman.compose.project={compose.project_name}",
"-a",
"--format",
"{{ .Names }}",
],
)
)
.decode("utf-8")
.splitlines()
)
running_cnt_imgs = [
(await compose.podman.output([], "inspect", ["--format", "{{.ImageName}}", cnt]))
.decode("utf-8")
.strip() # Decode and strip newline characters
for cnt in running_cnt_names
]
# Multiple containers can have the same image. Hence, set().
running_cnt_imgs = set(running_cnt_imgs)
# print(f"running_cnt_imgs: {running_cnt_imgs}")
stop_tasks = []
for cnt in containers: for cnt in containers:
if cnt["_service"] in excluded: if cnt["_service"] in excluded:
continue continue
@ -2944,42 +2974,59 @@ async def compose_down(compose: PodmanCompose, args):
timeout = str_to_seconds(timeout_str) timeout = str_to_seconds(timeout_str)
if timeout is not None: if timeout is not None:
podman_stop_args.extend(["-t", str(timeout)]) podman_stop_args.extend(["-t", str(timeout)])
down_tasks.append( stop_tasks.append(compose.podman.run([], "stop", [*podman_stop_args, cnt["name"]]))
asyncio.create_task(
compose.podman.run([], "stop", [*podman_stop_args, cnt["name"]]), name=cnt["name"] await asyncio.gather(*stop_tasks)
) stop_tasks.clear()
)
await asyncio.gather(*down_tasks) rm_tasks = []
for cnt in containers: for cnt in containers:
if cnt["_service"] in excluded: if cnt["_service"] in excluded:
continue continue
await compose.podman.run([], "rm", [cnt["name"]]) rm_tasks.append(compose.podman.run([], "rm", [cnt["name"]]))
if cnt["name"] in running_cnt_names:
running_cnt_names.remove(cnt["name"])
await asyncio.gather(*rm_tasks)
rm_tasks.clear()
orphaned_images = set() # The logic is updated based on docker compose documentation:
# `--remove-orphans`: Remove containers for services not defined in the Compose file
# Ref: https://docs.docker.com/reference/cli/docker/compose/down/#options
orphan_cnt_names = []
for cnt in running_cnt_names:
if not any(f"{compose.project_name}_{service}_" in cnt for service in compose.all_services):
orphan_cnt_names.append(cnt)
running_cnt_names.remove(cnt)
# We list the containers and remove them from running container list
# However, we stop them only if provided with CLI arg `--remove-orphans`
if args.remove_orphans: if args.remove_orphans:
orphaned_containers = ( for name in orphan_cnt_names:
( stop_tasks.append(compose.podman.run([], "stop", [*podman_args, name]))
await compose.podman.output( await asyncio.gather(*stop_tasks)
[], stop_tasks.clear()
"ps",
[ for name in orphan_cnt_names:
"--filter", rm_tasks.append(compose.podman.run([], "rm", [name]))
f"label=io.podman.compose.project={compose.project_name}", await asyncio.gather(*rm_tasks)
"-a", rm_tasks.clear()
"--format",
"{{ .Image }} {{ .Names }}", for cnt in running_cnt_names:
], # This logic goes away if the containers list can be updated accordingly at source.
) # Clear containers not formed out of the current compose file definitions.
) # E.g.: By using CLI `up --scale <APP>=<NUM>` option
.decode("utf-8") podman_stop_args = [*podman_args]
.splitlines() if timeout_global is not None:
) podman_stop_args.extend(["-t", str(timeout_global)])
orphaned_images = {item.split()[0] for item in orphaned_containers} stop_tasks.append(compose.podman.run([], "stop", [*podman_stop_args, cnt]))
names = {item.split()[1] for item in orphaned_containers} await asyncio.gather(*stop_tasks)
for name in names: stop_tasks.clear()
await compose.podman.run([], "stop", [*podman_args, name])
for name in names: for cnt in running_cnt_names:
await compose.podman.run([], "rm", [name]) rm_tasks.append(compose.podman.run([], "rm", [cnt]))
await asyncio.gather(*rm_tasks)
rm_tasks.clear()
if args.volumes: if args.volumes:
vol_names_to_keep = set() vol_names_to_keep = set()
for cnt in containers: for cnt in containers:
@ -2999,7 +3046,7 @@ async def compose_down(compose: PodmanCompose, args):
if args.rmi == "local" and not is_local(cnt): if args.rmi == "local" and not is_local(cnt):
continue continue
images_to_remove.add(cnt["image"]) images_to_remove.add(cnt["image"])
images_to_remove.update(orphaned_images) images_to_remove.update(running_cnt_imgs)
log.debug("images to remove: %s", images_to_remove) log.debug("images to remove: %s", images_to_remove)
await compose.podman.run([], "rmi", ["--ignore", "--force"] + list(images_to_remove)) await compose.podman.run([], "rmi", ["--ignore", "--force"] + list(images_to_remove))