extern/podman-compose
1
0
Fork 1
mirror of https://github.com/containers/podman-compose.git synced 2025-05-09 08:44:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1182 from zeyugao/pids_limit

Browse Source 
Implement pids_limit
This commit is contained in:
Povilas Kanapickas 2025-04-21 23:50:31 +03:00 committed by GitHub
commit 8bb43100b1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 81 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
newsfragments/1182-implement-pids-limit.feature Normal file
View File

@ -0,0 +1 @@
- Add support for `pids_limit` and `deploy.resources.limits.pids`

16
podman_compose.py
View File

@ -771,6 +771,22 @@ def container_to_cpu_res_args(cnt, podman_args):
str(mem_res).lower(),
))
# Handle pids limit from both container level and deploy section
pids_limit = cnt.get("pids_limit")
deploy_pids = limits.get("pids")
# Ensure consistency between pids_limit and deploy.resources.limits.pids
if pids_limit is not None and deploy_pids is not None:
if str(pids_limit) != str(deploy_pids):
raise ValueError(
f"Inconsistent PIDs limit: pids_limit ({pids_limit}) and "
f"deploy.resources.limits.pids ({deploy_pids}) must be the same"
)
final_pids_limit = pids_limit if pids_limit is not None else deploy_pids
if final_pids_limit is not None:
podman_args.extend(["--pids-limit", str(final_pids_limit)])
def port_dict_to_str(port_desc):
# NOTE: `mode: host|ingress` is ignored

64
tests/unit/test_container_to_args.py
View File

@ -630,3 +630,67 @@ class TestContainerToArgs(unittest.IsolatedAsyncioTestCase):
"busybox",
],
)
async def test_pids_limit_container_level(self):
c = create_compose_mock()
cnt = get_minimal_container()
cnt["pids_limit"] = 100
args = await container_to_args(c, cnt)
self.assertEqual(
args,
[
"--name=project_name_service_name1",
"-d",
"--network=bridge:alias=service_name",
"--pids-limit",
"100",
"busybox",
],
)
async def test_pids_limit_deploy_section(self):
c = create_compose_mock()
cnt = get_minimal_container()
cnt["deploy"] = {"resources": {"limits": {"pids": 100}}}
args = await container_to_args(c, cnt)
self.assertEqual(
args,
[
"--name=project_name_service_name1",
"-d",
"--network=bridge:alias=service_name",
"--pids-limit",
"100",
"busybox",
],
)
async def test_pids_limit_both_same(self):
c = create_compose_mock()
cnt = get_minimal_container()
cnt["pids_limit"] = 100
cnt["deploy"] = {"resources": {"limits": {"pids": 100}}}
args = await container_to_args(c, cnt)
self.assertEqual(
args,
[
"--name=project_name_service_name1",
"-d",
"--network=bridge:alias=service_name",
"--pids-limit",
"100",
"busybox",
],
)
async def test_pids_limit_both_different(self):
c = create_compose_mock()
cnt = get_minimal_container()
cnt["pids_limit"] = 100
cnt["deploy"] = {"resources": {"limits": {"pids": 200}}}
with self.assertRaises(ValueError):
await container_to_args(c, cnt)