the commit 38b13a3 ("Use asyncio for subprocess calls") broke the way
exit codes are reported from the podman compose build command.
The tasks are awaited as they finish which means that if a later build
finishes sucessfully after a failing build, it overwrites status.
Previously the `parse_return_code` function would skip updating the status
if the new return code was zero, but in removing it, this logic was not
carried forward.
Fixes: 38b13a3 ("Use asyncio for subprocess calls")
Signed-off-by: charliemirabile <46761267+charliemirabile@users.noreply.github.com>
When running 'podman-compose down <service>', if service is not part of
the compose, a KeyError exception is raised in function 'get_excluded'.
By only allowing evaluation of services that exist in the compose
provides a cleaner and gentler exit for this case.
Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
Since this is checked on PR, it could also be checked at commit so users can avoid making commits to
the tree without expected documentation.
Signed-off-by: Ian Fijolek <ian@iamthefij.com>
Added flake8 excludes to rules that are already ignored by the current
code to avoid validation issues with code that has already been
approved. Added pylint disable to line with lint offense already
accepted.
Signed-off-by: Italo Maia <italo.maia@gmail.com>
Current python files are already compatible with ruff, while very
incompatible with black standard therefore, this change just enforces
the reality of the codebase. Without it, pre-commit and the ci will
fight one-another with different formatting.
Signed-off-by: Italo Maia <italo.maia@gmail.com>
Allow setting an argument list as x-podman.pod_args to override the
default value `--infra=false --share=`. `--pod-args` passed on the command
line takes precedence over the value set in docker-compose.yml; the values
are not merged.
Fixes#1057.
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
podman-compose v1.0.6 is the last to support Python3.6. When newer
podman-compose version is used with too old Python, podman-compose gives
only a confusing error. This commit gives a clear message to use
upgraded Python version.
A descriptive error can not be thrown, as line "from __future__ imports"
must occur at the beginning of the file, but older Python (older than
Python3.7) does not recognize __future__ and throws an error
immediately.
Therefore, a comment is used to inform the user to update his Python
version.
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
