Commit Graph

925 Commits

Author SHA1 Message Date
Mohammad Kazemi
3973c476c4 catch SIGINT signal properly in 'up' function and call compose 'down' function for a graceful shutdown
Signed-off-by: Mohammad Kazemi <mokazemi@disroot.org>
2025-03-19 15:55:38 +03:30
Povilas Kanapickas
8b1bd0123c
Merge pull request #1168 from underground-software/build_exit
Properly surface errors from build commands
2025-03-19 12:50:16 +02:00
charliemirabile
2e7d83f7f0 Properly surface errors from build commands
the commit 38b13a3 ("Use asyncio for subprocess calls") broke the way
exit codes are reported from the podman compose build command.

The tasks are awaited as they finish which means that if a later build
finishes sucessfully after a failing build, it overwrites status.

Previously the `parse_return_code` function would skip updating the status
if the new return code was zero, but in removing it, this logic was not
carried forward.

Fixes: 38b13a3 ("Use asyncio for subprocess calls")
Signed-off-by: charliemirabile <46761267+charliemirabile@users.noreply.github.com>
2025-03-18 21:49:55 -04:00
Povilas Kanapickas
52e2912e0b
Merge pull request #1157 from mokibit/automate-selinux-test
test/integration: Automate manual `selinux` test
2025-03-11 18:15:55 +02:00
Monika Kairaityte
8ef537e247 test/integration: Automate manual selinux test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-03-06 13:04:53 +02:00
Povilas Kanapickas
04fcc26a79
Merge pull request #1117 from rjeffman/no_exception_if_service_is_not_in_compose
Don't raise exception on inexistent services in 'down' command
2025-03-05 22:17:10 +02:00
Rafael Guterres Jeffman
d4760712b7 Don't raise exception on inexistent services in 'down' command
When running 'podman-compose down <service>', if service is not part of
the compose, a KeyError exception is raised in function 'get_excluded'.

By only allowing evaluation of services that exist in the compose
provides a cleaner and gentler exit for this case.

Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
2025-03-05 15:49:52 -03:00
Povilas Kanapickas
7c61f24467
Merge pull request #1158 from mokibit/automate-uidmaps-test
test/integration: Automate manual `uidmaps` test
2025-03-04 23:41:55 +02:00
Monika Kairaityte
202c3771a9 test/integration: Automate manual uidmaps test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-03-04 22:28:50 +02:00
Povilas Kanapickas
a54f0fa573
Merge pull request #1149 from AlexandreAANP/fix/windows-asyncio-loop
Fix event loop handling for Windows platform in compose_up function
2025-03-01 16:43:26 +02:00
Povilas Kanapickas
3353697402
Merge pull request #1152 from IamTheFij/config-quiet
Add quiet flag to podman-compose config
2025-03-01 16:42:20 +02:00
Povilas Kanapickas
ca1b59c449
Merge pull request #1153 from IamTheFij/dco-hook
Add hook to check for signoff in commit messages
2025-03-01 16:39:50 +02:00
Ian Fijolek
b9f27795c0 Add hook to check for signoff in commit messages
Since this is checked on PR, it could also be checked at commit so users can avoid making commits to
the tree without expected documentation.

Signed-off-by: Ian Fijolek <ian@iamthefij.com>
2025-02-28 13:05:54 -08:00
Ian Fijolek
4cd1642be0 Add quiet flag to podman-compose config
This skips printing and is useful for validating config files.

Signed-off-by: Ian Fijolek <ian@iamthefij.com>
2025-02-28 12:48:08 -08:00
Alexandre Pita
fd401331e5 added release note to newsfragment directory
Signed-off-by: Alexandre Pita <alexandreanpita@gmail.com>
2025-02-27 11:45:38 +00:00
Alexandre Pita
37b27fa233 Refactor event loop handling to simplify logic for Windows platforms
Signed-off-by: Alexandre Pita <alexandreanpita@gmail.com>
2025-02-26 17:28:59 +00:00
Povilas Kanapickas
976847ef9b
Merge pull request #1143 from italomaia/bug/use-ruff
Bug: replaced black with ruff on pre-commit
2025-02-26 18:21:31 +02:00
Italo Maia
c6b3d497d6 Adds lint exclusions already ignored by the code
Added flake8 excludes to rules that are already ignored by the current
code to avoid validation issues with code that has already been
approved. Added pylint disable to line with lint offense already
accepted.

Signed-off-by: Italo Maia <italo.maia@gmail.com>
2025-02-26 17:57:34 +02:00
Italo Maia
10ad739746 Replaces black with ruff on pre-commit-config
Current python files are already compatible with ruff, while very
incompatible with black standard therefore, this change just enforces
the reality of the codebase. Without it, pre-commit and the ci will
fight one-another with different formatting.

Signed-off-by: Italo Maia <italo.maia@gmail.com>
2025-02-26 17:57:20 +02:00
Alexandre Pita
784d798dac Fix event loop handling for Windows platform in compose_up function
Signed-off-by: Alexandre Pita <alexandreanpita@gmail.com>
2025-02-26 14:38:46 +00:00
Povilas Kanapickas
dd01d039bf
Merge pull request #1140 from whym/rename-comment
Fix comment, add tests, improve coding style
2025-02-25 02:02:23 +02:00
Yusuke Matsubara
81a0a5933e Add more logging tests
Signed-off-by: Yusuke Matsubara <whym@whym.org>
2025-02-25 01:52:45 +02:00
Yusuke Matsubara
c289a3b827 Fix logging test coding style
Signed-off-by: Yusuke Matsubara <whym@whym.org>
2025-02-25 01:52:39 +02:00
Yusuke Matsubara
baccce4f3f Fix comments related to logging
Signed-off-by: Yusuke Matsubara <whym@whym.org>
2025-02-25 01:38:41 +02:00
Povilas Kanapickas
07af8488db
Merge pull request #1147 from joern19/main
Allow configuration of interface_name
2025-02-24 01:26:38 +02:00
Jörn Hirschfeld
cbc5a8c8b3 Add newsfragment for interface_name option
Signed-off-by: Jörn Hirschfeld <joern@hirschfeld.tech>
2025-02-23 17:08:06 +01:00
Jörn Hirschfeld
aeaceed7ba integration test for x-podman.interface_name option
Signed-off-by: Jörn Hirschfeld <joern@hirschfeld.tech>
2025-02-23 17:08:00 +01:00
Jörn Hirschfeld
b1eb558b41 Document existence of x-podman.interface_name
Signed-off-by: Jörn Hirschfeld <joern@hirschfeld.tech>
2025-02-23 17:04:10 +01:00
Jörn Hirschfeld
1cdc9e6552 interface_name can be specified in net_config_
Signed-off-by: Jörn Hirschfeld <joern@hirschfeld.tech>
2025-02-23 17:04:10 +01:00
Povilas Kanapickas
2f8ed2137c
Merge pull request #1144 from mokibit/automate-secrets-tests
test/integration: Automate manual `secrets` test
2025-02-20 09:57:11 +02:00
Monika Kairaityte
838957b902 test/integration: Automate manual 'secrets' test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-02-19 21:42:52 +02:00
Povilas Kanapickas
15380a809d
Merge pull request #1135 from rpluem-vf/keep_fds_open
Do not close file descriptors when executing podman
2025-02-18 13:26:15 +02:00
Ruediger Pluem
d4e5859370 Do not close file descriptors when executing podman
Do not close file descriptors when executing podman. This allows
externally created file descriptors to be passed to containers.
These file descriptors might have been created through systemd
socket activation. See also
https://github.com/containers/podman/blob/main/docs/tutorials/socket_activation.md#socket-activation-of-containers

Signed-off-by: Ruediger Pluem <ruediger.pluem@vodafone.com>
2025-02-12 11:35:51 +01:00
Povilas Kanapickas
593d7c825e
Merge pull request #1138 from mokibit/automate-seccomp-test
tests/integration: Automate manual `seccomp` test
2025-02-07 22:46:39 +02:00
Monika Kairaityte
bfba7ba32d tests/integration: Automate manual seccomp test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-02-07 22:38:58 +02:00
Povilas Kanapickas
fe9be2d98f
Merge pull request #1133 from neocturne/pod-args
Implement x-podman.pod_args to override --pod-args default
2025-02-07 20:59:36 +02:00
Matthias Schiffer
43a2f1d01f
Implement x-podman.pod_args to override --pod-args default
Allow setting an argument list as x-podman.pod_args to override the
default value `--infra=false --share=`. `--pod-args` passed on the command
line takes precedence over the value set in docker-compose.yml; the values
are not merged.

Fixes #1057.
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
2025-02-07 12:11:19 +01:00
Povilas Kanapickas
aa47a373ca
Merge pull request #1132 from mokibit/describe-test_pid
tests/integration: Describe `pid` test
2025-02-06 15:29:42 +02:00
Monika Kairaityte
eaec19336f tests/integration: Describe pid test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-02-06 15:16:44 +02:00
Povilas Kanapickas
34bee28bb8
Merge pull request #1131 from mokibit/automate-test-no_services
tests/integration: Automate manual `no_services` test
2025-02-05 20:53:38 +02:00
Monika Kairaityte
bfea139362 tests/integration: Automate manual no_services test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-02-05 20:47:59 +02:00
Povilas Kanapickas
4a81bce2a5
Merge pull request #1130 from mokibit/automate-nets_test_ip
tests/integration: Automate manual `nets_test_ip` test
2025-02-05 20:44:07 +02:00
Monika Kairaityte
e626f15eff tests/integration: Automate manual nets_test_ip test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-02-05 19:31:43 +02:00
Povilas Kanapickas
974250caa5
Merge pull request #1128 from mokibit/automate-nets_test3
tests/integration: Automate manual `nets_test3` test
2025-02-03 22:59:45 +02:00
Monika Kairaityte
29404af723 tests/integration: Automate manual 'nets_test3' test
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-02-03 19:04:15 +02:00
Povilas Kanapickas
d1ba2f4c7d
Merge pull request #1124 from notdian/file_not_found_error
remove incorrect os.chdir, handle relative extends/includes
2025-01-31 01:48:13 +02:00
notdian
e03d675b9b Remove incorrect os.chdir call to fix folder error
Signed-off-by: notdian <dian@fishekqi.com>
2025-01-31 01:24:24 +02:00
Povilas Kanapickas
51d180d2d0
Merge pull request #1120 from mokibit/inform-user-to-use-newer-python
Throw a readable error on too old Python
2025-01-27 21:53:24 +02:00
Povilas Kanapickas
9c905f9012
Merge pull request #1116 from Zeglius/dockerfile_inline
Add support for dockerfile_inline
2025-01-27 21:52:05 +02:00
Monika Kairaityte
bdb3e4e984 Throw a readable error on too old Python
podman-compose v1.0.6 is the last to support Python3.6. When newer
podman-compose version is used with too old Python, podman-compose gives
only a confusing error. This commit gives a clear message to use
upgraded Python version.
A descriptive error can not be thrown, as line "from __future__ imports"
must occur at the beginning of the file, but older Python (older than
Python3.7) does not recognize __future__ and throws an error
immediately.
Therefore, a comment is used to inform the user to update his Python
version.

Signed-off-by: Monika Kairaityte <monika@kibit.lt>
2025-01-27 21:49:50 +02:00