mirror of
https://gitlab.com/shorewall/code.git
synced 2024-11-14 03:34:31 +01:00
Avoid local exploitability with compile output file -- Take 2
git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@3255 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb
This commit is contained in:
parent
cfe0e4ee7b
commit
cc7f84cea9
@ -8823,7 +8823,7 @@ define_firewall() # $1 = Command (Start or Restart)
|
||||
#
|
||||
compile_firewall() # $1 = File Name
|
||||
{
|
||||
file=$1 dir=$(dirname $1)
|
||||
outfile=$1 dir=$(dirname $1)
|
||||
#
|
||||
# We overload a number of functions when compiling.
|
||||
#
|
||||
@ -8904,20 +8904,20 @@ compile_firewall() # $1 = File Name
|
||||
#
|
||||
# END OVERLOADED FUNCTIONS
|
||||
#
|
||||
case $file in
|
||||
case $outfile in
|
||||
*/*)
|
||||
[ -d $dir ] || startup_error "Directory $dir does not exist"
|
||||
[ -h $dir ] && startup_error "$dir is a Symbolic Link"
|
||||
[ -d $file ] && startup_error "$file is a Directory"
|
||||
[ -h $file ] && startup_error "$file is a Symbolic Link"
|
||||
[ -d $outfile ] && startup_error "$outfile is a Directory"
|
||||
[ -h $outfile ] && startup_error "$outfile is a Symbolic Link"
|
||||
|
||||
;;
|
||||
*)
|
||||
file=/var/lib/shorewall/$1
|
||||
outfile=/var/lib/shorewall/$1
|
||||
;;
|
||||
esac
|
||||
|
||||
[ -f $file -a ! -x $file ] && startup_error "$file exists and is not a restore file"
|
||||
[ -f $outfile -a ! -x $outfile ] && startup_error "$outfile exists and is not a restore file"
|
||||
|
||||
verify_os_version
|
||||
verify_ip
|
||||
@ -9045,7 +9045,7 @@ compile_firewall() # $1 = File Name
|
||||
|
||||
run_user_exit started
|
||||
|
||||
mv -f $RESTOREBASE $file
|
||||
mv -f $RESTOREBASE $outfile
|
||||
|
||||
chmod 700 $file
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user