holm/django-helpdesk
1
0
Fork 0
forked from extern/django-helpdesk
Code Issues Pull Requests Packages Projects Releases Wiki Activity
960 Commits 1 Branch 37 Tags 26 MiB
f5b68772cf
Commit Graph

960 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pawel M
f5b68772cf Downloaded attachment was not decoded and additionally encoded by default django method (its size after download is bigger than originally attached file). This is the reason why it is illegible 2016-12-13 23:31:26 +01:00
Pawel M
9939f62ebd Attachement should be readed in binary mode ... and attached as payload (regarding docs) 2016-12-13 23:28:16 +01:00
Pawel M
e7c4131ed7 Attachement should be readed in binary mode ... and attached as payload (regarding docs) 2016-12-13 22:43:14 +01:00
Pawel M
8bbe3d2e55 Merge branch 'hotfix/corrupt-forwarding-of-binary-attachments' of https://github.com/reduxionist/django-helpdesk 2016-12-13 19:53:51 +01:00
Jonathan Barratt
8dbd54ac16
stop corrupting binary attachments when delivering them by email 
We accomplish this by attching files to out-bound mail diffrently
depending on the versino of Python in effect. In Py2 we can read
the files ourseles and the standard library will still
be able to use the text we pass as if it were bytes. Under Py3,
however, email.message will complain if it doesn't get to decode
the bytes itself, so instead of attaching the contents directly
 we just pass the path to the file as a string instead. Unfortunately,
Django 1.8 does not work with this Python 3 approach, due to its
 not yet having reverted to the newly improved standard library's
mail-message implementation, and thus requiring us to know more
about the character-encoding/mimetype of the attachment than I've
been able to gather cleanly by this point.
 2016-12-13 19:41:13 +07:00
Pawel M
e326fea099 merged with upstream 2016-12-12 11:15:45 +01:00
Pawel M
556b6900db merged with upstream 2016-12-12 11:07:08 +01:00
Pawel M
6482c6338d merged with upstream 2016-12-12 10:32:01 +01:00
Pawel M
04ec40bbc8 merged with upstream 2016-12-12 10:31:29 +01:00
Pawel M
c11e360f50 PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) ... clear 2016-12-12 10:30:38 +01:00
Pawel M
550ca89415 PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) 2016-12-12 10:30:38 +01:00
Pawel M
905910911d PY3 support and msgNum error solved in process_queue method 2016-12-12 10:30:38 +01:00
Jonathan Barratt
6908e956e0 Merge pull request #465 from reduxionist/bugfix/urlquote-email-in-redirect 
urlquote email address when used as get query param
 2016-12-11 23:27:52 +07:00
Jonathan Barratt
e82e5fcd5f
urlquote email address when used as get query param 2016-12-11 06:20:03 +07:00
Jonathan Barratt
0edc75fc6c Merge pull request #464 from reduxionist/pr/393 
solves Title changed to . (Null title) on failed attachment upload.
 2016-12-11 06:18:24 +07:00
Pawel M
94c39cba69
solves Title changed to . (Null title) on failed attachment upload. 2016-12-11 06:00:05 +07:00
Jonathan Barratt
15c67da2a1 Merge pull request #463 from reduxionist/issue/multi/attachments 
refactor all handling of attached files
 2016-12-11 05:56:37 +07:00
Pawel M
5998faa6a5 PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) ... clear 2016-12-08 15:17:14 +01:00
Pawel M
4c97ecd0ae PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) 2016-12-08 15:14:11 +01:00
Pawel M
431d1fa3a5 Merge branch 'master' of https://github.com/django-helpdesk/django-helpdesk 2016-12-08 15:10:53 +01:00
Jonathan Barratt
5acd891c68
refactor all handling of attached files 
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
 2016-12-08 19:47:20 +07:00
Alex Seeholzer
142c2367d2 Merge pull request #459 from reduxionist/flinz_tests/get-email 
Expands testing of get_email
 2016-12-08 09:39:20 +01:00
Pawel M
d76fa2c71e PY3 support and msgNum error solved in process_queue method 2016-12-08 09:32:04 +01:00
Jonathan Barratt
391e35065c
per code review, update safe IP addr/port constants, remove commented-out code, and add comments to unexplained code 2016-12-06 09:55:22 +07:00
Jonathan Barratt
e8d0c5b2c7
implement mocked pop3 and imap tests for get_email 
also update travis to latest django patch releases
 2016-12-02 19:04:52 +07:00
Alex Seeholzer
4a7286f371
added requirements for testing 2016-12-02 17:40:46 +07:00
Alex Seeholzer
399b0901f6
newer version of tests 2016-12-02 17:40:46 +07:00
Alex Seeholzer
72a99cc99a
Moved existing test for local mailbox into generation of tests for matrix of email configurations; 2016-12-02 17:40:46 +07:00
Jonathan Barratt
1f63691dbe Merge pull request #457 from reduxionist/hotfix/456/ticket_from_message-missing-arg 
hotfix for #456:  patch calls to ticket_from_message
 2016-11-29 00:56:22 +07:00
Jonathan Barratt
3cfa371199
hotfix for #456: patch calls to ticket_from_message 
add logger arg where missing in get_email
 2016-11-29 00:46:42 +07:00
Jonathan Barratt
cac3267e82 Merge pull request #454 from reduxionist/prune-legacy-code 
Prune legacy code
 2016-11-21 20:32:35 +07:00
Jonathan Barratt
45a8ce98ac Merge pull request #455 from gwasser/ticket_list_view 
Use HTML5 table ordering based on Unix epoch
 2016-11-21 20:29:13 +07:00
Garret Wassermann
04f27fdcff Use HTML5 table ordering based on Unix epoch 2016-11-21 00:12:24 -05:00
Jonathan Barratt
7738bba2ab
remove special-case imports for legacy versions 
standardise use, or avoidance, of timezone, template from_string, and Context
 2016-11-21 10:16:03 +07:00
Jonathan Barratt
b4aa7767bd
drop quicktest compatibility for unsupported django versions 2016-11-21 09:31:40 +07:00
Jonathan Barratt
73fd081b48 Merge pull request #453 from willstott101/stringio_six 
Use Django's six module for StringIO imports.
 2016-11-17 19:11:37 +07:00
Will Stott
f34696df8d Use Django's six module for StringIO imports. 2016-11-17 11:25:46 +00:00
Jonathan Barratt
07f7489e2c Merge pull request #452 from gwasser/get_email 
Ensure that local files are deleted after processing
 2016-11-12 12:02:48 +07:00
Garret Wassermann
97a24fbe22
Ensure that local files are deleted after processing, and add some information about it to the install.rst documentation 2016-11-12 11:32:04 +07:00
Jonathan Barratt
fc5e5180b0 Merge pull request #451 from reduxionist/bugfix/non-namespaced-reverse-url-lookups 
convert reverse-URL lookups to helpdesk namespace
 2016-11-11 14:45:41 +07:00
Jonathan Barratt
ebfea8274d
convert reverse-URL lookups to helpdesk namespace 
in views.staff, this fixes:
-run_report's no-tickets-found redirect to report_index
-del_attachment's redirect to parent ticket view after deletion
 2016-11-11 10:31:37 +07:00
Jonathan Barratt
7eceb35d43 Merge pull request #447 from alexbarcelo/drop_south 
Drop south_migrations
 2016-11-03 18:56:06 +07:00
Alex Barcelo
e511aed934 removing leftover references to south_migrations folder 2016-11-02 17:24:05 +01:00
Alex Barcelo
b0b68b9541 drop south_migrations folder 2016-11-02 17:22:47 +01:00
Jonathan Barratt
dcbe9d1fed Merge pull request #446 from flinz/patches/open-file 
patch: implicit closing of open files
 2016-11-02 12:52:36 +07:00
Jonathan Barratt
0126b0b712 Merge pull request #445 from flinz/patches/travis-versionswitch 
updated travis 3.4 target to latest 3.4.4
 2016-11-02 12:44:19 +07:00
Alex Seeholzer
62163eaf0e patch: implicit closing of open files; 2016-11-01 15:03:51 +01:00
Alex Seeholzer
bc212a3dd1 updated travis target to latest python, ensuring latest mock patches are usable. 
before, travis randomly resolved "3.4" into 3.4.2 or 3.4.4.
 2016-11-01 15:01:50 +01:00
Jonathan Barratt
d54017f69f Merge pull request #419 from gwasser/bootstrap 
New Bootstrap-based UI
 2016-10-31 14:42:19 +07:00
Garret Wassermann
2a7d82413b Miscellaneous improvements from review of #419 2016-10-31 02:57:08 -04:00