Commit Graph

2368 Commits

Author SHA1 Message Date
Martin Whitehouse
50bd72ac7a
Move import to top 2022-07-25 04:31:17 +02:00
Martin Whitehouse
d858c40416
Add check_redirect_on_user_query helper function
Extract the checking for a redirect to reduce complexity
2022-07-25 04:29:43 +02:00
Martin Whitehouse
f89f5b91da
Reinstate changes, fixed missing update 2022-07-25 04:23:03 +02:00
Martin Whitehouse
40a243c23b
Revert changes, updating objects missed somewhere 2022-07-25 04:15:53 +02:00
Martin Whitehouse
a248181857
Add redirect_from_chosen_ticket helper function
Moves the whole handling to own block, reducing complexity greatly.
2022-07-25 04:08:16 +02:00
Martin Whitehouse
eb11c4fe0e
Rename ticket_attriubtes to upper, module level constant. 2022-07-25 04:03:12 +02:00
Martin Whitehouse
a783156b61
Add merge_ticket_values helper
Extract a large portion of code from `merge_tickets`
2022-07-25 04:01:27 +02:00
Martin Whitehouse
bed7f0e493
Add default value property to TicketCustomField
Property of the model, so add it there to keep consistency
2022-07-25 04:00:57 +02:00
Martin Whitehouse
46f8e9d21f
Clear error
Use.objects.get causes undefined variable when using get_user_model
2022-07-25 03:52:58 +02:00
Martin Whitehouse
1468982043
Remove unused variables, extract correct index 2022-07-25 03:50:49 +02:00
Martin Whitehouse
b326103d82
Fix spacing 2022-07-25 03:48:06 +02:00
Martin Whitehouse
57cd2f1471
Remove annoation for py3.8 2022-07-25 03:47:57 +02:00
Martin Whitehouse
45e47846fe
py3.8 annotation fix 2022-07-25 03:45:36 +02:00
Martin Whitehouse
7b4d53cfc0
Fix 'list' annoation for py3.8 2022-07-25 03:44:04 +02:00
Martin Whitehouse
749ebbe16b
Fix annotations for py3.8 2022-07-25 03:42:16 +02:00
Martin Whitehouse
595dae1cf7
Add get_template_staff_and_template_cc function
Furhter reduxes complexity by combining creation of templates
2022-07-25 03:38:16 +02:00
Martin Whitehouse
256af24daa
Comment function 2022-07-25 03:34:03 +02:00
Martin Whitehouse
a2f33c9799
Add add_staff_subscription helper
Further reduces complexity by checking for subscription in helper
function
2022-07-25 03:32:45 +02:00
Martin Whitehouse
f678c63496
Add update_messages_sent_to_by_public_and_status helper function
Handles updating ticket and sending ticket reply
2022-07-25 03:30:07 +02:00
Martin Whitehouse
fe619b5ff2
Combine conditionals to single line 2022-07-25 03:22:59 +02:00
Martin Whitehouse
f815ebbb5c
Add get_time_spent_from_request helper
Extracts further code
2022-07-25 03:17:10 +02:00
Martin Whitehouse
9294eca5d6
Add get_and_set_ticket_status helper
Extracts some futher code from `update_ticket`
2022-07-25 03:11:30 +02:00
Martin Whitehouse
ecefd5e407
Extract the due_date to helper function 2022-07-25 03:01:50 +02:00
Martin Whitehouse
574395ee28
Easy pickings
Simple code violations of reserved symbols etc.
2022-07-25 02:46:33 +02:00
Martin Whitehouse
8d63d65a7d
Removed encoding to 'utf-8', breaks tests.
This needs to be looked into further.
2022-07-25 02:41:40 +02:00
Martin Whitehouse
4e2b7deefb
Reduces complexity of object_from_message
Helper functions created to help break up the flow
2022-07-25 02:22:32 +02:00
Martin Whitehouse
a5e74d6449
Extract getting ticket_id from subject to helper function 2022-07-25 01:56:13 +02:00
Martin Whitehouse
283f052c0e
Annotate function signature 2022-07-25 01:47:00 +02:00
Martin Whitehouse
80f4152301
Simplify return statement
Rename `ticket` to `ticket_id` for clarity
2022-07-25 01:43:43 +02:00
Martin Whitehouse
0b1de1eead
Removed unused import
Result of previous code removal
2022-07-25 01:23:12 +02:00
Martin Whitehouse
fe28c2f540
Merge branch 'unstable' of git@github.com:martin-marty/django-helpdesk.git into 1039-complexity-reduction 2022-07-25 01:22:11 +02:00
Martin Whitehouse
1ac78955c0
Removed notifications_to_be_sent list
The whole loop appeared to be doing nothing other than appending email
addresses to a list, which was never used.
2022-07-25 01:22:05 +02:00
Martin Whitehouse
e863609cbe
Add complexity to flake8 configuration
Set to maximum value 20
2022-07-25 01:17:12 +02:00
Martin Whitehouse
cf804a586a
Add verbosity argument to quicktest
Enables verbose output for analysis on what is happening
2022-07-25 01:16:46 +02:00
Garret Wassermann
148eff8b7b
Merge pull request #1037 from uhurusurfa/unstable
Add django-cleanup app to support deleting file system files
2022-07-23 17:20:41 -04:00
Garret Wassermann
bdd8e39421
Update install.rst
Fix a docs misspelling
2022-07-23 17:18:01 -04:00
Alex
645ce17c6f Fix. Fix problem wich version package in requirements 2022-07-23 22:16:07 +07:00
chrisbroderick
0d85acc460 Add Django cleanup app for attachment file system deletion 2022-07-23 12:14:36 +01:00
chrisbroderick
58ed521a2c Add the file system deletion app for attachments into INSTALLED_APPS 2022-07-23 11:58:28 +01:00
Garret Wassermann
681e8b267d
Merge pull request #1036 from martin-marty/redundant_cc_code_in_email
Remove left over 'cc' code
2022-07-22 13:52:54 -04:00
Martin Whitehouse
0f0b0a5995
Remove left over 'cc' code 2022-07-22 16:27:38 +02:00
Garret Wassermann
3a90af142b
Merge pull request #1034 from martin-marty/tox_dependencies
Add initial tox.ini
2022-07-22 02:35:33 -04:00
Garret Wassermann
868e7a667a
Merge branch 'unstable' into tox_dependencies 2022-07-22 02:33:21 -04:00
Garret Wassermann
e29f07ab90
Merge pull request #1035 from martin-marty/github-workflow-tools-isort
GitHub workflow tools isort
2022-07-22 02:32:32 -04:00
Garret Wassermann
57f9ae0a1c
Merge branch 'unstable' into tox_dependencies 2022-07-22 02:27:41 -04:00
Garret Wassermann
8bb357fa90
Merge pull request #1032 from martin-marty/github-workflow-tools
GitHub workflow tools
2022-07-22 02:24:06 -04:00
Martin Whitehouse
44f068d1b8
re-apply formatting 2022-07-22 03:30:35 +02:00
Martin Whitehouse
c2e933b1fb
Removed future import 2022-07-22 03:28:46 +02:00
Martin Whitehouse
25542f929e
Initial isort configuration
Will fail build if imports are not sorted correctly
2022-07-22 03:26:41 +02:00
Martin Whitehouse
b867cf5680
Add initial tox.ini
`make release` will now create a test environment free from the source.
Gives isolated testing.
2022-07-22 02:06:36 +02:00