Garret Wassermann
fb6e8b0566
Remove offending comment in jquery ui css to address an issue brought up in #479
2017-04-20 03:06:10 -04:00
Garret Wassermann
d13e87bd3b
Last PEP-8 fix?
2017-04-20 02:54:35 -04:00
Garret Wassermann
45c457ead2
More PEP-8 fixes on test_get_email
2017-04-20 02:49:06 -04:00
Garret Wassermann
47f3eb8e89
PEP-8 fixes
2017-04-20 02:44:12 -04:00
Garret Wassermann
bf344b09b1
Check CC'd email against list of User emails, and add the User to the ticket if necessary and not already the assignee, etc.
2017-04-20 02:36:10 -04:00
Garret Wassermann
8963fa694a
Prevent adding Users or Queue email to the CC list
2017-04-19 23:47:58 -04:00
Garret Wassermann
220c0460e1
Check number of CCs to ensure no duplicates made it through
2017-04-19 00:04:16 -04:00
Garret Wassermann
34ce553435
Only add CC emails to Ticket if they were not already included (no duplicates), add testing for it
2017-04-18 23:36:39 -04:00
Garret Wassermann
3b22bb655a
PEP8 fixes for too many blank lines
2017-04-16 05:14:30 -04:00
Garret Wassermann
e3a378625c
Add test with django template tag in email body, to ensure we test for and fix #72 in future changes
2017-04-16 05:10:51 -04:00
Garret Wassermann
8e1a6b30fa
Fix encoding first before splitting strings, so it works on Python 2
2017-04-16 04:59:57 -04:00
Garret Wassermann
7b8426596f
Separate out the CC test from plain test so we're testing both possibilities (with and without a CC)
2017-04-16 04:51:46 -04:00
Garret Wassermann
49aac657a9
PEP8 fixups
2017-04-16 04:44:16 -04:00
Garret Wassermann
b2ac1fd3a5
#95 : save CC'd emails on a comment to the Ticket for future correspondence, set to view only initially, and update tests for CC
2017-04-16 04:19:17 -04:00
Garret Wassermann
01e87f2cb8
#72 : Prevent django template tags from being executed in followup comments
2017-04-16 03:24:39 -04:00
Will Stott
fb0782294e
Don't show error on initial get.
2017-04-13 11:36:38 +01:00
Will Stott
b7a97183cb
Never return None from views.public.create_ticket
...
Would create a 500 when user omitted their email. Only a partial improve. Added a TODO: as this view still breaks if passing non-numeric characters to the ID.
I assume this needs a full overhaul really.
2017-04-13 11:30:29 +01:00
Jonathan Barratt
d843a21ea7
Merge branch 'master' into master
2017-04-06 08:21:43 +07:00
Garret Wassermann
9531b9649a
Fix errors in Python 2, used six to workaround encoding weirdness, all tests pass on both Py2/3
2017-04-03 02:52:49 -04:00
Garret Wassermann
5ec985af9b
Add explicit encoding hint to top of file to allow Python 2 to read file with Unicode characters, in accordance with PEP-263
2017-04-03 02:34:54 -04:00
Garret Wassermann
0fb9094d01
Remove line for PEP8
2017-04-03 02:29:28 -04:00
Garret Wassermann
f43ef69ec1
Add a MIME multipart email test for get_email
2017-04-03 02:19:29 -04:00
Garret Wassermann
74a7afadb9
Update get_email test to use unicode characters; seem to have found an encoding errory in get_email, provided a fix that satisfies test
2017-04-03 01:53:25 -04:00
Garret Wassermann
194082750d
Merge remote-tracking branch 'upstream/master' into 487_new_test
2017-03-31 14:29:19 -04:00
Jonathan Barratt
19799572c9
Merge pull request #499 from Yuego/master
...
Migration added
2017-03-31 19:51:58 +07:00
Jonathan Barratt
6deb0caf96
Merge pull request #497 from gwasser/update_es_MX
...
Update es_MX translations
2017-03-31 19:37:18 +07:00
Yuego [Home]
5629276050
Migration added
2017-03-26 10:24:32 +04:00
Garret Wassermann
d3c713333d
Update es_MX translations on behalf of @andresf01, for #496
2017-03-17 10:00:37 -04:00
Yuego [Home]
d8ff278697
Russian translation update
2017-03-08 23:05:26 +04:00
Yuego [Home]
dfdb12e354
Fix link translation
2017-03-08 23:01:31 +04:00
Garret Wassermann
6fec1015c3
Work in progress on unicode chars
2017-02-15 18:51:20 -05:00
Michael Huang
b263b22cca
Wrap message.encode() in conditional for Python 2
2017-02-14 14:58:16 -08:00
Michael Huang
f16a196c69
Fix logout URL
2017-02-14 14:38:48 -08:00
Michael Huang
dc851fc557
Force message to be unicode to avoid encoding issues
2017-02-14 12:34:53 -08:00
Garret Wassermann
2164c3bc4d
Change queue permission_name from 50 chars to 72 chars ( #484 )
...
* Change queue permission_name from 50 chars to 72 chars to accomodate slug + prepended text, to resolve #483
2017-02-12 17:33:53 +07:00
Jonathan Barratt
fe92880928
do not throw exceptions for invalid/non-UTF8 IMAP content
2017-01-14 01:25:43 +07:00
Jonathan Barratt
b5feeb7ee9
Make SOCKS-proxy support global for all queues under Py3
...
Python 2 retains per-queue SOCKS-proxy support, but this is simplest fix until someone needs it for Python 3.
2017-01-14 01:25:17 +07:00
Alex Seeholzer
a2315eb0c4
added pep8 fix and missing migration
2017-01-13 17:39:56 +01:00
Alex Seeholzer
645f196848
Added tests covering the usersettings_helpdesk occurrences
2017-01-13 17:37:10 +01:00
Alex Seeholzer
4e018db5a6
Added unique related_name “usersetttings_helpdesk” for the one-to-one relation to User in UserSettings.
2017-01-13 15:22:41 +01:00
Jonathan Barratt
2f66c50320
Make helpdesk work in apps with their own queue models
...
To avoid returning multiple content types when creating custom permissions, use ContentType.objects.get_for_model to lookup the content type for helpdesk.models.queue.
2017-01-13 17:52:29 +07:00
User
787c3aa4f5
make old subject_part pretty
2017-01-09 00:30:36 +01:00
User
b7baf2bf56
fix for error:BadHeaderError: Header values can't contain newlines when running get_email. caused by subject_part being repeated, but second time doesnt strip newlines
2017-01-08 18:52:24 +01:00
Jonathan Barratt
8a2e6c087e
hotfix for #470 : datatables error on empty ticket list
...
handle the no tickets match query case with js rather than python for DataTables compatibility
2017-01-03 00:42:12 +07:00
Garret Wassermann
3c6b522464
Fix form end tag placement, and remove duplicate unstyled query box
2016-12-13 23:45:43 -05:00
Jonathan Barratt
e82e5fcd5f
urlquote email address when used as get query param
2016-12-11 06:20:03 +07:00
Pawel M
94c39cba69
solves Title changed to . (Null title) on failed attachment upload.
2016-12-11 06:00:05 +07:00
Jonathan Barratt
5acd891c68
refactor all handling of attached files
...
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
2016-12-08 19:47:20 +07:00
Jonathan Barratt
391e35065c
per code review, update safe IP addr/port constants, remove commented-out code, and add comments to unexplained code
2016-12-06 09:55:22 +07:00
Jonathan Barratt
e8d0c5b2c7
implement mocked pop3 and imap tests for get_email
...
also update travis to latest django patch releases
2016-12-02 19:04:52 +07:00