forked from extern/nushell
83b1ec83c9
# Description Currently, error spans for I/O errors in an `rm` invocation always point to the `rm` argument. This isn't ideal, because the user loses context as to which “target” actually had a problem:  Shadow the existing `span` variable in outer scope in `rm`'s implementation for the errors that may be detected while handling I/O results. This is desired, because all failures from this point are target-specific, and pointing at the argument that generated the target instead is better. The end user should now see this:  # User-Facing Changes * When `rm` encounters I/O errors, their spans now point to the “target” argument associated with the error, rather than the `rm` token. # Tests + Formatting No tests currently cover this. I'm open to adding tests, but adding as follow-up sounds better ATM, since this wasn't covered before. # After Submitting Nothing needs to be done here, AFAIK. No I/O errors are currently demonstrated in official docs, though maybe they should be? |
||
|---|---|---|
| .. | ||
| cd_query.rs | ||
| cd.rs | ||
| cp.rs | ||
| glob.rs | ||
| ls.rs | ||
| mkdir.rs | ||
| mod.rs | ||
| mv.rs | ||
| open.rs | ||
| rm.rs | ||
| save.rs | ||
| start.rs | ||
| touch.rs | ||
| util.rs | ||
| watch.rs | ||
