Avoid 'Invalid BROADCAST address' errors

Signed-off-by: Tom Eastep <teastep@shorewall.net>


git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@9919 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb
This commit is contained in:
teastep 2009-04-17 22:57:59 +00:00
parent 536025e44e
commit 0cc60ea021
3 changed files with 7 additions and 1 deletions

View File

@ -735,7 +735,7 @@ sub validate_interfaces_file( $ )
my $broadcasts; my $broadcasts;
unless ( $networks eq '' || $networks eq 'detect' ) { unless ( $networks eq '' || $networks eq 'detect' ) {
my @broadcasts = split $networks, 'address'; my @broadcasts = split_list $networks, 'address';
for my $address ( @broadcasts ) { for my $address ( @broadcasts ) {
fatal_error 'Invalid BROADCAST address' unless $address =~ /^(\d+)\.(\d+)\.(\d+)\.(\d+)$/; fatal_error 'Invalid BROADCAST address' unless $address =~ /^(\d+)\.(\d+)\.(\d+)\.(\d+)$/;

View File

@ -6,6 +6,8 @@ Changes in Shorewall 4.3.9
3) Allow Shorewall6 with kernel 2.6.24 3) Allow Shorewall6 with kernel 2.6.24
4) Avoid 'Invalid BROADCAST address' errors.
Changes in Shorewall 4.3.8 Changes in Shorewall 4.3.8
1) Apply Tuomo Soini's patch for USE_DEFAULT_RT. 1) Apply Tuomo Soini's patch for USE_DEFAULT_RT.

View File

@ -64,6 +64,10 @@ released late in 2009.
/etc/shorewall/tcfilters, an incorrect netmask was being generated in /etc/shorewall/tcfilters, an incorrect netmask was being generated in
the resulting 'tc' rule. the resulting 'tc' rule.
3) Placing an IP address in the BROADCAST column of
/etc/shorewall/interfaces caused Shorewall-perl to generate an
erroneous 'Invalid BROADCAST address' error.
---------------------------------------------------------------------------- ----------------------------------------------------------------------------
K N O W N P R O B L E M S R E M A I N I N G K N O W N P R O B L E M S R E M A I N I N G
---------------------------------------------------------------------------- ----------------------------------------------------------------------------