9fa223eaaf
* chore(build): compile protobufs with protox protox is a pure-rust implementation of the protobuf compiler. Therefore, it can be managed by cargo. This removes the implicit dependency on protoc being available in the environment for the build. * fix(build): replace copypasta in build script The paths passed to `compile` aren't actually used by the build. `skip_protoc_run` prevents that. That's why a clean build succeeds even with this mistake. However, the paths are passed to a `cargo:rerun-if-changed` directive. So this mistake would've caused a failed incremental build if the protobuf definitions were changed.
2.4 KiB
Contributing
Thank you so much for considering contributing to Atuin! We really appreciate it <3
Development dependencies
- A rust toolchain (rustup recommended)
We commit to supporting the latest stable version of Rust - nothing more, nothing less, no nightly.
Before working on anything, we suggest taking a copy of your Atuin data directory (~/.local/share/atuin on most *nix platforms). If anything goes wrong, you can always restore it!
While data directory backups are always a good idea, you can instruct Atuin to use custom path using the following environment variables:
export ATUIN_DB_PATH=/tmp/atuin_dev.db
export ATUIN_RECORD_STORE_PATH=/tmp/atuin_records.db
It is also recommended to update your $PATH so that the pre-exec scripts would use the locally built version:
export PATH="./target/release:$PATH"
These 3 variables can be added in a local .envrc file, read by direnv.
PRs
It can speed up the review cycle if you consent to maintainers pushing to your branch. This will only be in the case of small fixes or adjustments, and not anything large. If you feel OK with this, please check the box on the template!
What to work on?
Any issues labeled "bug" or "help wanted" would be fantastic, just drop a comment and feel free to ask for help!
If there's anything you want to work on that isn't already an issue, either open a feature request or get in touch on the forum/Discord.
Setup
git clone https://github.com/atuinsh/atuin
cd atuin
cargo build
Running
When iterating on a feature, it's useful to use cargo run
For example, if working on a search feature
cargo run -- search --a-new-flag
While iterating on the server, I find it helpful to run a new user on my system, with sync_server set to be localhost.
Tests
Our test coverage is currently not the best, but we are working on it! Generally tests live in the file next to the functionality they are testing, and are executed just with cargo test.
Migrations
Be careful creating database migrations - once your database has migrated ahead of current stable, there is no going back
Stickers
We try to ship anyone contributing to Atuin a sticker! Only contributors get a shiny one. Fill out this form if you'd like one.