extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-27 10:23:28 +01:00
Code Issues Packages Projects Releases Wiki Activity
24,255 Commits 32 Branches 355 Tags 194 MiB
6e831aaad9
Commit Graph

7707 Commits

Author SHA1 Message Date
Ralf Becker
bfade1bbbc fix query to work with Postgres: string literals need single quotes not double 2014-06-25 09:23:21 +00:00
Ralf Becker
9da3a90a96 improved repair of required nods to cope with renamed or wrongly linked nods like / having a name and/or linked to itself instead of 0, also fixed IDE warnings 2014-06-25 08:23:28 +00:00
Nathan Gray
a852eed949 Add save as ZIP action 2014-06-24 19:29:05 +00:00
Ralf Becker
7505b92bcb fixed not working password link in Firefox (JSON.parse in FF does not like white-spaces) 2014-06-24 14:07:42 +00:00
Klaus Leithoff
2502f5500a * Notification/Mail: make sure acc_smtp_username is used (if available), to cope with strict mailserver settings to prevent faking sender information 2014-06-24 13:38:32 +00:00
Ralf Becker
d6ce36d735 bump versions to 14.1 2014-06-24 10:00:50 +00:00
Ralf Becker
74b98920de fixed lost type2 values in cf migration eg. InfoLog type cf is valid for 2014-06-24 07:47:43 +00:00
Ralf Becker
af9b8303d6 make egw_db::from_bool() static and use that to work around PHP 5.3 limitation of not making class scope available in closures 2014-06-24 07:25:35 +00:00
Ralf Becker
ffae12e240 * all apps: custom-fields are now stored in own egw_customfields table (no more limit on number), site configurations get now JSON serialized 2014-06-23 14:35:22 +00:00
Ralf Becker
d4bb8a00a9 move et2_call method to egw.js to have it always available at window scope (it is NOT et2 specific), maybe we find a better/nicer place for it 2014-06-23 08:10:40 +00:00
Ralf Becker
ff00c695ca new API method egw_framework::popup($link, $target="_blank", $popup="640x480") to open a popup independent of running a regular or a JSON request 2014-06-18 13:57:15 +00:00
Ralf Becker
6e6e75182b added a debug message 2014-06-18 08:22:12 +00:00
Nathan Gray
715bbf9abe If a refresh of a particular UID is requested and server doesn't give it then remove it. 
Fixes refresh where the row no longer match filters, but is still there.
 2014-06-17 19:23:14 +00:00
Hadi Nategh
75b9624266 Fix calendar multiselect accounts not change the view after submit 2014-06-17 16:03:54 +00:00
Ralf Becker
0f3be64360 (re-)set VFS user for vfs access rights, when user of async job changes 2014-06-17 06:52:52 +00:00
Ralf Becker
b49d9fac67 Entry directories are always reported existing and empty, if not existing in sqlfs 2014-06-16 20:01:59 +00:00
Ralf Becker
e16b6b361d using PHP 5.3 late static binding and closures 2014-06-16 08:41:46 +00:00
Ralf Becker
ad85c88c72 only save preferences of apps whos preferences actually changed 2014-06-13 16:08:42 +00:00
Hadi Nategh
2ff1107b78 Ignore favorite preferences which are not correctly serialized, and somehow are stroed in database. At the moment we just ignore them, but they stays in database, need to be watched closely to find the cause, though. 2014-06-13 16:03:16 +00:00
Ralf Becker
541e6f9bb5 need to remove /e modifier, when using preg_replace_callback 2014-06-13 13:30:36 +00:00
Ralf Becker
60106975aa * Preferences: now stored JSON encoded in database (also removed many deprecated methods) 2014-06-13 13:15:21 +00:00
Hadi Nategh
b9038925a8 Add jQuery onchange handler for tz_selection selectbox in idots 2014-06-13 11:36:46 +00:00
Hadi Nategh
78e701ed85 Remove another inline script which was violating CSP 2014-06-13 11:16:04 +00:00
Ralf Becker
a5eb58638d fixed IDE warnings 2014-06-13 07:04:51 +00:00
Ralf Becker
e9295a5861 replaced PHP 5.5 boolval function with (bool) cast 2014-06-12 10:21:33 +00:00
Ralf Becker
95b89a0c9f fixed under some conditions not working translations, caused by egw object calling translation::init and preceeding lang_arr with (en) translations, before lang.php calls add_app() with a single translation, now explicitly calling init() and init() allways empties lang_arr 2014-06-12 10:07:57 +00:00
Nathan Gray
44ae90b8d3 Avoid warning from explode() if type2 is already an array 2014-06-11 17:33:19 +00:00
Nathan Gray
80962c1963 No permission check when initializing link hooks for during asyncronous processing. 
Fixes missing links in notifications.
 2014-06-11 17:30:44 +00:00
Nathan Gray
2bc3ad43c0 Avoid undefined error when links is not provided 2014-06-10 15:27:11 +00:00
Ralf Becker
76fc9f97dc set $GLOBALS[egw_info][flags][async-service] (check with isset()), so emailadmin can check if there is no user-session 2014-06-05 11:05:45 +00:00
Ralf Becker
6efc08cc0a * Notifications: fixed not used SMTP authentication and selection of mail account 2014-06-05 10:36:13 +00:00
Ralf Becker
f5d4cdf7c0 fix IDE warnings 2014-06-05 10:33:38 +00:00
Ralf Becker
6d6e9d8a43 also replace p tags 2014-06-05 09:54:21 +00:00
Ralf Becker
854d17b46b fix PHP Deprecated: preg_replace(): The /e modifier is deprecated 2014-06-05 08:52:08 +00:00
Ralf Becker
07cd6838f5 * Admin/Filemanager: creating groups did not create group directory, but damaged VFS (can be repaired with "Check virtual filesystem") 2014-06-04 09:26:29 +00:00
Ralf Becker
90214935be reapplied r42638: Add a global ajax callback so the et2 widget can stay in sync with the dhtmlxtree 2014-06-03 08:56:14 +00:00
Ralf Becker
d9c9e06aad reapplied r41681: fixed event handling in tree, added tree specific onSelect and onCheck events, implemented !multiple mode and fixed dhtmlxtree to not trigger onSelect if selection is change via set_value (according to their documentation) 2014-06-03 08:54:46 +00:00
Ralf Becker
85c5468013 fixed old tree stuff to use new dhtmlx locations, allways use dhtmlxtree/codebase/dhtmlxcommon.js 2014-06-03 08:17:43 +00:00
Nathan Gray
3b8bee4d18 Update dhtmlxTree & dhtmlMenu to latest version 2014-06-02 23:32:15 +00:00
Nathan Gray
4b1fc627c4 Update dhtmlxTree & dhtmlMenu to latest version 2014-06-02 23:31:30 +00:00
Ralf Becker
960b50b83a sync CalDAV default-alarm trigger/time to calendar preference 2014-05-28 10:57:02 +00:00
Nathan Gray
07ec496a8e Decode stored favorite before parsing it, fixes missing umlauts 2014-05-27 18:52:44 +00:00
Nathan Gray
32f51ced99 Remove error log 2014-05-27 15:49:51 +00:00
Klaus Leithoff
5e44a189cc other changes (keep_bad and -htmlawed-transform) that did affect the expected result of htmlawed v1.1.17 compared to v1.1.14 2014-05-27 15:26:06 +00:00
Nathan Gray
eaccfdfe1d Enhance error message to include request info 2014-05-27 14:53:34 +00:00
Klaus Leithoff
9924612245 allow cid as overall url schema; handle background url in htmLawed, as background is not allowed except for body, but commonly used with other tags (e.g. in td); control schema for background in hook_tag 
introduce and use new make_tag_strict option 3, to exclude font from applying strict measures to it
allow table as inline element while balancing tags (new internal config option); try to correct common errors/problems in html-code which caused display/layout problems
 2014-05-27 14:12:44 +00:00
Klaus Leithoff
f94e6bb501 * API/htmLawed: update to version 1.1.17 2014-05-27 13:52:02 +00:00
Ralf Becker
d1c25c7c38 * fixed SQL error "Field last_mod doesnt have a default value" on update for newer MySQL versions or PostgreSQL 2014-05-27 12:46:18 +00:00
Ralf Becker
9ed199261a fix dialog and translations to allow messages with newlines 2014-05-27 12:11:09 +00:00
Nathan Gray
e9d426111a Keep unsorted favorites 2014-05-26 23:00:02 +00:00
Ralf Becker
ddc17e8e0d allow null as well as undefined for message-type-detection 2014-05-26 15:39:21 +00:00
Ralf Becker
baf7e2e97a remove unnecessary and in PHP 5.5 deprecated preg_replace /e modifier 2014-05-26 14:29:40 +00:00
Ralf Becker
28b45639be to give observer method of other apps more information about what to refresh, server-side adds now links to refresh-opener and therefore observer calls 2014-05-26 13:29:35 +00:00
Ralf Becker
b1603f4fd3 support <br/> and a single <a href="...">Text</a> (no further attributes!) in egw.message() 2014-05-26 13:05:40 +00:00
Ralf Becker
c04f0ccc8f fix not updated infolog in list, when timesheet is booked on it: added "row_mod" as maximum of info_modified, link_lastmod (incl. deleted ones) and timesheet_bo::sum() max_modified 2014-05-24 10:59:03 +00:00
Ralf Becker
ddc1b2d673 docu update about how to stop regular refresh 2014-05-23 09:20:42 +00:00
Ralf Becker
7edd12d251 run observers in main window (eg. not iframe, which might be opener!) 2014-05-23 09:19:46 +00:00
Ralf Becker
24ee68bdf2 fixed infinit loop for apps running in iframe by refactoring frameworked templates work with client-side api: 
- moved shared etemplate2 part into static etemplate2.app_refresh() method
- egw_message.refresh() calls framework.refresh() which can return a DOMwindow for egw.refresh() to work on, instead of calling egw.refresh recursive
 2014-05-23 08:21:11 +00:00
Ralf Becker
893091e286 - new app.js observer method which receives update notifications from all apps 
- app.infolog.observer triggering refresh of InfoLog list, when a timesheet get stored
- moved code of already deprecated egw_refresh() to egw.refresh() and changed etemplate to use that
- framework from jdots/pixelegg template no longer overwrites window.egw_refresh, but egw.refresh calls framework.refresh for regular refreshs if framework is present
 2014-05-22 15:29:14 +00:00
Hadi Nategh
b3ee7bc605 Make sure if the refresh is done, then give up not to reload the whole page 2014-05-22 11:27:29 +00:00
Ralf Becker
4b9078eb7d fix implementation of calling (set|get|unset)Cache with install_id to behave identical to call to (set|get|unset)Instance for current instances install_id (install_id was used directly in keys) 2014-05-22 11:21:02 +00:00
Klaus Leithoff
a50810f9a6 if kama is choosen as skin, use monocolor; kama-skin seems not be fully compatible with ckeditor requirements on skins; next ckeditor update will remove kama skin 2014-05-22 10:01:31 +00:00
Nathan Gray
a5cdc928f0 Call static methods staticly 2014-05-21 16:48:36 +00:00
Ralf Becker
e6304eec45 fixed PHP Fatal error: Attempt to unset static property accounts::$cache 2014-05-20 15:55:17 +00:00
Ralf Becker
c7d32e47d5 egw_cache::(get|set|unset)Cache($level,...) excepts now an install_id to use instance cache of given instance 
accounts class uses now instance_id to access instance cache to support using it with multiple instances
instanciating accounts class with an array of config values clears now internal static cache and singelton instance
 2014-05-20 08:59:29 +00:00
Ralf Becker
01a7875627 egw_cache::(get|set|unset)Cache($level,...) excepts now an install_id to use instance cache of given instance 
accounts class uses now instance_id to access instance cache to support using it with multiple instances
instanciating accounts class with an array of config values clears now internal static cache and singelton instance
 2014-05-20 08:59:23 +00:00
Ralf Becker
9602d061ad * Setup: re-add config for mail authentication and fixed it to always try to use a TLS connection 2014-05-17 08:00:17 +00:00
Ralf Becker
c3b7018916 logging for exceptions now also request-method and user-agent 2014-05-16 09:09:38 +00:00
Ralf Becker
ef07aebbd4 * ProjectManager/Timesheet: automatic change a changed project-title in Timesheet too 2014-05-15 13:20:52 +00:00
Ralf Becker
802d4c5282 * ProjectManager: fixed parent projects were not updated with changes (you had to run sync-all manually 
caused by running notifications delayed after response is send to user and to taking into account new notifications generated by notified apps
 2014-05-15 13:14:09 +00:00
Ralf Becker
bdbc22dd98 reverted r46410 calling header explicitly before navbar, causing navbar no longer being able to add stuff to header, eg. include javascript 
and fixing idots_framework::navbar() to still call header, if $navbar_done is set
 2014-05-15 09:41:31 +00:00
Nathan Gray
33f264346a Fix error deleting a favorite 2014-05-13 21:39:23 +00:00
Ralf Becker
b25724e7ed fixed setup uses cached config values for installs with multiple instances 2014-05-13 15:53:35 +00:00
Ralf Becker
e4e4aa97bc flushing instance cache and config cache, after saving minimal config, fixing default_records of apps use not up to date data 2014-05-13 09:32:21 +00:00
Ralf Becker
19fc7acb7f top.egw is a function not an object 2014-05-13 08:48:27 +00:00
Ralf Becker
ac220a6e82 using egw.is_popup() which deals with situation of egw main-window having an opener (eg. bookmark) 2014-05-13 06:44:50 +00:00
Nathan Gray
9a8182480f Stop popups from re-initializing sidebox. Fixes favorites causing whole application to reload after saving a popup. 2014-05-12 20:36:18 +00:00
Ralf Becker
927b6eacb3 seems webspellchecker in CKEditor uses now https, need to allow that instead of http in CSP policy 2014-05-08 16:46:59 +00:00
Ralf Becker
194606b196 public method to translate between PHP and jQuery date(Time)Picker date/time-format 2014-05-08 15:57:07 +00:00
Ralf Becker
a345f2c47e implemented search method in accounts sql backend, to no allways do a full query and limit in code 2014-05-08 13:35:22 +00:00
Ralf Becker
7c9df2fe1e implemented search method in accounts sql backend, to no allways do a full query and limit in code 2014-05-08 12:30:03 +00:00
Ralf Becker
79fa175235 fixed SQL error stalling update, if addressbook contains no entries without 2-letter country-code 2014-05-08 12:03:00 +00:00
Ralf Becker
c29cb5c972 limiting a huge list of accounts returned not all accounts, because full search was limited too original number of requested rows 2014-05-08 08:50:57 +00:00
Ralf Becker
b111f5005b fixed select-accounts show only part of users, caused by previously trying to extend now used array 2014-05-07 15:51:45 +00:00
Nathan Gray
012b49838c Send value/label pairs to preserve sorting 2014-05-06 20:33:40 +00:00
Ralf Becker
f806bee109 fixed PHP Fatal error: Call to a member function appsession() on a non-object when running as cron-job 2014-05-06 14:41:06 +00:00
Ralf Becker
d5777290ab update from 1.8.007 2014-05-06 07:23:11 +00:00
Ralf Becker
6f98614b15 * Setup: fixed (partially) stalled installation, because caching could not find not yet created configuration 2014-05-05 12:33:33 +00:00
Hadi Nategh
c185974275 Apply overflow:hidden for sidebox in top level, because there might be some apps (eg. AB) which need to have visible overflow over sidebox divs 2014-05-02 10:59:40 +00:00
Ralf Becker
544d57ca46 prevent CSRF for setup and admin site configuration 2014-05-01 06:26:09 +00:00
Nathan Gray
61198e3684 Update gantt code 2014-04-30 20:24:50 +00:00
Nathan Gray
140a0746d1 Make sure top actually has app before calling it. 
Fixes error in calendar where non-list views are still in an iframe, but top window has no app.js
 2014-04-30 16:25:05 +00:00
Nathan Gray
4d016169e7 Precautions for iframes + sidebox 
- Unbind any existing events on existing sidebox, if _init_sidebox() is called again
- Only call _init_sidebox() on top-level window's app.js, fixes some iframe issues with admin
 2014-04-29 16:51:57 +00:00
Nathan Gray
5c19f99d9d Remove no longer needed AJAX call for groups, API now provides them directly to the widget 2014-04-29 16:15:23 +00:00
Klaus Leithoff
7434cd7144 * Mail: fix for messed up signature in some cases; fix for not beeing able to delete/remave an attachment to a new mail that was attached using PRESET methods 2014-04-29 09:53:47 +00:00
Nathan Gray
178fa34031 Implement action system state for trees 2014-04-28 23:11:58 +00:00
Nathan Gray
08ecadcc99 Add support for querying multiple deleted links, same as single 2014-04-28 19:56:21 +00:00
Nathan Gray
21e5eb79dd Fix bug where if no additional apps were requested, no translation was done. 
Was visible in ACL edit dialog.
 2014-04-28 16:17:41 +00:00
Hadi Nategh
c912849bd5 Apply favorites sortable feature to sidebox fav. menu 2014-04-25 07:37:11 +00:00
Ralf Becker
d28315dc9f disable help until content is reworked 2014-04-24 05:56:41 +00:00
Nathan Gray
62686e4b2a Enhancement to r45442 so search options provided as a list are still filtered, but server response is accepted unfiltered. 
Fixes search options provided as a static list were not being filtered.
 2014-04-23 21:42:22 +00:00
Nathan Gray
48fa6611f3 Use a single client-side cache for account selection so we don't have to send it for every widget 2014-04-23 19:00:59 +00:00
Klaus Leithoff
79134d7b12 translations from our translation server 2014-04-23 12:39:12 +00:00
Hadi Nategh
bc33bb842e Fix not showing up sidebox fav items 2014-04-23 12:04:05 +00:00
Hadi Nategh
9805f019a1 * Favorites: Make favorites item sortable and store their orders as user preference 2014-04-23 11:42:48 +00:00
Klaus Leithoff
d1151d876e translations from our translation server 2014-04-23 07:44:08 +00:00
Ralf Becker
f2030c4746 added an implementation of imap_mime_header_decode() using Horde_Mime::decode() with which mail app now seems to work without PHP imap extension 2014-04-19 09:22:59 +00:00
Ralf Becker
54dc648b18 an implementation of imap_rfc822_parse_adrlist and imap_rfc822_write_address, to obsolete imap extension 2014-04-18 12:51:17 +00:00
Hadi Nategh
826e35ffac Get mail print working for idot and pixelegg templates 2014-04-17 15:10:16 +00:00
Ralf Becker
6b7b6fac58 returning false and logging error in ExecMethod, not returning an error-message 2014-04-17 15:07:02 +00:00
Ralf Becker
f641c2cec6 open password in a popup 2014-04-17 07:37:21 +00:00
Ralf Becker
41c1c8c777 keep lines ("\n") in messages 2014-04-17 07:34:59 +00:00
Nathan Gray
c4f56f2c3b New dhtmlxGantt library, and etemplate2 widget to use it (work in progress) 2014-04-16 19:47:29 +00:00
Ralf Becker
3b68b8bff8 need to consider caching when applying setup operations 2014-04-16 17:57:44 +00:00
Hadi Nategh
20db2d8c81 Make sure that the display:none is applied for onlyPrint and noPrint 2014-04-16 17:42:31 +00:00
Ralf Becker
cf6ae6ee77 empty array on insert/update, store as NULL, or if not allowed whatever value NULL is casted to 2014-04-15 08:15:23 +00:00
Klaus Leithoff
04760c6510 rework of translation::replaceTagsCompletley as the prior method removed too much in rare cases 2014-04-14 15:09:07 +00:00
Klaus Leithoff
c68e887a9c remove references to obsolet felamimail stuff 2014-04-10 08:37:12 +00:00
Ralf Becker
af5841a5d1 new 14.1 favicon 2014-04-09 09:35:55 +00:00
Ralf Becker
88ac923de2 switched off permanent error_log 2014-04-09 08:49:07 +00:00
Ralf Becker
0a83c89f9f fixed PHP Fatal error: Undefined class constant "SSL_TLS" 2014-04-09 08:41:57 +00:00
Ralf Becker
370dd66938 fixed send class to use new accounts stuff and not calling (no longer existing) felamimail 2014-04-09 08:22:59 +00:00
Klaus Leithoff
83716092fb translations from our translation server 2014-04-07 06:50:08 +00:00
Ralf Becker
b5818b931f patched PHPMailer to allow to use STARTTLS and TLS version>=1, enhanced wizard to autodetect hosted 1-and-1 domains by using Mozilla ISPDB on MX or domain-part of MX, fixed folder detection to not require folders below INBOX 2014-04-04 08:31:28 +00:00
Ralf Becker
554789e9ff 2 new message types "help" and "info" and displaying now all message types but "success" until next message or user explicitly closes them 2014-04-02 19:02:49 +00:00
Nathan Gray
d3c0314b4d Switch AJAX upload library to Resumable for chunked uploads. 2014-04-01 20:48:40 +00:00
Ralf Becker
6fdf8c98d1 open preferences and ACL in a popup (ACL still needs a little more work: use et2_dialog to add/edit instead of an other popup) 2014-04-01 15:49:08 +00:00
Ralf Becker
d28583a3a4 fix Array has no method match, if egw_framework::message() is called in GET request 2014-04-01 14:16:11 +00:00
Ralf Becker
97dc98453c Horde_iCalendar::newComponent(): include relative from current dir, as we no longer set (old) Horde dir in include path 2014-04-01 13:41:45 +00:00
Ralf Becker
71b97568e5 restore include_path after include of (old) Horde lib/core.php to not conflict wth new Horde code installed in include-path 2014-04-01 12:33:14 +00:00
Ralf Becker
28a819926c fixed fatal error class Horde_String not found when trying to save a new compose with attached vCard as draft 
caused be previous include include of phpgwapi/inc/horde/Horde/String.php via use of vCard and old Horde code uses just String instead of Horde_String as class-name
 2014-04-01 10:37:36 +00:00
Nathan Gray
5be831d9dc Fix broken cache update when deleting a preference. 
Before, it would only store the preference for the updated app instead of all.
 2014-03-31 16:59:01 +00:00
Klaus Leithoff
8d5b0e83a3 translations from our translation server 2014-03-31 12:50:09 +00:00
Ralf Becker
13ad291696 need to init apps too 2014-03-28 13:15:11 +00:00
Ralf Becker
1a1e0fcffc move "nothing to save." to common 2014-03-28 13:05:56 +00:00
Klaus Leithoff
f495345550 add some more examples for imap_rfc822_parse_adrlist 2014-03-28 09:48:09 +00:00
Ralf Becker
115aabf21a fixed error because using (by loading order sometimes) uninitialised class-variable instead of documented and initialies private var 2014-03-28 08:06:30 +00:00
Ralf Becker
ca3f43838c fixed IDE warnings 2014-03-28 07:49:49 +00:00
Klaus Leithoff
5547753502 first step for a workaround when there is no imap extension available; ToDo: implement imap_rfc822_parse_adrlist (used quite often) 2014-03-27 14:03:06 +00:00
Nathan Gray
e7fd500006 Store the jQuery jqXHR request object in the json_request, and return it from sendRequest() so caller can access it, if needed. 2014-03-26 17:53:09 +00:00
Ralf Becker
a4b27d286d * FireFox/all apps: fixed in recent FF version popups opened always in a single popup (overwritting previous opened one) 2014-03-26 10:32:17 +00:00
Ralf Becker
7d7436e54b fixed javascript errors happening if config was not loaded 2014-03-25 12:23:06 +00:00
Ralf Becker
9a10af6fe5 missed to commit parameter to parse CN from url 2014-03-25 12:22:00 +00:00
Ralf Becker
659ad40b50 display old html::form_1button like a button inline-block 2014-03-25 12:17:46 +00:00
Ralf Becker
1007f2ec7e fixed idots not always loaded client-side configuration: now using egw_info[flags][nonavbar] === "popup" to let framework definitly know we dont want a navbar (need to know before navbar is called and can not use true, which is allways set by index.php) 2014-03-25 12:12:00 +00:00
Ralf Becker
fd7a180412 fixed IDE warnings 2014-03-23 08:51:28 +00:00
Ralf Becker
1f0dd46118 as we use now etemplate_new for eTemplate2 and etemplate for old eTemplate class, there is no need to switch etemplate class between new and old 2014-03-23 08:41:31 +00:00
Ralf Becker
fcc1737036 fixed error when filename included non-ascii chars (eg. German umlauts) and added a header with information about author and Github url 2014-03-21 17:11:18 +00:00
Hadi Nategh
9423598d14 Correct css class name used for footer toolbar in dialogs 2014-03-21 10:34:41 +00:00
Ralf Becker
ac18b6cc8d changed et2_core_inheritance.js to implement ClassWithAttributes extending Class from egw_inheritance and changed et2 objects to use ClassWithAttributes when required (also fixed lots of IDE warnings / added docu) 2014-03-20 09:40:37 +00:00