Commit Graph

1568 Commits

Author SHA1 Message Date
nathangray
d4c40e8ce3 Remove check on $GLOBALS['egw_info'] since it's not available at the time 2018-06-06 15:49:14 -06:00
nathangray
0582f2347f Fix a few issues from Scrutinizer
- Remove debug code
- Remove some unused variables
- Add get_ui() to base class that gives error message (should always be a subclass)
2018-06-06 09:54:49 -06:00
nathangray
cc21c823dd Handle an app having more than one etemplate2_before_exec hook 2018-06-05 15:34:54 -06:00
nathangray
847d1c6812 Fix some namespace errors 2018-06-05 15:01:09 -06:00
nathangray
ca32d0bc50 Remove unreachable code 2018-06-05 14:59:05 -06:00
nathangray
71ee883210 Entry sharing - handle files checkbox 2018-06-05 14:31:04 -06:00
nathangray
1bd5927869 Pass action back to popup so it knows what to do 2018-06-05 14:31:04 -06:00
nathangray
a1a7570c86 Add method to get sharing context menu actions 2018-06-05 14:31:04 -06:00
nathangray
4a9df7ef33 Got link creation via context menu working 2018-06-05 14:31:04 -06:00
nathangray
a5f5930064 Check record-level permissions 2018-06-05 14:31:04 -06:00
nathangray
d0a50d8d45 Changes needed to just get the screenshots, much more work needed for proper functionallity since I faked the permissions 2018-06-05 14:31:04 -06:00
Ralf Becker
430368eab9 new JSON response method "message" to call egw.message eg. in a popup, by using the context from the egw.json call 2018-06-05 12:29:51 +02:00
nathangray
6f7050d036 Fix taglists did not always get their options 2018-06-04 14:42:07 -06:00
nathangray
5d65420a03 Limit subjects for filenames to 200 characters to avoid failures 2018-06-04 10:24:15 -06:00
Ralf Becker
84b715c5af * Admin: allow to show last login, IP and password change in list 2018-06-01 14:46:52 +02:00
Hadi Nategh
f479314e06 Allow apps to load JavaScript or CSS files, knowing we're loading the framework or not 2018-06-01 10:37:38 +02:00
nathangray
7843da6e08 Change allowOnMultiple check to use count of selected objects, not count of actionLinks
Allows enabled check functions to call other actions's enabled functions.
2018-05-31 09:19:39 -06:00
nathangray
daa4670f60 Etemplate - missing translations 2018-05-30 13:36:04 -06:00
Hadi Nategh
ea80839b56 Stop autocomplete_url calls for taglist_thumbnail widget 2018-05-29 18:14:42 +02:00
Hadi Nategh
71ae7876d6 Fix namespace issue when calling function 2018-05-29 11:13:12 +02:00
Hadi Nategh
e9f1e8bcad Implement taglist-thumbnail for rest of upload image fields in admin site configuration 2018-05-29 11:05:08 +02:00
Hadi Nategh
b205e2f4a2 Implement new kind of taglist to show thumbnail of set value 2018-05-28 17:41:52 +02:00
Hadi Nategh
6aeb7a5c1e * Admin: Implement new feature to upload multiple images for login background image in site-configuration and show them randomly. 2018-05-28 15:31:32 +02:00
Ralf Becker
90dfe8ec54 copy 17.1 changelog to master to satisfy update checker 2018-05-23 13:16:44 +00:00
Hadi Nategh
ecb8f84afa Add complementary option for app-select widget in order to be able to exclude specific apps from the list 2018-05-22 14:39:15 +02:00
Ralf Becker
54ee23e731 use error-image from api not old phpgwapi 2018-05-20 13:22:46 +02:00
nathangray
5682044227 Fix loader never goes away if you use shift to select just a few rows 2018-05-15 08:43:13 -06:00
nathangray
e8f28b25b2 Allow prompt textbox to expand with the dialog 2018-05-14 15:54:03 -06:00
nathangray
010815ea0f Let et2_dialogs size themselves according to contents unless otherwise specified.
(just dialogs, leave others alone)
2018-05-14 15:52:03 -06:00
nathangray
e0ad35a241 Let et2_dialogs size themselves according to contents unless otherwise specified.
Fixes dialogs too narrow for their title
2018-05-14 15:16:25 -06:00
nathangray
b139583f6a Load filemanager translations for vfsSelectUI 2018-05-14 13:10:10 -06:00
Ralf Becker
e5a7156544 Translations from Ilias Chasapakis 2018-05-14 18:55:38 +02:00
Nathan Gray
3b9e5f672d
Merge pull request #40 from Sportacandy/i18n-japanese
update Japanese language files.
2018-05-14 10:05:44 -06:00
Hadi Nategh
41a983e317 Make a bigger header size assumption (32k) in order to cover importing mails with big headers 2018-05-14 14:54:44 +02:00
U-quokka\komaba
2da4ec91db update Japanese language files. 2018-05-12 08:24:38 +09:00
nathangray
5ceea5b93e Slightly more robust checking for "blank" HTML area in case CKEditor adds some styles 2018-05-11 15:00:12 -06:00
nathangray
820d269e71 Add checks to see if actionManager has been set before using it
Fixes errors in historylog widget
2018-05-11 14:33:17 -06:00
nathangray
8030c477c9 Avoid warning about scheme already registered 2018-05-11 11:25:02 -06:00
nathangray
668a4fede8 Api - Turn on merge for presentations, text templates, spreadsheet templates and presentation templates 2018-05-07 13:34:35 -06:00
nathangray
0dea93ac15 Api - Editing files in shared directories & sharing editable links 2018-05-07 10:40:12 -06:00
Hadi Nategh
f0e7f2aeed Take user's number format into account when set date duration widget. Fixes duration widget doesn't accept "," as decimal separator in Firefox. 2018-05-07 16:57:37 +02:00
nathangray
11cf369540 Turn off debug 2018-05-04 15:07:57 -06:00
nathangray
c8ddbe0680 Some more debug for Travis 2018-05-04 14:36:24 -06:00
nathangray
bd570c3676 - Fix incorrect skipped method
- Move cache clear before logout
2018-05-04 11:36:38 -06:00
nathangray
77a71d1c9c Some more debug for Travis 2018-05-04 09:58:21 -06:00
nathangray
a7a2092a48 Some more debug for Travis 2018-05-04 09:37:53 -06:00
Ralf Becker
ba366467b0 * Admin/Mail: fix saving mail-accounts for multiple accounts 2018-05-04 15:07:06 +02:00
nathangray
fba069e4b6 Some more debug for Travis 2018-05-03 14:31:48 -06:00
nathangray
1ee1c15e75 Turn on debug for sharing tests 2018-05-03 13:59:39 -06:00
nathangray
0d52cc293b Throw an exception (that phpunit can catch) rather than exiting on failure so all tests can get 2018-05-03 10:59:22 -06:00
Ralf Becker
b8e230190f * Mail: fixed equal signs (=) are not displayed in subject
Not sure why, but equal sign was removed unconditional together with other non-printable chars.
Equal sign is now removed from that preg and code is cleaned up to have a single preg removing unprintable chars independet on the function used to decode the header.
2018-05-03 11:01:08 +02:00
nathangray
1022931845 Lock UI with loader while waiting for selected rows query to complete 2018-05-02 14:10:03 -06:00
nathangray
5881ea7bd3 Only reset focused child on first creation, not every action assignment 2018-05-02 14:08:36 -06:00
nathangray
cf4752e8dd Change account filtering to give accounts when asked even if accounts are hidden in preferences 2018-04-26 14:34:09 -06:00
nathangray
6c4ea8cb38 Api - Stop adding calcext:value-type attributes when merging to spreadsheets, they're no longer used and can cause a warning with recent templates 2018-04-23 09:24:49 -06:00
nathangray
48239f3506 Fix mail merge into mail template excluded BCC 2018-04-20 12:00:50 -06:00
Ralf Becker
fa2403f905 * EMail: fix searching in email gives an error
reverting commit 5bd63482ea as the implemented __isset and ArrayAccess interface hide the one implemented by parent Horde_Imap_Client
2018-04-20 10:39:23 +02:00
Ralf Becker
d458b8dd00 Translations from Stefan Unverricht 2018-04-19 17:53:31 +02:00
nathangray
235746e4d6 * Addressbook - Add preference to turn off user groups as distribution lists 2018-04-17 09:35:08 -06:00
Ralf Becker
5bd63482ea implement __isset and ArrayAccess for Imap, to allow eg. to use empty($imap->attribute) 2018-04-17 10:28:37 +02:00
Ralf Becker
648badc44c copy 17.1 changelog to master to satisfy update checker 2018-04-13 14:50:37 +00:00
Ralf Becker
753beb06ac fix PHP 7.2 Warning: The each() function is deprecated 2018-04-13 16:08:37 +02:00
Ralf Becker
77b79f24b7 * Setup: updates from old versions (eg. 1.4 or 1.8) no longer require to update to 14.x and 16.1 first 2018-04-13 13:46:49 +02:00
Ralf Becker
f1437d4ccb fixing a couple more PHP Warning count(): Parameter must be an array or an object that implements Countable 2018-04-13 09:12:26 +02:00
nathangray
5f160114e9 Better error message & correct lost Vfs::$db 2018-04-12 11:23:54 -06:00
Ralf Becker
63d89a3ba0 * Setup/Restore: restore from a other charsets then utf-8 failed 2018-04-12 18:00:27 +02:00
Ralf Becker
81143a0624 * All apps: fixed moving attachments to new entries (without attachments) lost moved file 2018-04-12 15:10:05 +02:00
Ralf Becker
d70304e391 * CalDAV/resources: fix wrong ACL/rights send to clients (PHP warning in log) 2018-04-12 13:03:13 +02:00
Hadi Nategh
835913e454 Fix file upload button does not cover its caption 100% 2018-04-11 16:45:05 +02:00
Hadi Nategh
f2d5687cb2 Add some translations, thanks to Evgen Vodopivec. 2018-04-11 15:59:22 +02:00
Hadi Nategh
c0b5a7c44e Add and fix some translations, thanks to Stefan Unverricht. 2018-04-11 15:19:39 +02:00
Ralf Becker
235821b04a run fastcgi_finish_request also for non-compat install 2018-04-11 15:05:53 +02:00
Ralf Becker
7c1a481d97 fix shutdown functions did not have $GLOBALS[egw] set, caused by session created by MServer 2018-04-11 15:04:48 +02:00
Ralf Becker
ad95a01cec fixing function and test 2018-04-11 14:05:49 +02:00
Ralf Becker
047e68ecd4 limit filesystem depth for managed attachments to gard against infinit recursion 2018-04-11 11:25:53 +02:00
Ralf Becker
bded1bf17e remove 4-byte unicode when cleaning subjects 2018-04-11 11:22:11 +02:00
Ralf Becker
104cae6081 fix smime key got immediatly deleted again 2018-04-10 14:52:14 +02:00
Hadi Nategh
9be52c2d75 * Api: Fix auto-complete password field gets activated even though user hasn't selected it deliberately. 2018-04-10 12:39:27 +02:00
Hadi Nategh
16ab038d4d Fix uploading multiple files does not enable submit buttons after upload is done 2018-04-10 10:17:08 +02:00
Ralf Becker
5b93dd160c fixing not working links stream-wrapper 2018-04-10 08:54:32 +02:00
nathangray
f26b271067 Exclude symlinks from Vfs 2018-04-09 14:02:24 -06:00
nathangray
abc1ccc8f1 Trying to share a symlink actually uses the link target instead 2018-04-09 14:02:24 -06:00
nathangray
c508cd8731 Add tests for trying to share a symlink actually uses the link target 2018-04-09 14:02:24 -06:00
nathangray
cbdbae2f9a Shuffle around some code for better extendability 2018-04-09 14:02:24 -06:00
nathangray
e675ab57d4 Remove unneeded definitions, they're in parent already. 2018-04-09 14:02:24 -06:00
nathangray
e2209b1e57 - Add check to see if merge sqlfs directory is there before creating it
- Add parameter to addFiles() to provide test file content
- Add current user as owner for filesystem mount
2018-04-09 14:02:24 -06:00
Hadi Nategh
5d128cc43b * Addressbook: Fix send all contact's emails/vcards to compose dialog does not work 2018-04-09 16:42:08 +02:00
Ralf Becker
98c7a7af64 fix Scrutinizer issue (seems to be some left over old code) 2018-04-09 16:32:00 +02:00
Ralf Becker
98376b5908 * PHP 7.2: fix several PHP Fatal errors and warnings stalling installation and usage 2018-04-09 16:02:00 +02:00
nathangray
2de26a0f2b Refactor sharing tests to use a base class so Collabora tests can exend it 2018-04-05 08:49:25 -06:00
nathangray
97134373dc Refactor sharing tests to use a base class so Collabora tests can exend it 2018-04-05 08:49:25 -06:00
Hadi Nategh
d9d051a97e Fix move/copy actions in link_to widget vfsSelect try to create not unwanted new symlink 2018-04-04 17:54:30 +02:00
Hadi Nategh
b8fd2f9c97 Fix vfsSelect extra buttons sometimes failing to close the dialog after execution 2018-04-04 17:51:31 +02:00
Hadi Nategh
3327077cec Increase cred_password field size in DB to be able to get fit large smime pkey. 2018-04-04 15:23:56 +02:00
nathangray
6ef00bbf9e Look in action children so placeholder actions can be in sub-levels 2018-04-03 16:24:15 -06:00
nathangray
1cb13a1f13 * Api - Fix references to sub-fields of custom field entries only merged for the first entry of each type 2018-04-03 15:27:09 -06:00
Hadi Nategh
c28e6de2ba Add some translations, thanks to Evgen Vodopivec. 2018-04-03 11:24:42 +02:00
Hadi Nategh
980b4e1ab2 Make sure mail_bo object is there before using it, fixes error "can not call undefined function reopen()" 2018-04-03 10:33:40 +02:00
Hadi Nategh
25a60bf358 Fix translation 2018-03-29 17:43:21 +02:00
nathangray
5b43b1f63c * Etemplate - Stop times from advancing 1 hour shortly after DST 2018-03-29 09:31:45 -06:00
Hadi Nategh
773a9410c5 Make sure we are not disabling submit buttons if upload is not triggered, to avoid disabled submit buttons after failure. 2018-03-28 18:20:11 +02:00
Hadi Nategh
9e7ff133b5 Fix translation 2018-03-28 11:20:36 +02:00
Hadi Nategh
df70d71cc3 Add button_icon new attribute to vfs-select widget and changes link button icon 2018-03-28 11:07:47 +02:00
Hadi Nategh
747d45e47c Set dialog button icons from Api instead of etemplate 2018-03-28 11:05:48 +02:00
Hadi Nategh
b3c26e351c Try to avoid fullwidth for some specific widgets in customfields list 2018-03-27 18:09:35 +02:00
Hadi Nategh
a3c7952925 Make second column of customfields list fullwidth 2018-03-27 15:42:42 +02:00
Hadi Nategh
0930b52934 Add translation for "previous" button in notifications 2018-03-26 17:37:05 +02:00
Hadi Nategh
2491209adf Add some translations, thanks to Stefan Unverricht. 2018-03-26 14:31:39 +02:00
Hadi Nategh
94519b0174 Fix broken priority icons in mail compose 2018-03-26 12:41:37 +02:00
nathangray
8840b5ddc6 Add readable & writable share tests for merge filesystem 2018-03-23 13:01:43 -06:00
nathangray
ff720b097a Add readable & writable share tests for entry filesystem (/apps/infolog/#) 2018-03-23 13:01:43 -06:00
nathangray
33396193ce Add writable check for filesystem:// shares 2018-03-23 13:01:43 -06:00
nathangray
127be25c38 Add explicit check for filesystem file 2018-03-23 13:01:43 -06:00
nathangray
0a7f81a2e2 Api - Sharing from filesystem:// mounts - with tests even 2018-03-23 13:01:43 -06:00
nathangray
eeae245833 Sharing test - refactor for better code, add checks on versioning backend 2018-03-23 13:01:43 -06:00
Hadi Nategh
2943b678bd Fix merge replace placeholders causes huge performance issue. Additionally, fixes the extra $ sign shown up in replaced placeholders. 2018-03-23 16:46:51 +01:00
Ralf Becker
74746a14ef * Sharing/Collabora: fix not working cleanup of temp. files and shares
- 14.x installs had the job created with old class-name egw_sharing
- Wopi shares where never cleaned up, they are now after 3 month
2018-03-22 13:09:59 +01:00
Ralf Becker
5f63892c09 copy 17.1 changelog to master to satisfy update checker 2018-03-21 17:29:30 +00:00
nathangray
e940b283ae WIP - Sharing test - now plays well with others, let's see what Travis says... 2018-03-21 09:44:42 -06:00
Ralf Becker
1d835928d2 new method Api\Framework::getUrl() to get a full / externally usable Url 2018-03-21 12:51:52 +01:00
Ralf Becker
21e123ef84 do NOT use hostname configured in setup, if it is the default localhost
stick with HTTP Host header in that case
2018-03-21 12:49:31 +01:00
Hadi Nategh
045436609d Get Sharing + Collabora into latest 17.1 version 2018-03-21 12:43:25 +01:00
nathangray
097d123a3b WIP - Sharing test - now works on its own, causes other tests to fail though 2018-03-20 15:44:46 -06:00
Hadi Nategh
be4dbc37ae * Fix opening collabora fails from a shared directory:
-we need to have collabora app to avoid CSP error since redirect share-link in collabora should get frame-src. e.g:(Collabora/Src/Ui.php:redirect(Sharing::share2link))
2018-03-16 13:15:45 +01:00
Hadi Nategh
e9b80ecee5 Remove not used csp method 2018-03-16 13:14:16 +01:00
Ralf Becker
f83f03a084 * API: webservice call when password has been changed outside EGroupware to eg. re-encrypting (mail) credentials
Can be used eg. via CURL *after* password has been changed:
echo '<new-password> | curl --user <username> --data-raw '<old-password>' -X POST https://egw.domain.com/egroupware/api/changepwd.php
2018-03-16 11:01:07 +01:00
nathangray
3185acb7b1 Add merge into the list to get /apps working again 2018-03-15 16:55:43 -06:00
nathangray
6be5b8f678 Fix editing a file through gave not found error if the symlink was in a versioned directory 2018-03-15 16:55:43 -06:00
Hadi Nategh
65b2588d65 Add missing negation from commit 600872a4bf 2018-03-15 12:24:19 +01:00
nathangray
b5a4b050d5 WIP - Sharing test - some debug, starting to test writable 2018-03-14 15:14:34 -06:00
Hadi Nategh
600872a4bf An attempt to fix broken collabora sharing which originally got broken by commit f166fbdd46 in order to get mounted template sharing fixed. 2018-03-14 18:58:30 +01:00
Ralf Becker
dcb78d9776 remove due to own table in 17.1 no longer needed migration of (private) custome-fields 2018-03-14 14:50:46 +01:00
Hadi Nategh
eb1eed5b8d Implement new feature for vfs-select widget to accept extra buttons action. Additionally, add extra "copy" and "move" actions to link-to vfs dialog. 2018-03-13 17:43:21 +01:00
Ralf Becker
ddd4127ee7 * AD/LDAP migration: change favorites and index states too 2018-03-12 21:22:12 +01:00
nathangray
357e5a3326 Re-init static streamwrapper, as some of them look at permissions or preferences 2018-03-12 13:51:04 -06:00
Hadi Nategh
5de5c09207 Fix styling of opened popups selector dialog 2018-03-12 17:05:49 +01:00
Hadi Nategh
2d71cdf0f5 Fix tracking of opened popups not working after framework reload 2018-03-12 17:04:17 +01:00
Ralf Becker
c2c1bdb6ad * EMail/Tracker/InfoLog: fix error converting mails by replacing 4-byte utf8 chars
MySQL and MariaDB before 10.1 need 4-byte utf8 chars replaced with our default utf8 charset
(MariaDB 10.1 does the replacement automatic, 10.0 cuts everything off behind and MySQL gives an error)
Changing charset to utf8mb4 requires schema update, shortening of some indexes and probably have negative impact on performace!
		if (substr($this->Type, 0, 5) == 'mysql' && $this->ServerInfo['version'] < 10.1)
		{
			$value = preg_replace('/[\x{10000}-\x{10FFFF}]/u', "\xEF\xBF\xBD", $value);
		}
2018-03-12 14:02:13 +01:00
Hadi Nategh
72bc17abf7 Add a fallback site title to avoid showing undefined as title 2018-03-12 12:16:50 +01:00
Ralf Becker
163c87db82 * Api: use proxy configuration when downloading available tutorial videos 2018-03-12 11:16:57 +01:00
Hadi Nategh
fbf63bf65c Fix tutorials.json url to use https 2018-03-12 11:08:09 +01:00
Ralf Becker
32d10dd243 Fix not working textbox validators containing backslashes
PHP xml parser reads backslashes literal from attributes, 
while JavaScript ones need them escaped (eg. like PHP strings)
-> replace \\ with \ to get following XML working: validator="/^\\d+$"
2018-03-10 17:55:12 +01:00
Ralf Becker
e578e64926 ActiveDirectory: additional allow accountExpires=0 for never expires
(beside attribute is not set or has value 9223372036854775807)
2018-03-09 19:51:49 +01:00
Hadi Nategh
81a79f0da8 WIP framework's popup storage/restore:
- fix typo
2018-03-09 17:53:36 +01:00
Hadi Nategh
b2526b340f WIP framework's popup storage/restore:
- Add missing template
2018-03-09 17:51:29 +01:00
Hadi Nategh
a8e10cdc64 WIP framework's popup storage/restore:
- Keep tracking of popup's window object and restore it when needed
- Implement a method to check an already opened popup and execute a method in the selected popup context
- Fix vcard import into opened compose windows not working
2018-03-09 17:48:09 +01:00
nathangray
223b55d631 Api - Allow sharing to use Collabora to open files instead of downloading 2018-03-07 11:29:00 -07:00
Hadi Nategh
d2859d5cee * Mail: Fix "tel:" href links wrongly get denied by mail compose 2018-03-05 18:16:12 +01:00
Hadi Nategh
53b97078ad Fix mail with a bold digits gets removed from text part 2018-03-05 17:31:47 +01:00
Hadi Nategh
dca72ebd9c Fix broken sharing caused by commit 89a8e6f448 2018-03-05 11:13:54 +01:00