extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-26 18:33:50 +01:00
Code Issues Packages Projects Releases Wiki Activity
0788fe5e72
nushell/crates/nu-command/tests/commands/for_.rs

31 lines
665 B
Rust
Raw Normal View History

in for, loop, while, auto print final value in each iteration (#7433) # Description Fixes: #7404 Fixes: #7402 ## About change In `eval_block`, all pipelines(or called statements?) result will be printed except the last one, the last one is returned by `eval_block` function. So if we want to print the last statement in eval block, we just need to print that value. # User-Facing Changes ### for ``` ❯ for _ in 1..2 { echo "a" } a a ``` ### while ``` ❯ mut x = 1; while $x < 3 { $x = $x + 1; echo bb; } bb bb ``` ### loop ``` ❯ mut total = 0; loop { ∙ if $total > 1 { ∙ break ∙ } else { ∙ $total += 1 ∙ } ∙ echo 3 ∙ } 3 3 ``` # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-11 17:46:03 +01:00
use nu_test_support::nu;
#[test]
Remove autoprinting of loop block values (#8618) # Description This removes autoprinting the final value of a loop, much in the same spirit as not autoprinting values at the end of statements. As we fix these corner cases, it becomes more consistent that to print to the screen in a script, you use the `print` command. This gives a noticeable performance improvement as a bonus. Before: ``` C:\Source\nushell〉 for x in 1..10 { $x } 1 2 3 4 5 6 7 8 9 10 ``` Now: ``` C:\Source\nushell〉 for x in 1..10 { $x } C:\Source\nushell〉 ``` # User-Facing Changes **BREAKING CHANGE** Loops like `for`, `loop`, and `while` will no longer automatically print loop values to the screen. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-26 01:23:54 +01:00
fn for_doesnt_auto_print_in_each_iteration() {
in for, loop, while, auto print final value in each iteration (#7433) # Description Fixes: #7404 Fixes: #7402 ## About change In `eval_block`, all pipelines(or called statements?) result will be printed except the last one, the last one is returned by `eval_block` function. So if we want to print the last statement in eval block, we just need to print that value. # User-Facing Changes ### for ``` ❯ for _ in 1..2 { echo "a" } a a ``` ### while ``` ❯ mut x = 1; while $x < 3 { $x = $x + 1; echo bb; } bb bb ``` ### loop ``` ❯ mut total = 0; loop { ∙ if $total > 1 { ∙ break ∙ } else { ∙ $total += 1 ∙ } ∙ echo 3 ∙ } 3 3 ``` # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-11 17:46:03 +01:00
let actual = nu!(
cwd: ".",
r#"
for i in 1..2 {
echo 1
}"#
);
Remove autoprinting of loop block values (#8618) # Description This removes autoprinting the final value of a loop, much in the same spirit as not autoprinting values at the end of statements. As we fix these corner cases, it becomes more consistent that to print to the screen in a script, you use the `print` command. This gives a noticeable performance improvement as a bonus. Before: ``` C:\Source\nushell〉 for x in 1..10 { $x } 1 2 3 4 5 6 7 8 9 10 ``` Now: ``` C:\Source\nushell〉 for x in 1..10 { $x } C:\Source\nushell〉 ``` # User-Facing Changes **BREAKING CHANGE** Loops like `for`, `loop`, and `while` will no longer automatically print loop values to the screen. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-26 01:23:54 +01:00
// Make sure we don't see any of these values in the output
// As we do not auto-print loops anymore
assert!(!actual.out.contains('1'));
in for, loop, while, auto print final value in each iteration (#7433) # Description Fixes: #7404 Fixes: #7402 ## About change In `eval_block`, all pipelines(or called statements?) result will be printed except the last one, the last one is returned by `eval_block` function. So if we want to print the last statement in eval block, we just need to print that value. # User-Facing Changes ### for ``` ❯ for _ in 1..2 { echo "a" } a a ``` ### while ``` ❯ mut x = 1; while $x < 3 { $x = $x + 1; echo bb; } bb bb ``` ### loop ``` ❯ mut total = 0; loop { ∙ if $total > 1 { ∙ break ∙ } else { ∙ $total += 1 ∙ } ∙ echo 3 ∙ } 3 3 ``` # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-11 17:46:03 +01:00
}
break `for`, `loop`, `while` execution when external command runs to failed (#7475) Fixes: #7467 # User-Facing Changes ## for ``` ❯ for i in 1..2 { echo 1; ^false } 1 ``` ## loop ``` ❯ loop { echo bb; ^false } bb ``` ## while ``` ❯ mut x = 1; while $x < 3 { $x = $x + 1; echo bb; ^false } bb ```
2022-12-14 16:20:18 +01:00
#[test]
fn for_break_on_external_failed() {
let actual = nu!(
cwd: ".",
r#"
for i in 1..2 {
Disable pipeline echo (#8292) # Description Change behavior of block evaluation to not print result of intermediate commands. Previously result of every but last pipeline in a block was printed to stdout, and last one was returned ![image](https://user-images.githubusercontent.com/17511668/222550110-3f62fbed-432c-4b46-b9b1-4cb45a1f893e.png) With this change results of intermediate pipelines are discarded after they finish and the last one is returned as before: ![image](https://user-images.githubusercontent.com/17511668/222550346-f1e74f80-f6b6-4aa3-98d6-888ea4cb4915.png) Now one should use `print` explicitly to print something to stdout ![image](https://user-images.githubusercontent.com/17511668/222923955-fda0d77b-41b4-4f91-a80f-12b0a1880c05.png) **Note, that this behavior is not limited to functions!** The scope of this change are all blocks. All of the below are executed as blocks and thus exibited this behavior in the same way: ![image](https://user-images.githubusercontent.com/17511668/222924062-342c15de-4273-4bf5-8b39-fe6e3aa96076.png) With this change outputs for all types of blocks are cleaned: ![image](https://user-images.githubusercontent.com/17511668/222924118-7d51c27e-04bb-43e5-8efe-38b484683bfe.png) # User-Facing Changes All types of blocks (function bodies, closures, `if` branches, `for` and `loop` bodies e.t.c.) no longer print result of intermediate pipelines. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-16 23:53:46 +01:00
print 1;
break `for`, `loop`, `while` execution when external command runs to failed (#7475) Fixes: #7467 # User-Facing Changes ## for ``` ❯ for i in 1..2 { echo 1; ^false } 1 ``` ## loop ``` ❯ loop { echo bb; ^false } bb ``` ## while ``` ❯ mut x = 1; while $x < 3 { $x = $x + 1; echo bb; ^false } bb ```
2022-12-14 16:20:18 +01:00
nu --testbin fail
}"#
);
Fix typos and use more idiomatic assertions (#7755) I have changed `assert!(a == b)` calls to `assert_eq!(a, b)`, which give better error messages. Similarly for `assert!(a != b)` and `assert_ne!(a, b)`. Basically all instances were comparing primitives (string slices or integers), so there is no loss of generality from special-case macros, I have also fixed a number of typos in comments, variable names, and a few user-facing messages.
2023-01-15 03:03:32 +01:00
// Note: nu! macro auto replace "\n" and "\r\n" with ""
break `for`, `loop`, `while` execution when external command runs to failed (#7475) Fixes: #7467 # User-Facing Changes ## for ``` ❯ for i in 1..2 { echo 1; ^false } 1 ``` ## loop ``` ❯ loop { echo bb; ^false } bb ``` ## while ``` ❯ mut x = 1; while $x < 3 { $x = $x + 1; echo bb; ^false } bb ```
2022-12-14 16:20:18 +01:00
// so our output will be `1`
assert_eq!(actual.out, "1");
}
Reference in New Issue Copy Permalink