mirror of
https://github.com/nushell/nushell.git
synced 2024-11-26 10:23:52 +01:00
5b03bca138
# Description
This removes autoprinting the final value of a loop, much in the same
spirit as not autoprinting values at the end of statements. As we fix
these corner cases, it becomes more consistent that to print to the
screen in a script, you use the `print` command.
This gives a noticeable performance improvement as a bonus.
Before:
```
C:\Source\nushell〉 for x in 1..10 { $x }
1
2
3
4
5
6
7
8
9
10
```
Now:
```
C:\Source\nushell〉 for x in 1..10 { $x }
C:\Source\nushell〉
```
# User-Facing Changes
**BREAKING CHANGE**
Loops like `for`, `loop`, and `while` will no longer automatically print
loop values to the screen.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
31 lines
665 B
Rust
31 lines
665 B
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn for_doesnt_auto_print_in_each_iteration() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
for i in 1..2 {
|
|
echo 1
|
|
}"#
|
|
);
|
|
// Make sure we don't see any of these values in the output
|
|
// As we do not auto-print loops anymore
|
|
assert!(!actual.out.contains('1'));
|
|
}
|
|
|
|
#[test]
|
|
fn for_break_on_external_failed() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
for i in 1..2 {
|
|
print 1;
|
|
nu --testbin fail
|
|
}"#
|
|
);
|
|
// Note: nu! macro auto replace "\n" and "\r\n" with ""
|
|
// so our output will be `1`
|
|
assert_eq!(actual.out, "1");
|
|
}
|