mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 16:33:37 +01:00
2ee2370a71
# Description In bash when a program crashes, it prints the reason for what happened: ``` $ ./division_by_zero Floating point exception (core dumped) $ ./segfault Segmentation fault (core dumped) ``` Nushell always prints the same thing in this case: ``` > ./division_by_zero nushell: oops, process './division_by_zero' core dumped Error: nu:🐚:external_command (link) # etc.. ``` This PR adds more detailed error printing, like in bash: ``` > ./division_by_zero Floating point exception: oops, process './division_by_zero' core dumped Error: nu:🐚:external_command (link) # etc.. ``` I made this message format as an example: ``` Floating point exception: oops, process './division_by_zero' core dumped ``` Instead of `nushell:` it writes a meaningful message, but I can change this format as per the suggestions. I tested the change only on linux, but it should work on other unix systems. # User-Facing Changes The error message only. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| nu_plugin_custom_values | ||
| nu_plugin_example | ||
| nu_plugin_gstat | ||
| nu_plugin_inc | ||
| nu_plugin_python | ||
| nu_plugin_query | ||
| nu-cli | ||
| nu-color-config | ||
| nu-command | ||
| nu-engine | ||
| nu-explore | ||
| nu-glob | ||
| nu-json | ||
| nu-parser | ||
| nu-path | ||
| nu-plugin | ||
| nu-pretty-hex | ||
| nu-protocol | ||
| nu-system | ||
| nu-table | ||
| nu-term-grid | ||
| nu-test-support | ||
| nu-utils | ||
| README.md | ||
Nushell core libraries and plugins
These sub-crates form both the foundation for Nu and a set of plugins which extend Nu with additional functionality.
Foundational libraries are split into two kinds of crates:
- Core crates - those crates that work together to build the Nushell language engine
- Support crates - a set of crates that support the engine with additional features like JSON support, ANSI support, and more.
Plugins are likewise also split into two types:
- Core plugins - plugins that provide part of the default experience of Nu, including access to the system properties, processes, and web-connectivity features.
- Extra plugins - these plugins run a wide range of different capabilities like working with different file types, charting, viewing binary data, and more.