mirror of
https://github.com/nushell/nushell.git
synced 2024-10-16 23:33:49 +02:00
2ee2370a71
# Description In bash when a program crashes, it prints the reason for what happened: ``` $ ./division_by_zero Floating point exception (core dumped) $ ./segfault Segmentation fault (core dumped) ``` Nushell always prints the same thing in this case: ``` > ./division_by_zero nushell: oops, process './division_by_zero' core dumped Error: nu:🐚:external_command (link) # etc.. ``` This PR adds more detailed error printing, like in bash: ``` > ./division_by_zero Floating point exception: oops, process './division_by_zero' core dumped Error: nu:🐚:external_command (link) # etc.. ``` I made this message format as an example: ``` Floating point exception: oops, process './division_by_zero' core dumped ``` Instead of `nushell:` it writes a meaningful message, but I can change this format as per the suggestions. I tested the change only on linux, but it should work on other unix systems. # User-Facing Changes The error message only. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| assets | ||
| proptest-regressions/format_conversions | ||
| src | ||
| tests | ||
| build.rs | ||
| Cargo.toml | ||
| LICENSE | ||