Commit Graph

1240 Commits

Author SHA1 Message Date
Jonathan Barratt
5acd891c68
refactor all handling of attached files
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
2016-12-08 19:47:20 +07:00
Alex Seeholzer
142c2367d2 Merge pull request #459 from reduxionist/flinz_tests/get-email
Expands testing of get_email
2016-12-08 09:39:20 +01:00
Pawel M
d76fa2c71e PY3 support and msgNum error solved in process_queue method 2016-12-08 09:32:04 +01:00
Jonathan Barratt
391e35065c
per code review, update safe IP addr/port constants, remove commented-out code, and add comments to unexplained code 2016-12-06 09:55:22 +07:00
Jonathan Barratt
e8d0c5b2c7
implement mocked pop3 and imap tests for get_email
also update travis to latest django patch releases
2016-12-02 19:04:52 +07:00
Alex Seeholzer
4a7286f371
added requirements for testing 2016-12-02 17:40:46 +07:00
Alex Seeholzer
399b0901f6
newer version of tests 2016-12-02 17:40:46 +07:00
Alex Seeholzer
72a99cc99a
Moved existing test for local mailbox into generation of tests for matrix of email configurations; 2016-12-02 17:40:46 +07:00
Jonathan Barratt
1f63691dbe Merge pull request #457 from reduxionist/hotfix/456/ticket_from_message-missing-arg
hotfix for #456:  patch calls to ticket_from_message
2016-11-29 00:56:22 +07:00
Jonathan Barratt
3cfa371199
hotfix for #456: patch calls to ticket_from_message
add logger arg where missing in get_email
2016-11-29 00:46:42 +07:00
Jonathan Barratt
cac3267e82 Merge pull request #454 from reduxionist/prune-legacy-code
Prune legacy code
2016-11-21 20:32:35 +07:00
Jonathan Barratt
45a8ce98ac Merge pull request #455 from gwasser/ticket_list_view
Use HTML5 table ordering based on Unix epoch
2016-11-21 20:29:13 +07:00
Garret Wassermann
04f27fdcff Use HTML5 table ordering based on Unix epoch 2016-11-21 00:12:24 -05:00
Jonathan Barratt
7738bba2ab
remove special-case imports for legacy versions
standardise use, or avoidance, of timezone, template from_string, and Context
2016-11-21 10:16:03 +07:00
Jonathan Barratt
b4aa7767bd
drop quicktest compatibility for unsupported django versions 2016-11-21 09:31:40 +07:00
Jonathan Barratt
73fd081b48 Merge pull request #453 from willstott101/stringio_six
Use Django's six module for StringIO imports.
2016-11-17 19:11:37 +07:00
Will Stott
f34696df8d Use Django's six module for StringIO imports. 2016-11-17 11:25:46 +00:00
Jonathan Barratt
07f7489e2c Merge pull request #452 from gwasser/get_email
Ensure that local files are deleted after processing
2016-11-12 12:02:48 +07:00
Garret Wassermann
97a24fbe22
Ensure that local files are deleted after processing, and add some information about it to the install.rst documentation 2016-11-12 11:32:04 +07:00
Jonathan Barratt
fc5e5180b0 Merge pull request #451 from reduxionist/bugfix/non-namespaced-reverse-url-lookups
convert reverse-URL lookups to helpdesk namespace
2016-11-11 14:45:41 +07:00
Jonathan Barratt
ebfea8274d
convert reverse-URL lookups to helpdesk namespace
in views.staff, this fixes:
-run_report's no-tickets-found redirect to report_index
-del_attachment's redirect to parent ticket view after deletion
2016-11-11 10:31:37 +07:00
Jonathan Barratt
7eceb35d43 Merge pull request #447 from alexbarcelo/drop_south
Drop south_migrations
2016-11-03 18:56:06 +07:00
Alex Barcelo
e511aed934 removing leftover references to south_migrations folder 2016-11-02 17:24:05 +01:00
Alex Barcelo
b0b68b9541 drop south_migrations folder 2016-11-02 17:22:47 +01:00
Jonathan Barratt
dcbe9d1fed Merge pull request #446 from flinz/patches/open-file
patch: implicit closing of open files
2016-11-02 12:52:36 +07:00
Jonathan Barratt
0126b0b712 Merge pull request #445 from flinz/patches/travis-versionswitch
updated travis 3.4 target to latest 3.4.4
2016-11-02 12:44:19 +07:00
Alex Seeholzer
62163eaf0e patch: implicit closing of open files; 2016-11-01 15:03:51 +01:00
Alex Seeholzer
bc212a3dd1 updated travis target to latest python, ensuring latest mock patches are usable.
before, travis randomly resolved "3.4" into 3.4.2 or 3.4.4.
2016-11-01 15:01:50 +01:00
Jonathan Barratt
d54017f69f Merge pull request #419 from gwasser/bootstrap
New Bootstrap-based UI
2016-10-31 14:42:19 +07:00
Garret Wassermann
2a7d82413b Miscellaneous improvements from review of #419 2016-10-31 02:57:08 -04:00
Garret Wassermann
37b9d332de Fix some more missing namespace references for login and kb_category 2016-10-31 02:19:41 -04:00
Garret Wassermann
c74208325b Removed test_per_queue_staff_permission assertion, report_index no longer returns unassigned_tickets 2016-10-31 02:06:49 -04:00
Garret Wassermann
26f4987726 Fix a missing helpdesk namespace reference in report_index.html 2016-10-31 01:42:45 -04:00
Garret Wassermann
194641613c Sync with upstream, merged in AbstractForm with bootstrap class 2016-10-31 01:38:49 -04:00
Jonathan Barratt
5b5de2061f Merge pull request #443 from alexbarcelo/form_dry
Clean and avoid "repeating yourself" on forms.py
2016-10-31 10:42:05 +07:00
Alex Barcelo
abd6fdcebe simplifying if-case branches on CustomFieldMixin 2016-10-30 20:53:18 +01:00
Alex Barcelo
cce12181f0 refactoring single-letter variables into better names 2016-10-30 20:43:05 +01:00
Alex Barcelo
681a1893bd missed a refactoring 2016-10-30 08:42:05 +01:00
Alex Barcelo
d8d10fae90 DRY in *TicketForm --by adding an Abstrat~ one 2016-10-30 08:39:17 +01:00
Alex Barcelo
bea6fbf75a fixing a deprecated usage, and adding a minor branch control 2016-10-30 08:38:49 +01:00
Garret Wassermann
adf2b16c2c Fix namespaces in test 2016-10-29 04:33:27 -04:00
Garret Wassermann
dc25164304 More PEP8 changes (hopefully last) 2016-10-29 04:27:29 -04:00
Garret Wassermann
4cf46156f1 More PEP8 changes 2016-10-29 04:20:16 -04:00
Garret Wassermann
1f1d477a35 Sync again with master 0.2 2016-10-29 04:11:41 -04:00
Garret Wassermann
d791700582 Fix PEP8 errors 2016-10-29 04:08:57 -04:00
Jonathan Barratt
cbbad8d370 Merge pull request #442 from reduxionist/pr/420-merge-corrections
cleanup build-breaking whitespace merge errors
2016-10-29 15:04:39 +07:00
Jonathan Barratt
28308d19fb
cleanup build-breaking whitespace merge errors 2016-10-29 14:59:14 +07:00
Garret Wassermann
cad174468b Sync with namespace and other v0.2 changes 2016-10-29 03:47:15 -04:00
Jonathan Barratt
26c0f2e59f Merge pull request #441 from alexbarcelo/api-prune
Remove all the deprecated API related files and references
2016-10-29 14:12:31 +07:00
Alex Barcelo
53ed0d3a2c Remove all the deprecated API related files and references 2016-10-29 08:50:13 +02:00