Christopher Broderick
d65b103cc4
Merge pull request #1139 from timthelion/webhooks
...
Refactor update tickets view
2023-11-15 00:54:32 +00:00
Timothy Hobbs
b0ef6a5484
Fix #1138 by calling update_ticket directly from non-update views
2023-11-14 21:47:12 +01:00
Timothy Hobbs
ade4c3115e
Move update ticket logic out of staff.py
2023-11-14 21:17:37 +01:00
Timothy Hobbs
6cd5522099
Move to ruff, its faster & catches more
2023-11-14 20:37:05 +01:00
Timothy Hobbs
21513d4524
Fix security problem with update_ticket view
...
@martin-marty Introduced a security flaw in this commit.
ecefd5e407
#
By extracting authentication logic for the update_ticket view to a new function
and mixing the return types. This function returns both a Ticket object and a
login redirect. This is simply non-sensical and fails to actually login-redirect
non-authenticated users.
2023-11-11 22:26:19 +01:00
Benbb96
770cdc77b8
Add more tests
2023-05-01 22:54:41 +02:00
Benbb96
3b55f37fb5
Fix isort issues
2023-04-30 04:13:50 +02:00
Benbb96
3235333873
Drag & drop on ticket checklist tasks edition page + Use an empty form in order to better generate new task row dynamically
2023-04-30 03:56:42 +02:00
Benbb96
ef88a2ee8a
Better workflow for creating new ticket checklist, into a modal
2023-04-30 03:11:27 +02:00
Benbb96
11b2b36dd2
Allow updating task state when writing a ticket follow-up
2023-04-30 02:18:16 +02:00
Benbb96
308f69a03b
CRUD Checklist Template
2023-04-30 01:15:05 +02:00
Benbb96
af1ba5f205
Create a page to edit checklist name and tasks + another page for deletion
2023-04-29 00:24:06 +02:00
Benbb96
b8d06a0fb1
Show a form to create a new checklist, with the possibility to use a preset template
2023-04-23 00:36:10 +02:00
Christopher Broderick
1b3d97e183
Fix incorrectly removed time import
2023-04-03 10:49:01 +01:00
Christopher Broderick
7ff870ec88
Merge branch 'main' into #1075---add-options-for-date-and-datetime-input-in-ticket-view
2023-03-26 00:46:07 +00:00
Christopher Broderick
9e71fc8467
Remove redundant import
2023-03-25 13:21:27 +00:00
finnertysea
21ccc83d69
#1075 - make view agnostic to format of incoming due date
2023-03-17 13:12:03 -07:00
Christopher Broderick
930fc71d8b
Merge branch 'main' into fix-warnings
2023-03-10 23:52:46 +00:00
finnertysea
5279180221
Bug fix #1066 - modified import order to placate isort
2023-01-24 13:36:18 -05:00
finnertysea
71ff0aa6d5
Bug fix - detected due date change when no change was made
2023-01-20 10:53:35 -05:00
Benbb96
238dd8d3d5
Fix import order
2022-08-15 20:21:19 +02:00
Benbb96
bc3d89b555
Fix PyCharm warnings in staff.py
2022-08-15 20:15:02 +02:00
Martin Whitehouse
72392a3f50
Add update_summary_tables
helper function
...
Reduces complexity of 'run_report' and handles updating summary table in
own function
2022-07-25 04:44:46 +02:00
Martin Whitehouse
205c69b539
Add get_report_table_and_totals
helper function
...
Extracts a large portion of run_report handling
2022-07-25 04:41:01 +02:00
Martin Whitehouse
b1bf2cab46
Add get_report_queryset_or_redirect
helper
...
Gets required objects or redirects
2022-07-25 04:35:49 +02:00
Martin Whitehouse
50bd72ac7a
Move import to top
2022-07-25 04:31:17 +02:00
Martin Whitehouse
d858c40416
Add check_redirect_on_user_query
helper function
...
Extract the checking for a redirect to reduce complexity
2022-07-25 04:29:43 +02:00
Martin Whitehouse
f89f5b91da
Reinstate changes, fixed missing update
2022-07-25 04:23:03 +02:00
Martin Whitehouse
40a243c23b
Revert changes, updating objects missed somewhere
2022-07-25 04:15:53 +02:00
Martin Whitehouse
a248181857
Add redirect_from_chosen_ticket
helper function
...
Moves the whole handling to own block, reducing complexity greatly.
2022-07-25 04:08:16 +02:00
Martin Whitehouse
eb11c4fe0e
Rename ticket_attriubtes
to upper, module level constant.
2022-07-25 04:03:12 +02:00
Martin Whitehouse
a783156b61
Add merge_ticket_values
helper
...
Extract a large portion of code from `merge_tickets`
2022-07-25 04:01:27 +02:00
Martin Whitehouse
b326103d82
Fix spacing
2022-07-25 03:48:06 +02:00
Martin Whitehouse
45e47846fe
py3.8 annotation fix
2022-07-25 03:45:36 +02:00
Martin Whitehouse
7b4d53cfc0
Fix 'list' annoation for py3.8
2022-07-25 03:44:04 +02:00
Martin Whitehouse
749ebbe16b
Fix annotations for py3.8
2022-07-25 03:42:16 +02:00
Martin Whitehouse
595dae1cf7
Add get_template_staff_and_template_cc
function
...
Furhter reduxes complexity by combining creation of templates
2022-07-25 03:38:16 +02:00
Martin Whitehouse
256af24daa
Comment function
2022-07-25 03:34:03 +02:00
Martin Whitehouse
a2f33c9799
Add add_staff_subscription
helper
...
Further reduces complexity by checking for subscription in helper
function
2022-07-25 03:32:45 +02:00
Martin Whitehouse
f678c63496
Add update_messages_sent_to_by_public_and_status
helper function
...
Handles updating ticket and sending ticket reply
2022-07-25 03:30:07 +02:00
Martin Whitehouse
fe619b5ff2
Combine conditionals to single line
2022-07-25 03:22:59 +02:00
Martin Whitehouse
f815ebbb5c
Add get_time_spent_from_request
helper
...
Extracts further code
2022-07-25 03:17:10 +02:00
Martin Whitehouse
9294eca5d6
Add get_and_set_ticket_status
helper
...
Extracts some futher code from `update_ticket`
2022-07-25 03:11:30 +02:00
Martin Whitehouse
ecefd5e407
Extract the due_date
to helper function
2022-07-25 03:01:50 +02:00
Martin Whitehouse
574395ee28
Easy pickings
...
Simple code violations of reserved symbols etc.
2022-07-25 02:46:33 +02:00
Martin Whitehouse
44f068d1b8
re-apply formatting
2022-07-22 03:30:35 +02:00
Martin Whitehouse
25542f929e
Initial isort configuration
...
Will fail build if imports are not sorted correctly
2022-07-22 03:26:41 +02:00
Martin Whitehouse
b586442508
Merge branch 'stable' of
...
git@github.com:superuser-marty-me-uk/django-helpdesk.git into formatting
2022-07-13 10:22:11 +02:00
Martin Whitehouse
aa876f8016
pycodestyle formatting
2022-07-12 12:34:19 +02:00
Benbb96
9dbe283dd4
Create FollowUpAttachment serializer + handle attachment in TicketSerializer and in FollowUpSerializer in order to attach directly one or multiple attachments to the created followup.
2022-06-24 23:45:26 +02:00