Commit Graph

13324 Commits

Author SHA1 Message Date
Klaus Leithoff
cb8cd0f3e6 when having multiple lines descriptions in contacts or calendar, these are not correctly encoded in vcard.
The problem seems to be line [784] of trunk/phpgwapi/inc/horde/Horde/iCalendar.php
$value = str_replace($this->_newline, '\n', $value);
When removing this line, the description value is correct on the client.

I could not find any sideffects during my tests, if some clients have
problems with this, I assume this would then have to be fixed at a higher
level, because the current state with this line just causes broken output.

From wikipedia regarding Linebreaks in QuotedPrintable:
If the data being encoded contains meaningful line breaks, they must be encoded as an ASCII CR LF sequence, not as their original byte values

Vcard extract without the reported line code:
DESCRIPTION;ENCODING=QUOTED-PRINTABLE:Desc 1=0D=0ADesk 2=0D=0A=0D=0A

Vcard extract with the reported line of code
DESCRIPTION;ENCODING=QUOTED-PRINTABLE:Desc 1\nDesk 2\n\n

pointed out by Philip Herbert. Carl Knauber Holding GmbH & Co KG
2008-08-04 08:42:19 +00:00
Klaus Leithoff
68ba92e1b9 Some clients do not use uppercase charaters to name PRIVATE/PUBLIC class.
To be more fault tolerant change line 687 of trunk/addressbook/inc/class.addressbook_vcal.inc.php
this was pointed out by Philip Herbert. Carl Knauber Holding GmbH & Co KG
2008-08-04 08:24:34 +00:00
Klaus Leithoff
16cb2097fc Some Devices (Nokia S60) ignore the entire vcard, if the vcard contains
formal error.

This breaks sync for single contacts from egw to client.
example: photo in addressbook without blank line after the property value.
This way the devices are not compliant with RFC2426 (Vcard Version 3)
5. Differences From vCard v2.1
[...]
. Inline binary content must be "B" encoded and folded. A blank
line after the encoded binary content is no longer required.
[...]
This was pointed out by Philip Herbert. Carl Knauber Holding GmbH & Co KG
2008-08-04 08:18:49 +00:00
Oscar Manuel Gómez Senovilla
f98569ee85 Updated russian translation (#1658) and some spanish updates 2008-08-03 19:07:15 +00:00
Oscar Manuel Gómez Senovilla
a8865daa7d tracker #1664 2008-08-03 19:01:49 +00:00
Ralf Becker
e3c60d8243 "only check if $name is a string" 2008-08-01 15:36:31 +00:00
Ralf Becker
3fa1859f70 "- input fields can be now also made readony by specifying the parent ($readonlys['set'] make eg. $readonlys['set[whatever]'] r/o)
- allow extensions to re-enable readonly widgets by setting $cell[readonly] = false "
2008-08-01 15:34:13 +00:00
Klaus Leithoff
b82110bcd7 further improvement for the import of Mail messages 2008-08-01 13:03:17 +00:00
Klaus Leithoff
402c0308dd -missing german translations
#Usability feature: Link to access/create a User assigned emailadmin Profile when in edit/view mode of an existing user
2008-08-01 09:54:12 +00:00
Klaus Leithoff
a4d50d7f30 trying to improve linebreak behavior while importing mails. 2008-07-30 14:19:31 +00:00
Ralf Becker
d90ce31491 hook to intercept session creation 2008-07-30 13:29:19 +00:00
Ralf Becker
32eb1bafa6 "fix for bug #1643: %t in phone numbers (telephony intergration) does not work" 2008-07-30 11:08:51 +00:00
Ralf Becker
46eee6b895 re-added accidently removed delegation tab template from infolog.edit 2008-07-30 08:48:59 +00:00
Ralf Becker
31e49bef04 Moved translation of 'site configuration' to phpgwapi/common to not
translate it in every app (differently)
2008-07-30 08:39:56 +00:00
Ralf Becker
72e99175e9 added version 2008-07-30 06:49:55 +00:00
Ralf Becker
a17e5ebad0 fixed layout of infolog edit: addr is now width:100%; instead of fixed width 2008-07-30 06:31:43 +00:00
Ralf Becker
161fa364b9 fixed layout: location is now width:100% instead of fixed width 2008-07-30 05:56:19 +00:00
Oscar Manuel Gómez Senovilla
77f63b4c00 updated russian translation 2008-07-29 20:40:02 +00:00
Ralf Becker
ac38fe77ff "fixed problem of under some conditions not loaded adodb classes for php4-restore" 2008-07-29 12:13:07 +00:00
Ralf Becker
57293bca75 "fixed wrong display of email-type participants (caused by class rename)" 2008-07-29 05:13:45 +00:00
Ralf Becker
2e7d0b551b "quitend error_log on each xajax request" 2008-07-28 09:22:52 +00:00
Ralf Becker
5b705e6bc6 fixed bugs report by Frank Becker on the german list and some more I
noticed while working on it:
- memory size error, when renaming a file after posting the list (eg.
  clicking on home icon)
- renaming (moving) one file on an existing filename, put the file in an
  inaccessible state
- renaming more then once, did not work
--> ToDo: add some ajax to notify the user, when he tries to overwrite
an other file while renaming one
2008-07-27 18:58:41 +00:00
Ralf Becker
dc287964f7 "phpDoc header and more docu" 2008-07-27 12:56:50 +00:00
Ralf Becker
b40382df80 exception handler for xajax and ability to use static methods as ajax callbacks eg. filemanager_ui::ajax_check_something 2008-07-27 12:48:39 +00:00
Oscar Manuel Gómez Senovilla
241e844f4b Resulting lang files after applying the "Search for new phrases" in translation tools for every app 2008-07-26 21:59:22 +00:00
Oscar Manuel Gómez Senovilla
6f203e3932 trackers #1616, 1617, 1618 and 1629 for italian updates 2008-07-25 22:20:21 +00:00
Oscar Manuel Gómez Senovilla
8913855001 tracker #1476 2008-07-25 22:15:31 +00:00
Oscar Manuel Gómez Senovilla
e6a0bc30a9 tracker #1511 2008-07-25 21:22:37 +00:00
Oscar Manuel Gómez Senovilla
4fdb9b1d1a tracker #1630 2008-07-25 18:20:50 +00:00
Stefan Becker
134692b51c fixed that IE 6 Bug, that selectboxes are shown in the left Menu with a frame workaround. Sponsored by Karl Knauber Holding 2008-07-25 14:48:06 +00:00
Stefan Becker
c9fda6abcf "fix for IE 6 pngbugfix, some images where not displayed after turning on the Bugfix. E. g. in the clander oder infolog. Sponsored by Karl Knauber Holding " 2008-07-25 10:24:20 +00:00
Klaus Leithoff
42e4f1facd egw_async: handling the ##last-check-run## problem during restore. The line will be skipped. 2008-07-25 09:37:15 +00:00
Oscar Manuel Gómez Senovilla
bf36524009 Updated spanish translation for trunk 2008-07-25 08:07:35 +00:00
Oscar Manuel Gómez Senovilla
6826e1df64 rest of adding new translations 2008-07-24 19:31:09 +00:00
Oscar Manuel Gómez Senovilla
753c766eff Pending translations for trunk 2008-07-24 19:00:41 +00:00
Klaus Leithoff
832d65ab70 fix for a PHP Warning: preg_split() [<a href='function.preg-split'>function.preg-split</a>]: Compilation failed: nothing to repeat at offset 14 in
phpgwapi/inc/class.egw_index.inc.php on line 183
not sure why it occurs, but the fix works around it and seems not to break anything
2008-07-24 12:56:11 +00:00
Stefan Becker
49897197c0 "hack to display the js calendar under IE 6 and PNGfix" 2008-07-24 08:48:50 +00:00
Stefan Becker
1999c90df4 "fix for JScalendar, to bei schown, under under the Menupoint \" Grant Access\"" 2008-07-23 13:59:16 +00:00
Stefan Becker
9facd0bfdf "Patch for IE 6/7 that you can add comments to the Link widget by onclick" 2008-07-22 14:16:28 +00:00
Stefan Becker
1569576645 "Patch for IE 6/7 checking if the Calendar Element is loaded" 2008-07-22 14:04:23 +00:00
Ralf Becker
8d2816b0bb first try for a 1.6 prerelease package 2008-07-22 12:02:33 +00:00
Stefan Becker
ffd9cdd47f "Patch for IE 6/7 style setting for textarea (default Style), description Tab is not too Big and geratingscrollbars " 2008-07-22 11:55:54 +00:00
Ralf Becker
eadc29037e moved icalsrv.php handler to icalsrv (contrib) application 2008-07-22 11:34:32 +00:00
Stefan Becker
3485f97e90 "Patch for IE 6/7 PNG bugfix on setup template" 2008-07-22 09:26:27 +00:00
Stefan Becker
3e758e812c "Patch for IE 6/7 and Listview custom search for selected range" 2008-07-22 08:54:40 +00:00
Stefan Becker
33fa5ed18a "patch for custum search working with IE 6/7" 2008-07-21 15:40:14 +00:00
Stefan Becker
8727151c9a PNG Bugfix for IE 6 is working on IE 7 (browsercheck) 2008-07-21 14:40:54 +00:00
Stefan Becker
dfa524628c patch for better Layout of the template on IE 6/7 2008-07-21 12:42:37 +00:00
Ralf Becker
16c5ce05ac fixed "There's NO ADOdb object!" error in DB backup/restore via
setup-cli.php
2008-07-21 09:40:58 +00:00
Ralf Becker
667eb5eb82 "order participants addtionally by status: unknow first, then tentative, accepted and last declined" 2008-07-18 11:36:09 +00:00