finnertysea
5279180221
Bug fix #1066 - modified import order to placate isort
2023-01-24 13:36:18 -05:00
finnertysea
71ff0aa6d5
Bug fix - detected due date change when no change was made
2023-01-20 10:53:35 -05:00
Rafael Reuber
2cca51085f
Removes unused function query_to_dict
2023-01-05 22:30:57 +00:00
Benbb96
64788938b4
Catch exception on an attachment individually in order to allow valid extension to be processed.
2022-10-10 21:57:56 +02:00
Benbb96
b3edba3fc5
Fix #1054
2022-10-09 23:05:16 +02:00
chrisbroderick
9e3a3abcf1
Fix import sorting
2022-09-08 23:40:49 +01:00
chrisbroderick
8d7ba415fa
Fix formatting per flake8
2022-09-08 22:11:24 +01:00
chrisbroderick
eca2255f56
Test for filename using diaretics
2022-09-08 10:05:09 +01:00
chrisbroderick
357241e269
Refactor to make the methods more generic and able to be used to build
...
any kind of email
2022-09-07 08:48:32 +01:00
chrisbroderick
572ffd5acf
Handle ignored emails explicitly using exceptions.
...
Support the flag on IgnoreEmail model to control deleting the email if
ignored.
2022-09-06 19:40:35 +01:00
chrisbroderick
23c3b72a43
Refactor object_from_message to make it more testable and fix some bugs.
...
Extract the from email using the email library instead of pre-decoding
which exposes the comma separator causing the email address to be
extracted incorrectly if the real name contains a comma.
Raise an exception when a message to be ignored is detected to process
ignored messages explicitly.
2022-09-04 22:01:32 +01:00
chrisbroderick
e1085cb370
Custom exception to handle ignored messages explicitly.
2022-09-04 21:53:08 +01:00
chrisbroderick
4e001c7f15
test utility methods to simplify more complex tests
2022-09-02 22:11:19 +01:00
Benbb96
238dd8d3d5
Fix import order
2022-08-15 20:21:19 +02:00
Benbb96
bc3d89b555
Fix PyCharm warnings in staff.py
2022-08-15 20:15:02 +02:00
Alex
3a13bbfeef
Fix. Add test markdown and rewrite for last markdown is working
2022-08-08 20:20:00 +07:00
Alex
cf5be66fae
Fix. Fix problem wich version package in requirements and add test markdown and rewrite for new markdown
2022-08-06 18:34:16 +07:00
Alex
a28569a984
Fix. Fix problem wich version package in requirements and add test markdown
2022-07-27 19:58:39 +07:00
Martin Whitehouse
72392a3f50
Add update_summary_tables helper function
...
Reduces complexity of 'run_report' and handles updating summary table in
own function
2022-07-25 04:44:46 +02:00
Martin Whitehouse
205c69b539
Add get_report_table_and_totals helper function
...
Extracts a large portion of run_report handling
2022-07-25 04:41:01 +02:00
Martin Whitehouse
b1bf2cab46
Add get_report_queryset_or_redirect helper
...
Gets required objects or redirects
2022-07-25 04:35:49 +02:00
Martin Whitehouse
50bd72ac7a
Move import to top
2022-07-25 04:31:17 +02:00
Martin Whitehouse
d858c40416
Add check_redirect_on_user_query helper function
...
Extract the checking for a redirect to reduce complexity
2022-07-25 04:29:43 +02:00
Martin Whitehouse
f89f5b91da
Reinstate changes, fixed missing update
2022-07-25 04:23:03 +02:00
Martin Whitehouse
40a243c23b
Revert changes, updating objects missed somewhere
2022-07-25 04:15:53 +02:00
Martin Whitehouse
a248181857
Add redirect_from_chosen_ticket helper function
...
Moves the whole handling to own block, reducing complexity greatly.
2022-07-25 04:08:16 +02:00
Martin Whitehouse
eb11c4fe0e
Rename ticket_attriubtes to upper, module level constant.
2022-07-25 04:03:12 +02:00
Martin Whitehouse
a783156b61
Add merge_ticket_values helper
...
Extract a large portion of code from `merge_tickets`
2022-07-25 04:01:27 +02:00
Martin Whitehouse
bed7f0e493
Add default value property to TicketCustomField
...
Property of the model, so add it there to keep consistency
2022-07-25 04:00:57 +02:00
Martin Whitehouse
46f8e9d21f
Clear error
...
Use.objects.get causes undefined variable when using get_user_model
2022-07-25 03:52:58 +02:00
Martin Whitehouse
1468982043
Remove unused variables, extract correct index
2022-07-25 03:50:49 +02:00
Martin Whitehouse
b326103d82
Fix spacing
2022-07-25 03:48:06 +02:00
Martin Whitehouse
57cd2f1471
Remove annoation for py3.8
2022-07-25 03:47:57 +02:00
Martin Whitehouse
45e47846fe
py3.8 annotation fix
2022-07-25 03:45:36 +02:00
Martin Whitehouse
7b4d53cfc0
Fix 'list' annoation for py3.8
2022-07-25 03:44:04 +02:00
Martin Whitehouse
749ebbe16b
Fix annotations for py3.8
2022-07-25 03:42:16 +02:00
Martin Whitehouse
595dae1cf7
Add get_template_staff_and_template_cc function
...
Furhter reduxes complexity by combining creation of templates
2022-07-25 03:38:16 +02:00
Martin Whitehouse
256af24daa
Comment function
2022-07-25 03:34:03 +02:00
Martin Whitehouse
a2f33c9799
Add add_staff_subscription helper
...
Further reduces complexity by checking for subscription in helper
function
2022-07-25 03:32:45 +02:00
Martin Whitehouse
f678c63496
Add update_messages_sent_to_by_public_and_status helper function
...
Handles updating ticket and sending ticket reply
2022-07-25 03:30:07 +02:00
Martin Whitehouse
fe619b5ff2
Combine conditionals to single line
2022-07-25 03:22:59 +02:00
Martin Whitehouse
f815ebbb5c
Add get_time_spent_from_request helper
...
Extracts further code
2022-07-25 03:17:10 +02:00
Martin Whitehouse
9294eca5d6
Add get_and_set_ticket_status helper
...
Extracts some futher code from `update_ticket`
2022-07-25 03:11:30 +02:00
Martin Whitehouse
ecefd5e407
Extract the due_date to helper function
2022-07-25 03:01:50 +02:00
Martin Whitehouse
574395ee28
Easy pickings
...
Simple code violations of reserved symbols etc.
2022-07-25 02:46:33 +02:00
Martin Whitehouse
8d63d65a7d
Removed encoding to 'utf-8', breaks tests.
...
This needs to be looked into further.
2022-07-25 02:41:40 +02:00
Martin Whitehouse
4e2b7deefb
Reduces complexity of object_from_message
...
Helper functions created to help break up the flow
2022-07-25 02:22:32 +02:00
Martin Whitehouse
a5e74d6449
Extract getting ticket_id from subject to helper function
2022-07-25 01:56:13 +02:00
Martin Whitehouse
283f052c0e
Annotate function signature
2022-07-25 01:47:00 +02:00
Martin Whitehouse
80f4152301
Simplify return statement
...
Rename `ticket` to `ticket_id` for clarity
2022-07-25 01:43:43 +02:00
Martin Whitehouse
0b1de1eead
Removed unused import
...
Result of previous code removal
2022-07-25 01:23:12 +02:00
Martin Whitehouse
fe28c2f540
Merge branch 'unstable' of git@github.com:martin-marty/django-helpdesk.git into 1039-complexity-reduction
2022-07-25 01:22:11 +02:00
Martin Whitehouse
1ac78955c0
Removed notifications_to_be_sent list
...
The whole loop appeared to be doing nothing other than appending email
addresses to a list, which was never used.
2022-07-25 01:22:05 +02:00
Martin Whitehouse
0f0b0a5995
Remove left over 'cc' code
2022-07-22 16:27:38 +02:00
Martin Whitehouse
44f068d1b8
re-apply formatting
2022-07-22 03:30:35 +02:00
Martin Whitehouse
25542f929e
Initial isort configuration
...
Will fail build if imports are not sorted correctly
2022-07-22 03:26:41 +02:00
Martin Whitehouse
e2a8b974dd
Removed unused imports, format long line
2022-07-22 01:21:25 +02:00
Martin Whitehouse
fb21d9bcdc
Check for model enabled before registering
2022-07-22 01:20:10 +02:00
Martin Whitehouse
280462c2fe
Remove 'f-string', no place holders present
2022-07-22 01:18:45 +02:00
Martin Whitehouse
fa91620bf9
EscapeHtml.extendMarkdown disabled
...
Updated markdown caused failures.
Not sure what is going on with this class, 0 comments :-(
If someone could give me a hint as to what this is trying to achieve, I
can investigate further
2022-07-20 16:32:51 +02:00
Martin Whitehouse
844c317e19
Formatting fixes
2022-07-14 09:19:11 +02:00
Benbb96
e47170858e
Create two new tests for ticket followups and followup attachments + adapt one test (needed to use freezegun)
2022-06-30 23:43:22 +02:00
Benbb96
9dbe283dd4
Create FollowUpAttachment serializer + handle attachment in TicketSerializer and in FollowUpSerializer in order to attach directly one or multiple attachments to the created followup.
2022-06-24 23:45:26 +02:00
Benbb96
bd413837c2
Create FollowUp serializer with its Viewset and add it in urls
2022-06-24 22:22:08 +02:00
Martin Whitehouse
6d1d5d82b3
Skip failing tests
...
Object not available for patching
2022-06-20 18:20:01 +02:00
Martin Whitehouse
2c1466e01e
Disable failing checks
...
Iterating over a cc_list and comparing to the outbox list will not work.
Need to re-work to ensure indexes match up
2022-06-20 18:19:44 +02:00
Martin Whitehouse
8118fd83b7
Fix autofill utf-8 test
2022-06-20 18:03:39 +02:00
Martin Whitehouse
dd7ef6f0ed
Fix autofill test
2022-06-20 17:50:49 +02:00
Martin Whitehouse
0e571ddebc
Fix url regex
2022-06-20 17:36:40 +02:00
Martin Whitehouse
670ae9d0a5
Fix password assignments
2022-06-20 17:36:32 +02:00
Martin Whitehouse
f18531acb0
Fix url check
2022-06-20 17:35:40 +02:00
Martin Whitehouse
db358ceeaf
Set due date as member and use throughout
2022-06-20 17:35:28 +02:00
Martin Whitehouse
437d5b81c4
Fix failing tests
2022-06-20 17:26:52 +02:00
Martin Whitehouse
93bb43bf1d
Remove mock
...
Can't import model until the test body
2022-06-20 16:58:43 +02:00
Martin Whitehouse
2910664950
Fix path for tests
2022-06-20 16:34:32 +02:00
Martin Whitehouse
6a1f430496
Missing import
2022-06-20 16:10:55 +02:00
Martin Whitehouse
41d7caace4
Fix spacing issues
...
{% if saved_query==q %} was causing a parse error. White space around
equality
2022-06-20 16:08:05 +02:00
Martin Whitehouse
e438f6b4db
Fix references to 'url'
...
Change to 're_path'
2022-06-20 14:39:04 +02:00
Garret Wassermann
ee42ba48a3
Merge in bugfixes from 0.3.5
2022-06-12 03:00:25 -04:00
Daniele Scasciafratte
67949e83f9
added permission classes
2022-05-04 18:51:02 +02:00
Daniele Scasciafratte
25db44ba5e
feat(rest): create user
2022-05-02 17:27:25 +02:00
Garret Wassermann
b8511dd70b
Fix conflicts for Django 4 support
2022-04-23 02:23:51 -04:00
Garret Wassermann
3ed6c68046
Update to 0.3.4 bugfix release
2022-04-23 02:06:35 -04:00
Garret Wassermann
5e8f5fed62
Fixing some unit tests
2022-04-22 14:52:51 -04:00
Garret Wassermann
fcab3506b0
Merge branch 'stable' into new-option-fields
2022-04-22 06:32:32 -04:00
Daniele Scasciafratte
8d626cfd5f
feat(fields): hide column for time spent
2022-04-20 17:30:55 +02:00
Daniele Scasciafratte
6d5c81ea14
feat(fields): hide column for KB item, https://github.com/django-helpdesk/django-helpdesk/pull/1003
2022-04-20 16:54:17 +02:00
Daniele Scasciafratte
9bd4eb19bc
feat(fields): no dependencies
2022-04-20 16:44:48 +02:00
Daniele Scasciafratte
de9c5a709e
feat(fields): no time spent
2022-04-20 16:36:37 +02:00
Daniele Scasciafratte
26c6a778ec
feat(ticket): disable timeline
2022-04-15 18:51:02 +02:00
Daniele Scasciafratte
5792587e3e
feat(ticket): disable timeline
2022-04-15 18:48:21 +02:00
Benbb96
dc60d8a7f9
Add setting HELPDESK_ACTIVATE_API_ENDPOINT and document it
2022-04-15 00:05:51 +02:00
Benbb96
3e331c08fb
Try to fix other tests
2022-04-14 23:45:19 +02:00
Benbb96
9320df0268
Fix a bug I introduced in earlier commit + fix one test
2022-04-14 23:30:42 +02:00
Benbb96
7e5ff05b02
Update documentation
2022-04-11 00:23:22 +02:00
Benbb96
31acfb11dd
Add tests for the API
2022-04-11 00:16:54 +02:00
Benbb96
5701bf0229
Fix a bug with get_choices function which doesn't return anything if empty_selection_list is False
2022-04-11 00:15:48 +02:00
Benbb96
dbcd0fe6b4
Remove last_escalation field from serializer since it is a non-editable field
2022-04-11 00:15:11 +02:00
Benbb96
88b234958a
Fix a bug when assigned_to or merged_to were not passed in body
2022-04-07 00:42:12 +02:00
Nick McCullum
55c638aeef
some more template improvements
2022-04-04 15:27:50 -03:00
