Commit Graph

2568 Commits

Author SHA1 Message Date
Georg Lehner
7bf21685b3 Fix: remove unused and undefined context variable 2024-06-08 12:52:10 +02:00
Georg Lehner
bc764b50c1 Fix: itertools are superseded by NotIn ORM operator 2024-06-08 12:12:56 +02:00
Georg Lehner
25c36a6f5c Restrict ticket selection for dependencies and parents
When adding a dependent or parent ticket, the choice field in the
ticket selection form excludes:

- All existing dependencies of the current ticket.
- All existing parent tickets of the current ticket.
- The current ticket itself.

The first two prevent immediate circular references: A dependency
cannot be a parent and vice versa.  Deeper circular references are
not covered by this: a ticket can still be its own grandchild.

They also prevent current behavior of throwing an `IntegrityException`
when selecting a dependency or parent.

The third one prevents also a quirky behavior: until now, specifying the
ticket itself as parent or dependency just does not save the
dependency and does not issue a warning either.
2024-06-08 12:11:01 +02:00
Georg Lehner
b52ab69c42 Order dependend ticket with NotIn ORM operator instead of itertools 2024-06-08 12:00:43 +02:00
Georg Lehner
887483a6d6 Remove status from ticket heading, since it is now shown in the description table 2024-06-06 00:34:28 +02:00
Georg Lehner
d7afcb6578 Reformat Resolves/Depends lists into tables. Allow adding/deleting of parent tickets 2024-06-06 00:28:36 +02:00
Georg Lehner
5b2441b994 Add list of 'parent' tickets to ticket description table
'parent' tickets are all tickets on which the current ticket depends.

The parent tickets can only be resolved if the current tickets is closed.

This patch splits the current |Dependencies|Total time spent| table row
in two rows.  The table layout is now

    |Status |Total time spent|
    |Depends|Resolves        |

Status and Total time only have one line.  Status was chosen as filler
field, because I believe it should be moved out of the title to reduce
visual distraction.

Depends and Resolve will have a variable number of lines and are closely
related.

Depends was chosen instead of "Dependencies", to indicate directly what
the listed tickets do and because it is shorter.

The commit also simplifies the wording of the tooltips and harmonizes with
the other tooltips in the same table: It indicates directly what happens
when the button is clicked (or touched!).

Notes:

- The complete row could be omitted if now Depends or Resolves exists for
  a ticket.  This would reduce visual distraction but was not implemented
  because it could lead to misled expectations.
- No button for removing/adding parent tickets was added. If considered
  important this can be added any time.  Currently a user has to go to
  the parent ticket and delete the dependency (easy) or remember the ticket
  id/title, search for the parent and add the ticket as dependency (difficult)
2024-05-17 12:34:40 +02:00
Christopher Broderick
c77bb30035
Merge pull request #1182 from jorge-leon/graceful-datatable-errors
Pop up a nice error message when an AJAX request fails. Closes #1179
2024-05-15 09:08:07 +01:00
Georg Lehner
95755125fb Add datatables error message to error pop up 2024-05-14 21:46:18 +02:00
Georg Lehner
25f338cfc5 Pop up a nice error message when an AJAX request fails. 2024-05-11 16:41:01 +02:00
Christopher Broderick
d7b75087dc
Merge pull request #1181 from django-helpdesk/fix-logout
Fix logout in Django 5 with POST action instead of GET
2024-05-09 22:22:45 +01:00
Benbb96
306a01a8b4
add login again button and reformat logged_out.html 2024-05-08 16:25:49 +02:00
Benbb96
ef5a43a3e2
remove unused import 2024-05-08 16:05:22 +02:00
Benbb96
7643e18acc
Explain login/logout redirect settings in documentation 2024-05-08 16:01:26 +02:00
Benbb96
485ac1294c
remove next_page parameter and show how to set LOGOUT_REDIRECT_URL in settings 2024-05-08 15:47:14 +02:00
Benbb96
b1316214c7
replace hardcoded path ../ to reverse_lazy URL 2024-05-07 15:50:51 +02:00
Benbb96
2d561d15c8
fix design on login/logout button when not staff 2024-05-07 15:43:12 +02:00
Benbb96
6fe5f1681f
fix logout in Django 5 with POST action instead of GET 2024-05-07 14:54:05 +02:00
Christopher Broderick
ba9935e792
Merge pull request #1178 from ilikerobots/main
repair pre-set replies broken due to raw url parameter name mismatch
2024-05-06 15:42:12 +01:00
ilikerobots
89ab173034 update raw parameter name to match view 2024-05-03 10:38:17 +03:00
Christopher Broderick
dce3c0c73f
Merge pull request #1173 from django-helpdesk/new_release_1.2.0
Update release number for package creation
2024-04-29 21:27:58 +01:00
Christopher Broderick
6456a1f951
Merge pull request #1161 from timthelion/view_protectors
Add some convenient functions for protecting views in custom installations
2024-04-29 21:26:57 +01:00
Christopher Broderick
a6bb99f1e8
Merge branch 'main' into view_protectors 2024-04-29 21:25:36 +01:00
Christopher Broderick
83a8092399
Merge branch 'main' into new_release_1.2.0 2024-04-24 20:53:43 +01:00
Christopher Broderick
044cd4c50d Update release number for package creation 2024-04-24 19:23:16 +01:00
Christopher Broderick
dba8a889a3
Merge pull request #1172 from jorge-leon/fix-public-view-and-context-help-urls
FIX: replace hardcoded urls with Django generated ones. Fixes #1171
2024-04-24 19:05:07 +01:00
Christopher Broderick
1ddb2a271c
Merge pull request #1169 from samsplunks/signal
Emit a signal when a ticket is updated
2024-04-24 18:18:24 +01:00
Timothy Hobbs
8f9d385e10
Merge branch 'main' into view_protectors 2024-04-23 21:29:38 +02:00
Timothy Hobbs
ebbbcdb2aa Deprecate VALID_EXTENSIONS properly 2024-04-22 18:38:59 +02:00
Georg Lehner
c723873d83 FIX: replace hardcoded urls with Django generated ones.
The My Tickets view generated ticket urls with a '/view' string prefix. This
is replaced by proper Django URL resolution.

The public and staff ticket view used a '../../' string prefix which brakes in
the public ticket view. They are both replaced with proper Django URL resolution.
2024-04-17 21:17:41 +02:00
Sam Splunks
750b216d66
Update docs/webhooks.rst with django signals link
Co-authored-by: Benbb96 <Benbb96@users.noreply.github.com>
2024-04-17 14:34:47 +02:00
Sam Splunks
361ba84295
Updated signals code 2024-04-17 14:31:57 +02:00
Sam Splunks
16bb4d46f1
Update webhooks documentation 2024-04-17 14:24:15 +02:00
Sam Splunks
2f26180451 Update webhooks documentation with signals info 2024-04-17 12:20:27 +00:00
Sam Splunks
8541acd49d Updated comment 2024-04-17 10:21:02 +00:00
Sam Splunks
2fc95d165a new_ticket_done signal emitted through email 2024-04-17 10:19:50 +00:00
Sam Splunks
81f9226f7c Removed unused webhooks import 2024-04-17 10:09:15 +00:00
Sam Splunks
9a6939b564 Attach send_new_ticket_webhook to the new_ticket_done signal 2024-04-17 10:02:44 +00:00
Sam Splunks
c6cad5f702 Removed unused webhooks import 2024-04-16 08:52:22 +00:00
Sam Splunks
c0ee8e0847 Use update_ticket mechanism in email.py 2024-04-16 08:49:11 +00:00
Sam Splunks
79b7ce9650 notify_followup_webhooks used in email, so moving signal triggering code 2024-04-16 08:42:03 +00:00
Sam Splunks
0e96909f43 Removed unused TichetChange import 2024-04-16 08:36:29 +00:00
Sam Splunks
08ed2a5035 Adding receiver import 2024-04-16 08:34:03 +00:00
Sam Splunks
ebb9a4d50d Make update_ticket_done signal trigger notify_followup_webhooks 2024-04-16 08:23:06 +00:00
Sam Splunks
2499f81d4d Add a signal when the ticket upate is done (every related instance created and updated) 2024-04-16 08:04:01 +00:00
Sam Splunks
8fffae343c Update TicketChange creation code 2024-04-16 07:58:33 +00:00
Benbb96
9f7c18e507
Merge pull request #1167 from samsplunks/followup_queue_change
Allow to track queue change in follow-ups
2024-04-12 15:07:26 +02:00
Sam Splunks
a775622521
Create ticket change through instance relationship
Co-authored-by: Benbb96 <Benbb96@users.noreply.github.com>
2024-04-12 10:44:56 +02:00
Sam Splunks
5b39c9aeeb
Update forloop for queues with explicit variable names in ticket template
Co-authored-by: Benbb96 <Benbb96@users.noreply.github.com>
2024-04-12 10:39:58 +02:00
Sam Splunks
62ef86a047 Settings assertion values in hours 2024-04-09 13:45:41 +00:00