Garret Wassermann
e3a378625c
Add test with django template tag in email body, to ensure we test for and fix #72 in future changes
2017-04-16 05:10:51 -04:00
Garret Wassermann
8e1a6b30fa
Fix encoding first before splitting strings, so it works on Python 2
2017-04-16 04:59:57 -04:00
Garret Wassermann
7b8426596f
Separate out the CC test from plain test so we're testing both possibilities (with and without a CC)
2017-04-16 04:51:46 -04:00
Garret Wassermann
49aac657a9
PEP8 fixups
2017-04-16 04:44:16 -04:00
Garret Wassermann
b2ac1fd3a5
#95 : save CC'd emails on a comment to the Ticket for future correspondence, set to view only initially, and update tests for CC
2017-04-16 04:19:17 -04:00
Garret Wassermann
01e87f2cb8
#72 : Prevent django template tags from being executed in followup comments
2017-04-16 03:24:39 -04:00
Will Stott
fb0782294e
Don't show error on initial get.
2017-04-13 11:36:38 +01:00
Will Stott
b7a97183cb
Never return None from views.public.create_ticket
...
Would create a 500 when user omitted their email. Only a partial improve. Added a TODO: as this view still breaks if passing non-numeric characters to the ID.
I assume this needs a full overhaul really.
2017-04-13 11:30:29 +01:00
Jonathan Barratt
d843a21ea7
Merge branch 'master' into master
2017-04-06 08:21:43 +07:00
Garret Wassermann
9531b9649a
Fix errors in Python 2, used six to workaround encoding weirdness, all tests pass on both Py2/3
2017-04-03 02:52:49 -04:00
Garret Wassermann
5ec985af9b
Add explicit encoding hint to top of file to allow Python 2 to read file with Unicode characters, in accordance with PEP-263
2017-04-03 02:34:54 -04:00
Garret Wassermann
0fb9094d01
Remove line for PEP8
2017-04-03 02:29:28 -04:00
Garret Wassermann
f43ef69ec1
Add a MIME multipart email test for get_email
2017-04-03 02:19:29 -04:00
Garret Wassermann
74a7afadb9
Update get_email test to use unicode characters; seem to have found an encoding errory in get_email, provided a fix that satisfies test
2017-04-03 01:53:25 -04:00
Garret Wassermann
194082750d
Merge remote-tracking branch 'upstream/master' into 487_new_test
2017-03-31 14:29:19 -04:00
Jonathan Barratt
19799572c9
Merge pull request #499 from Yuego/master
...
Migration added
2017-03-31 19:51:58 +07:00
Jonathan Barratt
6deb0caf96
Merge pull request #497 from gwasser/update_es_MX
...
Update es_MX translations
2017-03-31 19:37:18 +07:00
Yuego [Home]
5629276050
Migration added
2017-03-26 10:24:32 +04:00
Garret Wassermann
d3c713333d
Update es_MX translations on behalf of @andresf01, for #496
2017-03-17 10:00:37 -04:00
pprolancer
babc7586cf
- issue #493 : internal error 500 on save query
...
https://github.com/django-helpdesk/django-helpdesk/issues/493
2017-03-12 19:58:57 +03:30
Yuego [Home]
d8ff278697
Russian translation update
2017-03-08 23:05:26 +04:00
Yuego [Home]
dfdb12e354
Fix link translation
2017-03-08 23:01:31 +04:00
Garret Wassermann
6fec1015c3
Work in progress on unicode chars
2017-02-15 18:51:20 -05:00
Michael Huang
b263b22cca
Wrap message.encode() in conditional for Python 2
2017-02-14 14:58:16 -08:00
Michael Huang
f16a196c69
Fix logout URL
2017-02-14 14:38:48 -08:00
Michael Huang
dc851fc557
Force message to be unicode to avoid encoding issues
2017-02-14 12:34:53 -08:00
Garret Wassermann
2164c3bc4d
Change queue permission_name from 50 chars to 72 chars ( #484 )
...
* Change queue permission_name from 50 chars to 72 chars to accomodate slug + prepended text, to resolve #483
2017-02-12 17:33:53 +07:00
Jonathan Barratt
fe92880928
do not throw exceptions for invalid/non-UTF8 IMAP content
2017-01-14 01:25:43 +07:00
Jonathan Barratt
b5feeb7ee9
Make SOCKS-proxy support global for all queues under Py3
...
Python 2 retains per-queue SOCKS-proxy support, but this is simplest fix until someone needs it for Python 3.
2017-01-14 01:25:17 +07:00
Alex Seeholzer
a2315eb0c4
added pep8 fix and missing migration
2017-01-13 17:39:56 +01:00
Alex Seeholzer
645f196848
Added tests covering the usersettings_helpdesk occurrences
2017-01-13 17:37:10 +01:00
Alex Seeholzer
4e018db5a6
Added unique related_name “usersetttings_helpdesk” for the one-to-one relation to User in UserSettings.
2017-01-13 15:22:41 +01:00
Jonathan Barratt
2f66c50320
Make helpdesk work in apps with their own queue models
...
To avoid returning multiple content types when creating custom permissions, use ContentType.objects.get_for_model to lookup the content type for helpdesk.models.queue.
2017-01-13 17:52:29 +07:00
User
787c3aa4f5
make old subject_part pretty
2017-01-09 00:30:36 +01:00
User
b7baf2bf56
fix for error:BadHeaderError: Header values can't contain newlines when running get_email. caused by subject_part being repeated, but second time doesnt strip newlines
2017-01-08 18:52:24 +01:00
Jonathan Barratt
8a2e6c087e
hotfix for #470 : datatables error on empty ticket list
...
handle the no tickets match query case with js rather than python for DataTables compatibility
2017-01-03 00:42:12 +07:00
Pawel M
8f751691a4
whitespace removed
2016-12-16 10:38:15 +01:00
Pawel M
97b3444a92
if files condition restored
2016-12-16 10:36:00 +01:00
Pawel M
fc0ae58420
lib as reduxionist + read binary mode
2016-12-16 10:30:50 +01:00
Garret Wassermann
3c6b522464
Fix form end tag placement, and remove duplicate unstyled query box
2016-12-13 23:45:43 -05:00
Pawel M
df7920cd2e
missing imports added
2016-12-14 00:04:38 +01:00
Pawel M
3a372fbcb4
White space removed
2016-12-13 23:40:36 +01:00
Pawel M
f5b68772cf
Downloaded attachment was not decoded and additionally encoded by default django method (its size after download is bigger than originally attached file). This is the reason why it is illegible
2016-12-13 23:31:26 +01:00
Pawel M
9939f62ebd
Attachement should be readed in binary mode ... and attached as payload (regarding docs)
2016-12-13 23:28:16 +01:00
Pawel M
e7c4131ed7
Attachement should be readed in binary mode ... and attached as payload (regarding docs)
2016-12-13 22:43:14 +01:00
Jonathan Barratt
8dbd54ac16
stop corrupting binary attachments when delivering them by email
...
We accomplish this by attching files to out-bound mail diffrently
depending on the versino of Python in effect. In Py2 we can read
the files ourseles and the standard library will still
be able to use the text we pass as if it were bytes. Under Py3,
however, email.message will complain if it doesn't get to decode
the bytes itself, so instead of attaching the contents directly
we just pass the path to the file as a string instead. Unfortunately,
Django 1.8 does not work with this Python 3 approach, due to its
not yet having reverted to the newly improved standard library's
mail-message implementation, and thus requiring us to know more
about the character-encoding/mimetype of the attachment than I've
been able to gather cleanly by this point.
2016-12-13 19:41:13 +07:00
Jonathan Barratt
e82e5fcd5f
urlquote email address when used as get query param
2016-12-11 06:20:03 +07:00
Pawel M
94c39cba69
solves Title changed to . (Null title) on failed attachment upload.
2016-12-11 06:00:05 +07:00
Jonathan Barratt
5acd891c68
refactor all handling of attached files
...
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
2016-12-08 19:47:20 +07:00
Jonathan Barratt
391e35065c
per code review, update safe IP addr/port constants, remove commented-out code, and add comments to unexplained code
2016-12-06 09:55:22 +07:00
Jonathan Barratt
e8d0c5b2c7
implement mocked pop3 and imap tests for get_email
...
also update travis to latest django patch releases
2016-12-02 19:04:52 +07:00
Alex Seeholzer
399b0901f6
newer version of tests
2016-12-02 17:40:46 +07:00
Alex Seeholzer
72a99cc99a
Moved existing test for local mailbox into generation of tests for matrix of email configurations;
2016-12-02 17:40:46 +07:00
Jonathan Barratt
3cfa371199
hotfix for #456 : patch calls to ticket_from_message
...
add logger arg where missing in get_email
2016-11-29 00:46:42 +07:00
Jonathan Barratt
cac3267e82
Merge pull request #454 from reduxionist/prune-legacy-code
...
Prune legacy code
2016-11-21 20:32:35 +07:00
Jonathan Barratt
45a8ce98ac
Merge pull request #455 from gwasser/ticket_list_view
...
Use HTML5 table ordering based on Unix epoch
2016-11-21 20:29:13 +07:00
Garret Wassermann
04f27fdcff
Use HTML5 table ordering based on Unix epoch
2016-11-21 00:12:24 -05:00
Jonathan Barratt
7738bba2ab
remove special-case imports for legacy versions
...
standardise use, or avoidance, of timezone, template from_string, and Context
2016-11-21 10:16:03 +07:00
Will Stott
f34696df8d
Use Django's six module for StringIO imports.
2016-11-17 11:25:46 +00:00
Garret Wassermann
97a24fbe22
Ensure that local files are deleted after processing, and add some information about it to the install.rst documentation
2016-11-12 11:32:04 +07:00
Jonathan Barratt
ebfea8274d
convert reverse-URL lookups to helpdesk namespace
...
in views.staff, this fixes:
-run_report's no-tickets-found redirect to report_index
-del_attachment's redirect to parent ticket view after deletion
2016-11-11 10:31:37 +07:00
Alex Barcelo
b0b68b9541
drop south_migrations folder
2016-11-02 17:22:47 +01:00
Alex Seeholzer
62163eaf0e
patch: implicit closing of open files;
2016-11-01 15:03:51 +01:00
Garret Wassermann
2a7d82413b
Miscellaneous improvements from review of #419
2016-10-31 02:57:08 -04:00
Garret Wassermann
37b9d332de
Fix some more missing namespace references for login and kb_category
2016-10-31 02:19:41 -04:00
Garret Wassermann
c74208325b
Removed test_per_queue_staff_permission assertion, report_index no longer returns unassigned_tickets
2016-10-31 02:06:49 -04:00
Garret Wassermann
26f4987726
Fix a missing helpdesk namespace reference in report_index.html
2016-10-31 01:42:45 -04:00
Garret Wassermann
194641613c
Sync with upstream, merged in AbstractForm with bootstrap class
2016-10-31 01:38:49 -04:00
Alex Barcelo
abd6fdcebe
simplifying if-case branches on CustomFieldMixin
2016-10-30 20:53:18 +01:00
Alex Barcelo
cce12181f0
refactoring single-letter variables into better names
2016-10-30 20:43:05 +01:00
Alex Barcelo
681a1893bd
missed a refactoring
2016-10-30 08:42:05 +01:00
Alex Barcelo
d8d10fae90
DRY in *TicketForm --by adding an Abstrat~ one
2016-10-30 08:39:17 +01:00
Alex Barcelo
bea6fbf75a
fixing a deprecated usage, and adding a minor branch control
2016-10-30 08:38:49 +01:00
Garret Wassermann
adf2b16c2c
Fix namespaces in test
2016-10-29 04:33:27 -04:00
Garret Wassermann
dc25164304
More PEP8 changes (hopefully last)
2016-10-29 04:27:29 -04:00
Garret Wassermann
4cf46156f1
More PEP8 changes
2016-10-29 04:20:16 -04:00
Garret Wassermann
1f1d477a35
Sync again with master 0.2
2016-10-29 04:11:41 -04:00
Garret Wassermann
d791700582
Fix PEP8 errors
2016-10-29 04:08:57 -04:00
Jonathan Barratt
28308d19fb
cleanup build-breaking whitespace merge errors
2016-10-29 14:59:14 +07:00
Garret Wassermann
cad174468b
Sync with namespace and other v0.2 changes
2016-10-29 03:47:15 -04:00
Jonathan Barratt
26c0f2e59f
Merge pull request #441 from alexbarcelo/api-prune
...
Remove all the deprecated API related files and references
2016-10-29 14:12:31 +07:00
Alex Barcelo
53ed0d3a2c
Remove all the deprecated API related files and references
2016-10-29 08:50:13 +02:00
Jonathan Barratt
43c067dd4f
merge changes from updated master
2016-10-29 13:35:03 +07:00
Jonathan Barratt
790f1fc003
Merge pull request #374 from alexbarcelo/urls_app_name
...
Set app_name as 'helpdesk' at the urls.py, and droping url prefixes
2016-10-28 15:59:29 +07:00
Alex Barcelo
6761ad6c10
fixing RST syntax for docstring on akismet.py
2016-10-26 10:22:15 +02:00
Alex Barcelo
f017adea63
fixing those two python files
2016-10-24 10:05:41 +02:00
Alex Barcelo
89a6ae01b8
Fixing style (according to branch 'autocodestyle') + quicktest
2016-10-24 08:04:31 +02:00
Alex Barcelo
179ceb2f82
fixing style on tests
2016-10-23 22:10:32 +02:00
Alex Barcelo
30e3aa55aa
almost auto-fix on misc files
2016-10-23 22:09:17 +02:00
Alex Barcelo
3c35473265
fixing views.py (except deprecated api)
2016-10-23 22:02:02 +02:00
Alex Barcelo
24d88be8d9
Initial general clean-up of stuff
2016-10-21 17:14:12 +02:00
Garret Wassermann
d7875587b7
Revert previous change
2016-10-20 12:05:28 -04:00
Garret Wassermann
884662dd21
Ensure binary data is returns so Django can decode it
2016-10-20 11:46:09 -04:00
Garret Wassermann
dfb7987ebb
Remove emails from queue in test_get_email
2016-10-20 11:17:51 -04:00
Garret Wassermann
197fad99d2
Remove mail templates since we're not testing them here; might be good to include a test for this elsewhere
2016-10-20 02:48:14 -04:00
Garret Wassermann
5e93297787
Fix call_command options for correct format to work with Django 1.7+
2016-10-20 02:29:23 -04:00
Garret Wassermann
6418194b85
Fix command line arg for Django 1.7 and make Python 2 and 3 compatible test
2016-10-20 02:21:43 -04:00
Garret Wassermann
9606201200
Fix mock tests for get_email (hopefully for good this time)
2016-10-20 02:09:05 -04:00
Garret Wassermann
b7ef83f7d2
Check that folder is a dir before checking for mail using get_email; fix unit test for --quiet
2016-10-20 01:39:24 -04:00
Garret Wassermann
e3c9e04feb
Fix python module naming in get_email test
2016-10-20 01:25:16 -04:00
