Commit Graph

1566 Commits

Author SHA1 Message Date
Georg Lehner
80ae20d1ac Fix: Saving tickets with attachments disabled raises error
Exclude code where followups add their attachments to a new ticket.
Make helper function _attach_files_to_follow_up() more robust.
2024-06-12 14:58:00 +02:00
Georg Lehner
20cd08fe28 Do not show attachments in public tickets if not enabled, fix attachment upload if enabled
Attachments in followups were still shown (if they existed) even if
HELPDESK_ENABLE_ATTACHMENT was set to False.

If attachments were enabled it was not possible to upload them because
the JavaScript code for uploading attachments to public was not loaded
in the template.
2024-06-10 12:47:13 +02:00
Georg Lehner
78cf89ca9b Exclude related JavaScript function from staff Ticket view when attachments are not enabled 2024-06-10 11:24:00 +02:00
Georg Lehner
3dcbdad638 Fix: helpdesk settings are imported as settings 2024-06-07 18:04:05 +02:00
Georg Lehner
a2f944b475 Enable attachments by default
In order to not break existing django-helpdesk installations
upon upgrade.
2024-06-07 17:58:41 +02:00
Georg Lehner
cc1b125d53 Disable email attachment processing and email saving if attachments are not enabled.
Caution: untested
2024-06-06 15:58:27 +02:00
Georg Lehner
dd4c04945a Add HELPDESK_ENABLE_ATTACHMENTS setting and make it show/hide attachment related UI
Default setting is false. This is not backward compatible.
The rationale is: attachments contain most likely sensitive information.
By default they are served without access control.  Currently there is
no simple feature to configure access control.  To avoid unintentional
disclosure attachments should be an opt in: you have been warned.
2024-06-06 15:47:50 +02:00
Georg Lehner
95755125fb Add datatables error message to error pop up 2024-05-14 21:46:18 +02:00
Georg Lehner
25f338cfc5 Pop up a nice error message when an AJAX request fails. 2024-05-11 16:41:01 +02:00
Benbb96
306a01a8b4
add login again button and reformat logged_out.html 2024-05-08 16:25:49 +02:00
Benbb96
ef5a43a3e2
remove unused import 2024-05-08 16:05:22 +02:00
Benbb96
485ac1294c
remove next_page parameter and show how to set LOGOUT_REDIRECT_URL in settings 2024-05-08 15:47:14 +02:00
Benbb96
b1316214c7
replace hardcoded path ../ to reverse_lazy URL 2024-05-07 15:50:51 +02:00
Benbb96
2d561d15c8
fix design on login/logout button when not staff 2024-05-07 15:43:12 +02:00
Benbb96
6fe5f1681f
fix logout in Django 5 with POST action instead of GET 2024-05-07 14:54:05 +02:00
ilikerobots
89ab173034 update raw parameter name to match view 2024-05-03 10:38:17 +03:00
Christopher Broderick
a6bb99f1e8
Merge branch 'main' into view_protectors 2024-04-29 21:25:36 +01:00
Christopher Broderick
dba8a889a3
Merge pull request #1172 from jorge-leon/fix-public-view-and-context-help-urls
FIX: replace hardcoded urls with Django generated ones. Fixes #1171
2024-04-24 19:05:07 +01:00
Timothy Hobbs
8f9d385e10
Merge branch 'main' into view_protectors 2024-04-23 21:29:38 +02:00
Timothy Hobbs
ebbbcdb2aa Deprecate VALID_EXTENSIONS properly 2024-04-22 18:38:59 +02:00
Georg Lehner
c723873d83 FIX: replace hardcoded urls with Django generated ones.
The My Tickets view generated ticket urls with a '/view' string prefix. This
is replaced by proper Django URL resolution.

The public and staff ticket view used a '../../' string prefix which brakes in
the public ticket view. They are both replaced with proper Django URL resolution.
2024-04-17 21:17:41 +02:00
Sam Splunks
8541acd49d Updated comment 2024-04-17 10:21:02 +00:00
Sam Splunks
2fc95d165a new_ticket_done signal emitted through email 2024-04-17 10:19:50 +00:00
Sam Splunks
81f9226f7c Removed unused webhooks import 2024-04-17 10:09:15 +00:00
Sam Splunks
9a6939b564 Attach send_new_ticket_webhook to the new_ticket_done signal 2024-04-17 10:02:44 +00:00
Sam Splunks
c6cad5f702 Removed unused webhooks import 2024-04-16 08:52:22 +00:00
Sam Splunks
c0ee8e0847 Use update_ticket mechanism in email.py 2024-04-16 08:49:11 +00:00
Sam Splunks
79b7ce9650 notify_followup_webhooks used in email, so moving signal triggering code 2024-04-16 08:42:03 +00:00
Sam Splunks
0e96909f43 Removed unused TichetChange import 2024-04-16 08:36:29 +00:00
Sam Splunks
08ed2a5035 Adding receiver import 2024-04-16 08:34:03 +00:00
Sam Splunks
ebb9a4d50d Make update_ticket_done signal trigger notify_followup_webhooks 2024-04-16 08:23:06 +00:00
Sam Splunks
2499f81d4d Add a signal when the ticket upate is done (every related instance created and updated) 2024-04-16 08:04:01 +00:00
Sam Splunks
8fffae343c Update TicketChange creation code 2024-04-16 07:58:33 +00:00
Sam Splunks
a775622521
Create ticket change through instance relationship
Co-authored-by: Benbb96 <Benbb96@users.noreply.github.com>
2024-04-12 10:44:56 +02:00
Sam Splunks
5b39c9aeeb
Update forloop for queues with explicit variable names in ticket template
Co-authored-by: Benbb96 <Benbb96@users.noreply.github.com>
2024-04-12 10:39:58 +02:00
Sam Splunks
62ef86a047 Settings assertion values in hours 2024-04-09 13:45:41 +00:00
Sam Splunks
aa5e2d0c67 Fixed test comment 2024-04-09 13:33:20 +00:00
Sam Splunks
d1af580483 Remove queues exclusion at the end of test 2024-04-09 13:32:11 +00:00
Sam Splunks
6e845f6351 Adding test for multiple exclusion queues through follow-ups 2024-04-09 13:27:42 +00:00
Sam Splunks
f4ab7a5226 Refactored time_spent calculation queue exclusions to reflect queue changes over time 2024-04-09 13:25:35 +00:00
Sam Splunks
e372f4447b Adding test_update_ticket_queue test 2024-04-09 12:18:43 +00:00
Sam Splunks
e526c21aef Update ticket queue foreign key id 2024-04-09 12:05:32 +00:00
Sam Splunks
33b3216d38
Merge branch 'django-helpdesk:main' into followup_queue_change 2024-04-09 12:01:12 +02:00
Sam Splunks
bb4e05ba39 Removed unused Queue model import 2024-04-08 12:43:11 +00:00
Sam Splunks
42be32b17b Allow to track queue change in follow-ups 2024-04-08 12:33:23 +00:00
Sam Splunks
e439acd626 Removed helpdesk_settings USE_TZ 2024-04-08 08:41:27 +00:00
Sam Splunks
27bafa847c Removed old comment 2024-04-08 08:39:27 +00:00
Sam Splunks
09f504fa3e Removing unnecessary followup saves 2024-04-08 08:37:00 +00:00
Sam Splunks
210b7b13f8 Removing unused test Client 2024-04-08 08:31:58 +00:00
Sam Splunks
b99514f585 Removed useless USE_TZ 2024-03-27 16:27:32 +00:00