Commit Graph

306 Commits

Author SHA1 Message Date
Sam Splunks
9ee0207c3c Save custom fields in a followup 2024-07-26 10:02:05 +00:00
Sam Splunks
8901086a80 If title cannot be retrieved from POST, default should be ticket.title 2024-07-26 09:08:10 +00:00
Sam Splunks
f8cccbcf0a Display custom fields in Follow-up form 2024-07-26 08:46:26 +00:00
Georg Lehner
0b38f1d5bd Remove superfluous use of Value() in When clause 2024-06-10 17:27:43 +02:00
Georg Lehner
54864b2c1e Rewrite dependency tickets ordering, using Case annotation 2024-06-10 10:08:07 +02:00
Georg Lehner
ec603347c7 Improve code quality 2024-06-08 22:32:05 +02:00
Georg Lehner
7bf21685b3 Fix: remove unused and undefined context variable 2024-06-08 12:52:10 +02:00
Georg Lehner
bc764b50c1 Fix: itertools are superseded by NotIn ORM operator 2024-06-08 12:12:56 +02:00
Georg Lehner
25c36a6f5c Restrict ticket selection for dependencies and parents
When adding a dependent or parent ticket, the choice field in the
ticket selection form excludes:

- All existing dependencies of the current ticket.
- All existing parent tickets of the current ticket.
- The current ticket itself.

The first two prevent immediate circular references: A dependency
cannot be a parent and vice versa.  Deeper circular references are
not covered by this: a ticket can still be its own grandchild.

They also prevent current behavior of throwing an `IntegrityException`
when selecting a dependency or parent.

The third one prevents also a quirky behavior: until now, specifying the
ticket itself as parent or dependency just does not save the
dependency and does not issue a warning either.
2024-06-08 12:11:01 +02:00
Georg Lehner
b52ab69c42 Order dependend ticket with NotIn ORM operator instead of itertools 2024-06-08 12:00:43 +02:00
Georg Lehner
d7afcb6578 Reformat Resolves/Depends lists into tables. Allow adding/deleting of parent tickets 2024-06-06 00:28:36 +02:00
Sam Splunks
42be32b17b Allow to track queue change in follow-ups 2024-04-08 12:33:23 +00:00
Timothy Hobbs
ffb7522e79 Use update_ticket method when placing ticket on hold 2023-11-26 16:40:52 +00:00
Christopher Broderick
6cba903827 Merge remote-tracking branch 'origin/main' into fix_unassigned_kbitems_not_visible_when_teams_not_active 2023-11-15 01:06:07 +00:00
Christopher Broderick
d65b103cc4
Merge pull request #1139 from timthelion/webhooks
Refactor update tickets view
2023-11-15 00:54:32 +00:00
Christopher Broderick
9195e4b738 Unassigned tickets lookup foix when teams is disabled. 2023-11-15 00:42:51 +00:00
Timothy Hobbs
b0ef6a5484 Fix #1138 by calling update_ticket directly from non-update views 2023-11-14 21:47:12 +01:00
Timothy Hobbs
ade4c3115e Move update ticket logic out of staff.py 2023-11-14 21:17:37 +01:00
Timothy Hobbs
6cd5522099 Move to ruff, its faster & catches more 2023-11-14 20:37:05 +01:00
Timothy Hobbs
21513d4524 Fix security problem with update_ticket view
@martin-marty Introduced a security flaw in this commit.

ecefd5e407#

By extracting authentication logic for the update_ticket view to a new function
and mixing the return types. This function returns both a Ticket object and a
login redirect. This is simply non-sensical and fails to actually login-redirect
non-authenticated users.
2023-11-11 22:26:19 +01:00
Benbb96
770cdc77b8
Add more tests 2023-05-01 22:54:41 +02:00
Benbb96
3b55f37fb5
Fix isort issues 2023-04-30 04:13:50 +02:00
Benbb96
3235333873
Drag & drop on ticket checklist tasks edition page + Use an empty form in order to better generate new task row dynamically 2023-04-30 03:56:42 +02:00
Benbb96
ef88a2ee8a
Better workflow for creating new ticket checklist, into a modal 2023-04-30 03:11:27 +02:00
Benbb96
11b2b36dd2
Allow updating task state when writing a ticket follow-up 2023-04-30 02:18:16 +02:00
Benbb96
308f69a03b
CRUD Checklist Template 2023-04-30 01:15:05 +02:00
Benbb96
af1ba5f205
Create a page to edit checklist name and tasks + another page for deletion 2023-04-29 00:24:06 +02:00
Benbb96
b8d06a0fb1
Show a form to create a new checklist, with the possibility to use a preset template 2023-04-23 00:36:10 +02:00
Christopher Broderick
1b3d97e183 Fix incorrectly removed time import 2023-04-03 10:49:01 +01:00
Christopher Broderick
7ff870ec88
Merge branch 'main' into #1075---add-options-for-date-and-datetime-input-in-ticket-view 2023-03-26 00:46:07 +00:00
Christopher Broderick
9e71fc8467 Remove redundant import 2023-03-25 13:21:27 +00:00
finnertysea
21ccc83d69 #1075 - make view agnostic to format of incoming due date 2023-03-17 13:12:03 -07:00
Christopher Broderick
930fc71d8b
Merge branch 'main' into fix-warnings 2023-03-10 23:52:46 +00:00
finnertysea
5279180221 Bug fix #1066 - modified import order to placate isort 2023-01-24 13:36:18 -05:00
finnertysea
71ff0aa6d5 Bug fix - detected due date change when no change was made 2023-01-20 10:53:35 -05:00
Benbb96
238dd8d3d5 Fix import order 2022-08-15 20:21:19 +02:00
Benbb96
bc3d89b555 Fix PyCharm warnings in staff.py 2022-08-15 20:15:02 +02:00
Martin Whitehouse
72392a3f50
Add update_summary_tables helper function
Reduces complexity of 'run_report' and handles updating summary table in
own function
2022-07-25 04:44:46 +02:00
Martin Whitehouse
205c69b539
Add get_report_table_and_totals helper function
Extracts a large portion of run_report handling
2022-07-25 04:41:01 +02:00
Martin Whitehouse
b1bf2cab46
Add get_report_queryset_or_redirect helper
Gets required objects or redirects
2022-07-25 04:35:49 +02:00
Martin Whitehouse
50bd72ac7a
Move import to top 2022-07-25 04:31:17 +02:00
Martin Whitehouse
d858c40416
Add check_redirect_on_user_query helper function
Extract the checking for a redirect to reduce complexity
2022-07-25 04:29:43 +02:00
Martin Whitehouse
f89f5b91da
Reinstate changes, fixed missing update 2022-07-25 04:23:03 +02:00
Martin Whitehouse
40a243c23b
Revert changes, updating objects missed somewhere 2022-07-25 04:15:53 +02:00
Martin Whitehouse
a248181857
Add redirect_from_chosen_ticket helper function
Moves the whole handling to own block, reducing complexity greatly.
2022-07-25 04:08:16 +02:00
Martin Whitehouse
eb11c4fe0e
Rename ticket_attriubtes to upper, module level constant. 2022-07-25 04:03:12 +02:00
Martin Whitehouse
a783156b61
Add merge_ticket_values helper
Extract a large portion of code from `merge_tickets`
2022-07-25 04:01:27 +02:00
Martin Whitehouse
b326103d82
Fix spacing 2022-07-25 03:48:06 +02:00
Martin Whitehouse
45e47846fe
py3.8 annotation fix 2022-07-25 03:45:36 +02:00
Martin Whitehouse
7b4d53cfc0
Fix 'list' annoation for py3.8 2022-07-25 03:44:04 +02:00